From aptmac at openjdk.org  Wed Oct  8 16:27:35 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 8 Oct 2025 16:27:35 GMT
Subject: RFR: 8365: Jolokia - Additional support for security mechanisms
 related to SSL / authentication, discovery restrictions [v3]
In-Reply-To: <VWwNSR6gx0BHT4JH3Nfw5gNpxjoN9w0k0ADTF5EAVnk=.abf0bcdc-2abd-4451-94b7-abb8e9b2cae3@github.com>
References: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
 <VWwNSR6gx0BHT4JH3Nfw5gNpxjoN9w0k0ADTF5EAVnk=.abf0bcdc-2abd-4451-94b7-abb8e9b2cae3@github.com>
Message-ID: <tIXa_WCABkzIH5mOk9JELah0oUi0AWsWPReftNFQ8XM=.55615794-1596-4467-a311-04e1641d7ae1@github.com>

On Tue, 29 Jul 2025 11:21:02 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JMC-8365: Make secure button updating null safe

Overall looks good to me, commented with a couple of minor things

application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizardPage.java line 441:

> 439: 			customUrlButton.setVisible(false);
> 440: 		}
> 441: 

Extra empty line

application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizardPage.java line 706:

> 704: 	}
> 705: 
> 706: 	private boolean requireSecureConnection() {

Small nit, but maybe this could be something like `isSecureConnectionRequired` ? Just thinking for initial readability where there's `requireSecureConnection(requireSecureConnection())` at line 682.

-------------

PR Review: https://git.openjdk.org/jmc/pull/665#pullrequestreview-3315623029
PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2414407062
PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2414413035

From aptmac at openjdk.org  Wed Oct  8 16:35:25 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 8 Oct 2025 16:35:25 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artefact
In-Reply-To: <KRoJKVuAJ17lULGyyOxUzmJbRlzSgV_Wlveejuc-eNY=.afca9906-e7b1-4ec5-acd1-9ba0c771411d@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
 <O9rrfshX0g105skR0EswEVGAMkiJnNCRNQxUtEiYkug=.25513ec8-ee22-451a-8150-9725865a2077@github.com>
 <KRoJKVuAJ17lULGyyOxUzmJbRlzSgV_Wlveejuc-eNY=.afca9906-e7b1-4ec5-acd1-9ba0c771411d@github.com>
Message-ID: <gn9utNCUjUrFkADtBU6HV_oxQ132ME9s-r1FOilOecA=.235eb580-b4c1-4b49-a1cd-4674e38f39a3@github.com>

On Mon, 8 Sep 2025 12:19:49 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> > I think Virag just meant the target platform, where all third party dependencies are exported over a p2.
> 
> Ok, I can try to include it

The `platform-definition-*.target` files will just need a `<unit id="org.awaitility" version="4.0.0"/>` added somewhere in the `<repository location="http://localhost:8080/site"/>` section.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/668#issuecomment-3382353871

From aharmaz at openjdk.org  Wed Oct  8 16:40:32 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Wed, 8 Oct 2025 16:40:32 GMT
Subject: Integrated: 8439: ArithmeticException thrown when plotting event count
 histogram with maxDuration set to 0
In-Reply-To: <qG9eXUVAkliCDipamMVPWCbSVYI5gu5Na1yyTW6BxFM=.e53e0667-99da-454f-a4a3-cd6b9223eb85@github.com>
References: <qG9eXUVAkliCDipamMVPWCbSVYI5gu5Na1yyTW6BxFM=.e53e0667-99da-454f-a4a3-cd6b9223eb85@github.com>
Message-ID: <-LJ8OwhMUfqF6k1UI1dtZ_yYG1WOXVVu_mRhUWB0rHg=.adc7e72c-7b77-4c83-a05e-5a7712f70d34@github.com>

On Tue, 23 Sep 2025 10:07:04 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> When plotting event count histogram and all event durations are set to 0, the duration range will be evaluated to 0, leading to an ArithmeticException (divid by 0), which stops JMC from plotting that histogram.
> 
> This can be shown on the attached screenshot, where only the percentile table is shown and the histogram chart is missing
> 
> <img width="1506" height="865" alt="missing-histogram" src="https://github.com/user-attachments/assets/7a02b705-83f3-45e9-9feb-91c5904064e7" />

This pull request has now been integrated.

Changeset: 58ca84a3
Author:    Aymane Harmaz <aharmaz at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/58ca84a33ae498669a6f598b2d335d0e407a284f
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8439: ArithmeticException thrown when plotting event count histogram with maxDuration set to 0

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/675

From aharmaz at openjdk.org  Fri Oct 10 16:13:41 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Fri, 10 Oct 2025 16:13:41 GMT
Subject: RFR: 8427: Text getting overlapped on graph of Processes screen
Message-ID: <Fp5vHlVBkRz7Pmx-99XASmwNY0uGTxnw8ZpRb9J1Df0=.ac28473b-d9c2-4e0b-bdb3-da15343c9460@github.com>

When the width of the chart title label exceeds the left margin ( xOffset) reserved for it, the label is truncated without taking into account the width of the y-axis tick labels. This can potentially lead to overlapping between the chart title and the y-axis tick labels.

Currently, the width of the y-axis tick labels is determined at the formatter level and is not dynamically available during chart label truncation.

Two potential workarounds are :

- Increase the xOffset size for the affected chart, allocating enough space to display both the chart title and the tick labels without overlap.
(This impacts only the chart in question.)
- Base Chart title label truncation on a default value for y-axis tick labels, even without access to exact tick widths.
(This impacts all charts.)

I followed the first strategy.

Screenshot of processes page post change : 

<img width="1173" height="343" alt="Screenshot 2025-10-10 at 17 02 40" src="https://github.com/user-attachments/assets/c490525f-b816-4bce-b242-621439ccf22e" />

-------------

Commit messages:
 - 8427: Text getting overlapped on graph of Processes screen

Changes: https://git.openjdk.org/jmc/pull/678/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=678&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8427
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/678.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/678/head:pull/678

PR: https://git.openjdk.org/jmc/pull/678