From aptmac at openjdk.org  Wed Oct  8 16:27:35 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 8 Oct 2025 16:27:35 GMT
Subject: RFR: 8365: Jolokia - Additional support for security mechanisms
 related to SSL / authentication, discovery restrictions [v3]
In-Reply-To: <VWwNSR6gx0BHT4JH3Nfw5gNpxjoN9w0k0ADTF5EAVnk=.abf0bcdc-2abd-4451-94b7-abb8e9b2cae3@github.com>
References: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
 <VWwNSR6gx0BHT4JH3Nfw5gNpxjoN9w0k0ADTF5EAVnk=.abf0bcdc-2abd-4451-94b7-abb8e9b2cae3@github.com>
Message-ID: <tIXa_WCABkzIH5mOk9JELah0oUi0AWsWPReftNFQ8XM=.55615794-1596-4467-a311-04e1641d7ae1@github.com>

On Tue, 29 Jul 2025 11:21:02 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JMC-8365: Make secure button updating null safe

Overall looks good to me, commented with a couple of minor things

application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizardPage.java line 441:

> 439: 			customUrlButton.setVisible(false);
> 440: 		}
> 441: 

Extra empty line

application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizardPage.java line 706:

> 704: 	}
> 705: 
> 706: 	private boolean requireSecureConnection() {

Small nit, but maybe this could be something like `isSecureConnectionRequired` ? Just thinking for initial readability where there's `requireSecureConnection(requireSecureConnection())` at line 682.

-------------

PR Review: https://git.openjdk.org/jmc/pull/665#pullrequestreview-3315623029
PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2414407062
PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2414413035

From aptmac at openjdk.org  Wed Oct  8 16:35:25 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 8 Oct 2025 16:35:25 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artefact
In-Reply-To: <KRoJKVuAJ17lULGyyOxUzmJbRlzSgV_Wlveejuc-eNY=.afca9906-e7b1-4ec5-acd1-9ba0c771411d@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
 <O9rrfshX0g105skR0EswEVGAMkiJnNCRNQxUtEiYkug=.25513ec8-ee22-451a-8150-9725865a2077@github.com>
 <KRoJKVuAJ17lULGyyOxUzmJbRlzSgV_Wlveejuc-eNY=.afca9906-e7b1-4ec5-acd1-9ba0c771411d@github.com>
Message-ID: <gn9utNCUjUrFkADtBU6HV_oxQ132ME9s-r1FOilOecA=.235eb580-b4c1-4b49-a1cd-4674e38f39a3@github.com>

On Mon, 8 Sep 2025 12:19:49 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> > I think Virag just meant the target platform, where all third party dependencies are exported over a p2.
> 
> Ok, I can try to include it

The `platform-definition-*.target` files will just need a `<unit id="org.awaitility" version="4.0.0"/>` added somewhere in the `<repository location="http://localhost:8080/site"/>` section.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/668#issuecomment-3382353871

From aharmaz at openjdk.org  Wed Oct  8 16:40:32 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Wed, 8 Oct 2025 16:40:32 GMT
Subject: Integrated: 8439: ArithmeticException thrown when plotting event count
 histogram with maxDuration set to 0
In-Reply-To: <qG9eXUVAkliCDipamMVPWCbSVYI5gu5Na1yyTW6BxFM=.e53e0667-99da-454f-a4a3-cd6b9223eb85@github.com>
References: <qG9eXUVAkliCDipamMVPWCbSVYI5gu5Na1yyTW6BxFM=.e53e0667-99da-454f-a4a3-cd6b9223eb85@github.com>
Message-ID: <-LJ8OwhMUfqF6k1UI1dtZ_yYG1WOXVVu_mRhUWB0rHg=.adc7e72c-7b77-4c83-a05e-5a7712f70d34@github.com>

On Tue, 23 Sep 2025 10:07:04 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> When plotting event count histogram and all event durations are set to 0, the duration range will be evaluated to 0, leading to an ArithmeticException (divid by 0), which stops JMC from plotting that histogram.
> 
> This can be shown on the attached screenshot, where only the percentile table is shown and the histogram chart is missing
> 
> <img width="1506" height="865" alt="missing-histogram" src="https://github.com/user-attachments/assets/7a02b705-83f3-45e9-9feb-91c5904064e7" />

This pull request has now been integrated.

Changeset: 58ca84a3
Author:    Aymane Harmaz <aharmaz at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/58ca84a33ae498669a6f598b2d335d0e407a284f
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8439: ArithmeticException thrown when plotting event count histogram with maxDuration set to 0

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/675

From aharmaz at openjdk.org  Fri Oct 10 16:13:41 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Fri, 10 Oct 2025 16:13:41 GMT
Subject: RFR: 8427: Text getting overlapped on graph of Processes screen
Message-ID: <Fp5vHlVBkRz7Pmx-99XASmwNY0uGTxnw8ZpRb9J1Df0=.ac28473b-d9c2-4e0b-bdb3-da15343c9460@github.com>

When the width of the chart title label exceeds the left margin ( xOffset) reserved for it, the label is truncated without taking into account the width of the y-axis tick labels. This can potentially lead to overlapping between the chart title and the y-axis tick labels.

Currently, the width of the y-axis tick labels is determined at the formatter level and is not dynamically available during chart label truncation.

Two potential workarounds are :

- Increase the xOffset size for the affected chart, allocating enough space to display both the chart title and the tick labels without overlap.
(This impacts only the chart in question.)
- Base Chart title label truncation on a default value for y-axis tick labels, even without access to exact tick widths.
(This impacts all charts.)

I followed the first strategy.

Screenshot of processes page post change : 

<img width="1173" height="343" alt="Screenshot 2025-10-10 at 17 02 40" src="https://github.com/user-attachments/assets/c490525f-b816-4bce-b242-621439ccf22e" />

-------------

Commit messages:
 - 8427: Text getting overlapped on graph of Processes screen

Changes: https://git.openjdk.org/jmc/pull/678/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=678&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8427
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/678.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/678/head:pull/678

PR: https://git.openjdk.org/jmc/pull/678

From duke at openjdk.org  Sat Oct 11 07:14:36 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Sat, 11 Oct 2025 07:14:36 GMT
Subject: RFR: 8365: Jolokia - Additional support for security mechanisms
 related to SSL / authentication, discovery restrictions [v4]
In-Reply-To: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
References: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
Message-ID: <JCNXDGHul_GuMW0KfGj_w8V1WVak6FG1l0rFkQTphLI=.7cc55082-f2ee-4b76-b39f-d35b06b31014@github.com>

> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-8365: Review fixes: whitespace correction and better naming

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/665/files
  - new: https://git.openjdk.org/jmc/pull/665/files/161f0d33..af937021

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=665&range=03
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=665&range=02-03

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/665.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/665/head:pull/665

PR: https://git.openjdk.org/jmc/pull/665

From duke at openjdk.org  Sat Oct 11 07:26:37 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Sat, 11 Oct 2025 07:26:37 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artefact [v2]
In-Reply-To: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
Message-ID: <l4558lxcWBqMP7Nav2f2uiMjW1IB1Cy0snf2DF-ZpN0=.ce4b1ae9-7beb-4fb9-9862-aa8aa1287eef@github.com>

> The Jolokia test plugin requires awaitility

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-8425: Include awaitility in platform definitions

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/668/files
  - new: https://git.openjdk.org/jmc/pull/668/files/8e3e4a32..863ab4aa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=668&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=668&range=00-01

  Stats: 5 lines in 5 files changed: 5 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/668.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/668/head:pull/668

PR: https://git.openjdk.org/jmc/pull/668

From duke at openjdk.org  Sun Oct 12 07:53:54 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Sun, 12 Oct 2025 07:53:54 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artefact [v3]
In-Reply-To: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
Message-ID: <_0NOMWLCryb5NhKhsBogT2EvbUjyZX_nhSgmj6zZkC8=.0d6a0ecf-b83d-45e7-9082-2054d9ea9a1a@github.com>

> The Jolokia test plugin requires awaitility

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge remote-tracking branch 'origin/master' into JMC-8425-missing-awaitility-3rdparty
 - JMC-8425: Include awaitility in platform definitions
 - JMC-8425: Ensure awaitlity is available as a 3rd party plugin

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/668/files
  - new: https://git.openjdk.org/jmc/pull/668/files/863ab4aa..f872fb9e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=668&range=02
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=668&range=01-02

  Stats: 1252 lines in 22 files changed: 681 ins; 18 del; 553 mod
  Patch: https://git.openjdk.org/jmc/pull/668.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/668/head:pull/668

PR: https://git.openjdk.org/jmc/pull/668

From duke at openjdk.org  Sun Oct 12 07:55:27 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Sun, 12 Oct 2025 07:55:27 GMT
Subject: RFR: 8365: Jolokia - Additional support for security mechanisms
 related to SSL / authentication, discovery restrictions [v5]
In-Reply-To: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
References: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
Message-ID: <o2_hJfGUiIzBh2M0GjyVX2Us7r4nqba6rzK2q_DyyuM=.969d53f4-7e55-4225-badb-b206826389bf@github.com>

> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:

 - Merge remote-tracking branch 'origin/master' into JMC-8365-require-secure-connection
 - JMC-8365: Review fixes: whitespace correction and better naming
 - JMC-8365: Make secure button updating null safe
 - JMC-8365: Fix spots
 - JMC-8365: Make secure button updating null safe
 - JMC-8365: Actually reflect require secure connection back in wizard
 - JMC-8369: revert JmcJolokiaPlugin.java
 - JMC-8365: Remove premature change
 - JMC-8365: Fixed spots
 - JMC-8365: Add option to require secure connection and give hint in error connection if it fails

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/665/files
  - new: https://git.openjdk.org/jmc/pull/665/files/af937021..850a233c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=665&range=04
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=665&range=03-04

  Stats: 2183175 lines in 239 files changed: 2181551 ins; 578 del; 1046 mod
  Patch: https://git.openjdk.org/jmc/pull/665.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/665/head:pull/665

PR: https://git.openjdk.org/jmc/pull/665

From duke at openjdk.org  Sun Oct 12 18:35:12 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Sun, 12 Oct 2025 18:35:12 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy [v5]
In-Reply-To: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
Message-ID: <AZemjrScwDLTC8Ou195m7g3N2aePKWH1khjLVOQgCb8=.d0daaa31-18a6-4980-a1c1-ae1864169dff@github.com>

> JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
> 
> Testing connectivity:
> - [x]  Docker desktop kubernetes 
> - [x]  Azure AKS
> - [x]  Amazon EKS
> - [x]  Google GKE
> 
> Other things observed:
> 
> - [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
> - [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
> - [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
> - [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:

 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - JMC-8237: Upgrade jolokia 2.2.2 -> 2.2.9
 - JMC-8237: Upgrade jolokia 2.2.2 -> 2.2.9
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - JMC-8237: Removed dead assignment
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - JMC-8237: Remove unneeded changes
 - JMC-8237: Updated bundle version to 10.0.0. Updated copyright year
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - JMC-8237: Upgrade to jolokia 2.2.2
 - ... and 19 more: https://git.openjdk.org/jmc/compare/58ca84a3...2fed8612

-------------

Changes: https://git.openjdk.org/jmc/pull/576/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=576&range=04
  Stats: 2425 lines in 59 files changed: 2399 ins; 0 del; 26 mod
  Patch: https://git.openjdk.org/jmc/pull/576.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/576/head:pull/576

PR: https://git.openjdk.org/jmc/pull/576

From duke at openjdk.org  Mon Oct 13 13:17:52 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Mon, 13 Oct 2025 13:17:52 GMT
Subject: RFR: 8365: Jolokia - Additional support for security mechanisms
 related to SSL / authentication, discovery restrictions [v3]
In-Reply-To: <tIXa_WCABkzIH5mOk9JELah0oUi0AWsWPReftNFQ8XM=.55615794-1596-4467-a311-04e1641d7ae1@github.com>
References: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
 <VWwNSR6gx0BHT4JH3Nfw5gNpxjoN9w0k0ADTF5EAVnk=.abf0bcdc-2abd-4451-94b7-abb8e9b2cae3@github.com>
 <tIXa_WCABkzIH5mOk9JELah0oUi0AWsWPReftNFQ8XM=.55615794-1596-4467-a311-04e1641d7ae1@github.com>
Message-ID: <L4rMOyl1owhIbvM1uluZEe1KNXr47tiCtf7nMvb7iiU=.07c88c96-a206-4c45-9cf3-02b963e3666a@github.com>

On Wed, 8 Oct 2025 16:21:42 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JMC-8365: Make secure button updating null safe
>
> application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizardPage.java line 441:
> 
>> 439: 			customUrlButton.setVisible(false);
>> 440: 		}
>> 441: 
> 
> Extra empty line

@aptmac fixed

> application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizardPage.java line 706:
> 
>> 704: 	}
>> 705: 
>> 706: 	private boolean requireSecureConnection() {
> 
> Small nit, but maybe this could be something like `isSecureConnectionRequired` ? Just thinking for initial readability where there's `requireSecureConnection(requireSecureConnection())` at line 682.

@aptmac fixed

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2426321833
PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2426322266

From duke at openjdk.org  Mon Oct 13 13:17:51 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Mon, 13 Oct 2025 13:17:51 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artefact
In-Reply-To: <gn9utNCUjUrFkADtBU6HV_oxQ132ME9s-r1FOilOecA=.235eb580-b4c1-4b49-a1cd-4674e38f39a3@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
 <O9rrfshX0g105skR0EswEVGAMkiJnNCRNQxUtEiYkug=.25513ec8-ee22-451a-8150-9725865a2077@github.com>
 <KRoJKVuAJ17lULGyyOxUzmJbRlzSgV_Wlveejuc-eNY=.afca9906-e7b1-4ec5-acd1-9ba0c771411d@github.com>
 <gn9utNCUjUrFkADtBU6HV_oxQ132ME9s-r1FOilOecA=.235eb580-b4c1-4b49-a1cd-4674e38f39a3@github.com>
Message-ID: <fLa1MV-aUidoDfrsI-zNl0rxAJHQks4KzIpXpxHI5o8=.f811bfeb-a1d4-4e67-8b5c-cc4a69038245@github.com>

On Wed, 8 Oct 2025 16:32:42 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> > > I think Virag just meant the target platform, where all third party dependencies are exported over a p2.
> > 
> > 
> > Ok, I can try to include it
> 
> The `platform-definition-*.target` files will just need a `<unit id="org.awaitility" version="4.0.0"/>` added somewhere in the `<repository location="http://localhost:8080/site"/>` section.

Added in latest commit

-------------

PR Comment: https://git.openjdk.org/jmc/pull/668#issuecomment-3397491337

From duke at openjdk.org  Mon Oct 13 13:20:58 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Mon, 13 Oct 2025 13:20:58 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artefact [v3]
In-Reply-To: <_0NOMWLCryb5NhKhsBogT2EvbUjyZX_nhSgmj6zZkC8=.0d6a0ecf-b83d-45e7-9082-2054d9ea9a1a@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
 <_0NOMWLCryb5NhKhsBogT2EvbUjyZX_nhSgmj6zZkC8=.0d6a0ecf-b83d-45e7-9082-2054d9ea9a1a@github.com>
Message-ID: <U0v5HSIcF8nelLMWL2QkY1FgHmZD_n9r2pZiZL2spKQ=.1e1514a6-9acd-47b6-9b8a-514de67bd5a2@github.com>

On Sun, 12 Oct 2025 07:53:54 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> The Jolokia test plugin requires awaitility
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into JMC-8425-missing-awaitility-3rdparty
>  - JMC-8425: Include awaitility in platform definitions
>  - JMC-8425: Ensure awaitlity is available as a 3rd party plugin

PR was closed by misclick on my part. Reopened now.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/668#issuecomment-3397500236

From aptmac at openjdk.org  Tue Oct 14 14:29:22 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 14 Oct 2025 14:29:22 GMT
Subject: RFR: 8365: Jolokia - Additional support for security mechanisms
 related to SSL / authentication, discovery restrictions [v5]
In-Reply-To: <o2_hJfGUiIzBh2M0GjyVX2Us7r4nqba6rzK2q_DyyuM=.969d53f4-7e55-4225-badb-b206826389bf@github.com>
References: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
 <o2_hJfGUiIzBh2M0GjyVX2Us7r4nqba6rzK2q_DyyuM=.969d53f4-7e55-4225-badb-b206826389bf@github.com>
Message-ID: <f6taGo7MCgNTMl0K9CQ5BHl-IqqFYDeXbqrtKW3c1mo=.480694c9-55fe-48aa-8327-a039c31abe51@github.com>

On Sun, 12 Oct 2025 07:55:27 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into JMC-8365-require-secure-connection
>  - JMC-8365: Review fixes: whitespace correction and better naming
>  - JMC-8365: Make secure button updating null safe
>  - JMC-8365: Fix spots
>  - JMC-8365: Make secure button updating null safe
>  - JMC-8365: Actually reflect require secure connection back in wizard
>  - JMC-8369: revert JmcJolokiaPlugin.java
>  - JMC-8365: Remove premature change
>  - JMC-8365: Fixed spots
>  - JMC-8365: Add option to require secure connection and give hint in error connection if it fails

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/665#pullrequestreview-3335994074

From aptmac at openjdk.org  Tue Oct 14 14:30:29 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 14 Oct 2025 14:30:29 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artefact [v3]
In-Reply-To: <_0NOMWLCryb5NhKhsBogT2EvbUjyZX_nhSgmj6zZkC8=.0d6a0ecf-b83d-45e7-9082-2054d9ea9a1a@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
 <_0NOMWLCryb5NhKhsBogT2EvbUjyZX_nhSgmj6zZkC8=.0d6a0ecf-b83d-45e7-9082-2054d9ea9a1a@github.com>
Message-ID: <JOdfb-_gW0kO5EoCVIy36TpHlTNiSLhCMhF7nmifF_w=.f09e114c-dc5e-4743-a122-47bff8b44e89@github.com>

On Sun, 12 Oct 2025 07:53:54 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> The Jolokia test plugin requires awaitility
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into JMC-8425-missing-awaitility-3rdparty
>  - JMC-8425: Include awaitility in platform definitions
>  - JMC-8425: Ensure awaitlity is available as a 3rd party plugin

Looks good, sorry I missed this but there's one last nit here: the commit and ticket have a typo in "artefact" -> "artifact". Should be good to go after that.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/668#issuecomment-3402157004

From duke at openjdk.org  Tue Oct 14 14:47:54 2025
From: duke at openjdk.org (duke)
Date: Tue, 14 Oct 2025 14:47:54 GMT
Subject: RFR: 8365: Jolokia - Additional support for security mechanisms
 related to SSL / authentication, discovery restrictions [v5]
In-Reply-To: <o2_hJfGUiIzBh2M0GjyVX2Us7r4nqba6rzK2q_DyyuM=.969d53f4-7e55-4225-badb-b206826389bf@github.com>
References: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
 <o2_hJfGUiIzBh2M0GjyVX2Us7r4nqba6rzK2q_DyyuM=.969d53f4-7e55-4225-badb-b206826389bf@github.com>
Message-ID: <0Revq6oDhEFrI73KKKDY7UkeOfdP3tF__YrwkW7C5W0=.bb6211a8-0818-4fd7-8b7d-4bae2abbd643@github.com>

On Sun, 12 Oct 2025 07:55:27 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into JMC-8365-require-secure-connection
>  - JMC-8365: Review fixes: whitespace correction and better naming
>  - JMC-8365: Make secure button updating null safe
>  - JMC-8365: Fix spots
>  - JMC-8365: Make secure button updating null safe
>  - JMC-8365: Actually reflect require secure connection back in wizard
>  - JMC-8369: revert JmcJolokiaPlugin.java
>  - JMC-8365: Remove premature change
>  - JMC-8365: Fixed spots
>  - JMC-8365: Add option to require secure connection and give hint in error connection if it fails

@skarsaune 
Your change (at version 850a233c757e15a39e02389c2b7b5420c0ae3a51) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/665#issuecomment-3402233568

From duke at openjdk.org  Tue Oct 14 14:51:05 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Tue, 14 Oct 2025 14:51:05 GMT
Subject: Integrated: 8365: Jolokia - Additional support for security mechanisms
 related to SSL / authentication, discovery restrictions
In-Reply-To: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
References: <fFSTAZuM0F9sawsCrZsg_QCxMRLNs2zKc-9gqVumn3M=.b76bca4e-62fa-41e2-b55a-dec9431faab3@github.com>
Message-ID: <4s_aLeRkp6bpe-5iHEgjvQg-Aq4sHs8cu_LGvMhlQwk=.a8db1506-3db4-44dd-9d5f-7266d173a86d@github.com>

On Sat, 12 Jul 2025 14:59:27 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> Note: The majority of the work in this PR is to make it work well with RMI connections. For Jolokia however, it should work out of the box as setting the env var will force https.

This pull request has now been integrated.

Changeset: 2bb16fac
Author:    Martin Skarsaune <martin at skarsaune.net>
Committer: Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/2bb16fac46d30417692c50ddd6dadb9fd1a874c4
Stats:     66 lines in 12 files changed: 55 ins; 1 del; 10 mod

8365: Jolokia - Additional support for security mechanisms related to SSL / authentication, discovery restrictions

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/665

From duke at openjdk.org  Tue Oct 14 15:04:19 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Tue, 14 Oct 2025 15:04:19 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artifact [v3]
In-Reply-To: <JOdfb-_gW0kO5EoCVIy36TpHlTNiSLhCMhF7nmifF_w=.f09e114c-dc5e-4743-a122-47bff8b44e89@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
 <_0NOMWLCryb5NhKhsBogT2EvbUjyZX_nhSgmj6zZkC8=.0d6a0ecf-b83d-45e7-9082-2054d9ea9a1a@github.com>
 <JOdfb-_gW0kO5EoCVIy36TpHlTNiSLhCMhF7nmifF_w=.f09e114c-dc5e-4743-a122-47bff8b44e89@github.com>
Message-ID: <Z8g9rzzaQcpzErCueo7eHGc1qOlabmgKuxREu7S9fJk=.42dc8741-1658-4005-8286-4ad49a5805ff@github.com>

On Tue, 14 Oct 2025 14:27:33 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/master' into JMC-8425-missing-awaitility-3rdparty
>>  - JMC-8425: Include awaitility in platform definitions
>>  - JMC-8425: Ensure awaitlity is available as a 3rd party plugin
>
> Looks good, sorry I missed this but there's one last nit here: the commit and ticket have a typo in "artefact" -> "artifact". Should be good to go after that.

@aptmac Nice catch. Will fix once I'm back at my computer

-------------

PR Comment: https://git.openjdk.org/jmc/pull/668#issuecomment-3402307988

From duke at openjdk.org  Tue Oct 14 18:30:13 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Tue, 14 Oct 2025 18:30:13 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artifact [v3]
In-Reply-To: <_0NOMWLCryb5NhKhsBogT2EvbUjyZX_nhSgmj6zZkC8=.0d6a0ecf-b83d-45e7-9082-2054d9ea9a1a@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
 <_0NOMWLCryb5NhKhsBogT2EvbUjyZX_nhSgmj6zZkC8=.0d6a0ecf-b83d-45e7-9082-2054d9ea9a1a@github.com>
Message-ID: <bT9B7PB1f6uC8BJ1xfvN9mT9eaW6PB3Ec-sbr88S4eM=.cf291236-754e-42b2-bad9-b0530622d515@github.com>

On Sun, 12 Oct 2025 07:53:54 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> The Jolokia test plugin requires awaitility
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into JMC-8425-missing-awaitility-3rdparty
>  - JMC-8425: Include awaitility in platform definitions
>  - JMC-8425: Ensure awaitlity is available as a 3rd party plugin

Done

-------------

PR Comment: https://git.openjdk.org/jmc/pull/668#issuecomment-3403106027

From aptmac at openjdk.org  Tue Oct 14 18:35:51 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 14 Oct 2025 18:35:51 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artifact [v3]
In-Reply-To: <_0NOMWLCryb5NhKhsBogT2EvbUjyZX_nhSgmj6zZkC8=.0d6a0ecf-b83d-45e7-9082-2054d9ea9a1a@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
 <_0NOMWLCryb5NhKhsBogT2EvbUjyZX_nhSgmj6zZkC8=.0d6a0ecf-b83d-45e7-9082-2054d9ea9a1a@github.com>
Message-ID: <JZ794ty9vwMypKfiOMbVHSi9qQZnVU7EDHCM3H7xe-0=.cff53a2b-4b1c-40e2-8992-6f0fb59c76c2@github.com>

On Sun, 12 Oct 2025 07:53:54 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> The Jolokia test plugin requires awaitility
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into JMC-8425-missing-awaitility-3rdparty
>  - JMC-8425: Include awaitility in platform definitions
>  - JMC-8425: Ensure awaitlity is available as a 3rd party plugin

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/668#pullrequestreview-3336962093

From duke at openjdk.org  Tue Oct 14 18:38:38 2025
From: duke at openjdk.org (duke)
Date: Tue, 14 Oct 2025 18:38:38 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artifact [v3]
In-Reply-To: <_0NOMWLCryb5NhKhsBogT2EvbUjyZX_nhSgmj6zZkC8=.0d6a0ecf-b83d-45e7-9082-2054d9ea9a1a@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
 <_0NOMWLCryb5NhKhsBogT2EvbUjyZX_nhSgmj6zZkC8=.0d6a0ecf-b83d-45e7-9082-2054d9ea9a1a@github.com>
Message-ID: <hr9u4Lz2X5alYsNh-2WKdPxmvs5cdv_DTlZZDM7UvNA=.71cbd6cc-dfa7-4f89-98d6-4c4e2b08f5aa@github.com>

On Sun, 12 Oct 2025 07:53:54 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> The Jolokia test plugin requires awaitility
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into JMC-8425-missing-awaitility-3rdparty
>  - JMC-8425: Include awaitility in platform definitions
>  - JMC-8425: Ensure awaitlity is available as a 3rd party plugin

@skarsaune 
Your change (at version f872fb9e2d4f712ed126f8d502b900bc43b42321) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/668#issuecomment-3403132336

From duke at openjdk.org  Tue Oct 14 20:07:35 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Tue, 14 Oct 2025 20:07:35 GMT
Subject: Integrated: 8425: Problem importing in Eclipse due to missing
 awatility 3rd party artifact
In-Reply-To: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
Message-ID: <clW0woiSwbi_qN5xLfH2mD69k4IS1AT5evcLyKYkccc=.d8e53981-f4c6-441d-94ff-9560a35a66fc@github.com>

On Sun, 27 Jul 2025 17:44:53 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> The Jolokia test plugin requires awaitility

This pull request has now been integrated.

Changeset: 3922e8ae
Author:    Martin Skarsaune <martin at skarsaune.net>
Committer: Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/3922e8ae6c557b4deb94d592619d17910c2e4fc3
Stats:     8 lines in 6 files changed: 8 ins; 0 del; 0 mod

8425: Problem importing in Eclipse due to missing awatility 3rd party artifact

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/668

From aharmaz at openjdk.org  Fri Oct 17 15:46:23 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Fri, 17 Oct 2025 15:46:23 GMT
Subject: RFR: 6004: Should add tenuring summary to the GC visualization
Message-ID: <xJDBMcDqNzHZCxOBLHYoMxbd7OiV-YbT9RW5w01Ss94=.57626599-d845-4426-935d-63438bfb72a4@github.com>

This change adds a new tab to display the tenuring distribution for GC cycles.

There are 3 case scenarios:
- Single GC cycle selected: A histogram chart is shown representing the tenuring distribution (total size across ages) for the selected cycle.
- No GC cycle selected: An informational message is displayed to prompt the user to select a cycle.
- Multiple GC cycles selected: An informational message is displayed indicating that only a single cycle can be viewed at a time.
This enhancement improves visibility into object tenuring during individual GC cycles. 

<img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 19" src="https://github.com/user-attachments/assets/76ce69c2-60eb-48c8-be9f-6387cbfa7c42" />

<img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 34" src="https://github.com/user-attachments/assets/a5fc9bc9-fa72-42c9-aeb2-ecad21e4ac66" />

<img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 57" src="https://github.com/user-attachments/assets/63ffba47-8e08-430a-9a28-11473b59e6dc" />

-------------

Commit messages:
 - 6004: Should add tenuring summary to the GC visualization

Changes: https://git.openjdk.org/jmc/pull/679/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=679&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-6004
  Stats: 94 lines in 9 files changed: 94 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/679.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/679/head:pull/679

PR: https://git.openjdk.org/jmc/pull/679

From hirt at openjdk.org  Wed Oct 22 15:16:12 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 22 Oct 2025 15:16:12 GMT
Subject: RFR: 6004: Should add tenuring summary to the GC visualization
In-Reply-To: <xJDBMcDqNzHZCxOBLHYoMxbd7OiV-YbT9RW5w01Ss94=.57626599-d845-4426-935d-63438bfb72a4@github.com>
References: <xJDBMcDqNzHZCxOBLHYoMxbd7OiV-YbT9RW5w01Ss94=.57626599-d845-4426-935d-63438bfb72a4@github.com>
Message-ID: <jE2re_PGYINdIxsbvxlPuGpIsdgw1iV9mNp4pW1Dv-I=.99625a8b-f9b3-4efd-991e-10e9f9e45edd@github.com>

On Fri, 17 Oct 2025 15:39:33 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This change adds a new tab to display the tenuring distribution for GC cycles.
> 
> There are 3 case scenarios:
> - Single GC cycle selected: A histogram chart is shown representing the tenuring distribution (total size across ages) for the selected cycle.
> - No GC cycle selected: An informational message is displayed to prompt the user to select a cycle.
> - Multiple GC cycles selected: An informational message is displayed indicating that only a single cycle can be viewed at a time.
> This enhancement improves visibility into object tenuring during individual GC cycles. 
> 
> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 19" src="https://github.com/user-attachments/assets/76ce69c2-60eb-48c8-be9f-6387cbfa7c42" />
> 
> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 34" src="https://github.com/user-attachments/assets/a5fc9bc9-fa72-42c9-aeb2-ecad21e4ac66" />
> 
> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 57" src="https://github.com/user-attachments/assets/63ffba47-8e08-430a-9a28-11473b59e6dc" />

Looks good Aymane! Do you also handle the case where the event is off, so that there aren't any tenuring distribution events available at all?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/679#issuecomment-3432937675

From hirt at openjdk.org  Wed Oct 22 15:20:22 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 22 Oct 2025 15:20:22 GMT
Subject: RFR: 6004: Should add tenuring summary to the GC visualization
In-Reply-To: <xJDBMcDqNzHZCxOBLHYoMxbd7OiV-YbT9RW5w01Ss94=.57626599-d845-4426-935d-63438bfb72a4@github.com>
References: <xJDBMcDqNzHZCxOBLHYoMxbd7OiV-YbT9RW5w01Ss94=.57626599-d845-4426-935d-63438bfb72a4@github.com>
Message-ID: <uAdTTMAj4U3PfWAZv7Cc4vBTch8SR0c0EM7YULQ8QsM=.7dd9963c-ee0e-45ea-97c4-7f16c4746c0c@github.com>

On Fri, 17 Oct 2025 15:39:33 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This change adds a new tab to display the tenuring distribution for GC cycles.
> 
> There are 3 case scenarios:
> - Single GC cycle selected: A histogram chart is shown representing the tenuring distribution (total size across ages) for the selected cycle.
> - No GC cycle selected: An informational message is displayed to prompt the user to select a cycle.
> - Multiple GC cycles selected: An informational message is displayed indicating that only a single cycle can be viewed at a time.
> This enhancement improves visibility into object tenuring during individual GC cycles. 
> 
> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 19" src="https://github.com/user-attachments/assets/76ce69c2-60eb-48c8-be9f-6387cbfa7c42" />
> 
> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 34" src="https://github.com/user-attachments/assets/a5fc9bc9-fa72-42c9-aeb2-ecad21e4ac66" />
> 
> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 57" src="https://github.com/user-attachments/assets/63ffba47-8e08-430a-9a28-11473b59e6dc" />

Marked as reviewed by hirt (Lead).

application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties line 349:

> 347: GarbageCollectionsPage_TENURING_DISTRIBUTION_TITLE=Tenuring Distribution
> 348: GarbageCollectionsPage_TENURING_DISTRIBUTION_NO_SELECTION_MESSAGE=No valid Selection
> 349: GarbageCollectionsPage_TENURING_DISTRIBUTION_MULTI_SELECTION_MESSAGE=Distribution is shown for a single GC cycle

Perhaps this can be more specific? "Multiple GC cycles selected. Distribution is only shown for a single GC."

-------------

PR Review: https://git.openjdk.org/jmc/pull/679#pullrequestreview-3366309268
PR Review Comment: https://git.openjdk.org/jmc/pull/679#discussion_r2452460600

From hirt at openjdk.org  Wed Oct 22 15:25:48 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 22 Oct 2025 15:25:48 GMT
Subject: RFR: 8427: Text getting overlapped on graph of Processes screen
In-Reply-To: <Fp5vHlVBkRz7Pmx-99XASmwNY0uGTxnw8ZpRb9J1Df0=.ac28473b-d9c2-4e0b-bdb3-da15343c9460@github.com>
References: <Fp5vHlVBkRz7Pmx-99XASmwNY0uGTxnw8ZpRb9J1Df0=.ac28473b-d9c2-4e0b-bdb3-da15343c9460@github.com>
Message-ID: <4cPn5dyfgGU3rKhfDdJEH1pADRqSc4IFlGn7Uh5Y2xE=.b0093937-3fa2-45dd-bff6-6d8a547cf017@github.com>

On Fri, 10 Oct 2025 16:09:39 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> When the width of the chart title label exceeds the left margin ( xOffset) reserved for it, the label is truncated without taking into account the width of the y-axis tick labels. This can potentially lead to overlapping between the chart title and the y-axis tick labels.
> 
> Currently, the width of the y-axis tick labels is determined at the formatter level and is not dynamically available during chart label truncation.
> 
> Two potential workarounds are :
> 
> - Increase the xOffset size for the affected chart, allocating enough space to display both the chart title and the tick labels without overlap.
> (This impacts only the chart in question.)
> - Base Chart title label truncation on a default value for y-axis tick labels, even without access to exact tick widths.
> (This impacts all charts.)
> 
> I followed the first strategy.
> 
> Screenshot of processes page post change : 
> 
> <img width="1173" height="343" alt="Screenshot 2025-10-10 at 17 02 40" src="https://github.com/user-attachments/assets/c490525f-b816-4bce-b242-621439ccf22e" />

Marked as reviewed by hirt (Lead).

I'll approve. It would be nice in the future to be able to avoid magic numbers, but this at least leaves us in a better place.

-------------

PR Review: https://git.openjdk.org/jmc/pull/678#pullrequestreview-3366338259
PR Comment: https://git.openjdk.org/jmc/pull/678#issuecomment-3432989111

From schaturvedi at openjdk.org  Wed Oct 22 15:40:58 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Wed, 22 Oct 2025 15:40:58 GMT
Subject: RFR: 5561: Support for Crypto Events in JMC
Message-ID: <mV2RVfDpwqgDwadhDAShlmS4Z0-M14GXiFftir_KV_Y=.14235a7c-f673-4443-9997-aeb5292d1a8b@github.com>

This PR enhances the JMC UI for adding new information related to crypto events: specifically X509CertificateEvent.

This PR adds a new rule with respect to X509CertificateEvent which provides alert related to expired/expiring certificates and weak signature algorithms or weak key length or key type. The rule gives a basic overview, however complete details are provided as part of a new screen - Security.

Attaching the screenshots here for better reference:

<img width="356" height="61" alt="image" src="https://github.com/user-attachments/assets/97395a02-9626-4bc8-933c-a11d3f8157bd" />

<img width="959" height="505" alt="image" src="https://github.com/user-attachments/assets/9d8a74f0-0302-4e72-8933-2b58dfe9ba42" />

-------------

Commit messages:
 - 5561: Support for Crypto Events in JMC

Changes: https://git.openjdk.org/jmc/pull/680/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=680&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-5561
  Stats: 884 lines in 26 files changed: 884 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/680.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/680/head:pull/680

PR: https://git.openjdk.org/jmc/pull/680

From schaturvedi at openjdk.org  Wed Oct 22 16:17:15 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Wed, 22 Oct 2025 16:17:15 GMT
Subject: RFR: 5561: Support for Crypto Events in JMC [v2]
In-Reply-To: <mV2RVfDpwqgDwadhDAShlmS4Z0-M14GXiFftir_KV_Y=.14235a7c-f673-4443-9997-aeb5292d1a8b@github.com>
References: <mV2RVfDpwqgDwadhDAShlmS4Z0-M14GXiFftir_KV_Y=.14235a7c-f673-4443-9997-aeb5292d1a8b@github.com>
Message-ID: <t_X038kQVU3JuSctBBePElbGs3lNv24Cyo_IFiBGl9M=.36a5c65e-f1c1-4a76-825b-ab2d137df1d3@github.com>

> This PR enhances the JMC UI for adding new information related to crypto events: specifically X509CertificateEvent.
> 
> This PR adds a new rule with respect to X509CertificateEvent which provides alert related to expired/expiring certificates and weak signature algorithms or weak key length or key type. The rule gives a basic overview, however complete details are provided as part of a new screen - Security.
> 
> Attaching the screenshots here for better reference:
> 
> <img width="356" height="61" alt="image" src="https://github.com/user-attachments/assets/97395a02-9626-4bc8-933c-a11d3f8157bd" />
> 
> <img width="959" height="505" alt="image" src="https://github.com/user-attachments/assets/9d8a74f0-0302-4e72-8933-2b58dfe9ba42" />

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Fix tests run failure

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/680/files
  - new: https://git.openjdk.org/jmc/pull/680/files/fc0e5c90..26c937fc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=680&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=680&range=00-01

  Stats: 92 lines in 1 file changed: 0 ins; 92 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/680.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/680/head:pull/680

PR: https://git.openjdk.org/jmc/pull/680

From duke at openjdk.org  Wed Oct 22 18:13:00 2025
From: duke at openjdk.org (duke)
Date: Wed, 22 Oct 2025 18:13:00 GMT
Subject: RFR: 8427: Text getting overlapped on graph of Processes screen
In-Reply-To: <Fp5vHlVBkRz7Pmx-99XASmwNY0uGTxnw8ZpRb9J1Df0=.ac28473b-d9c2-4e0b-bdb3-da15343c9460@github.com>
References: <Fp5vHlVBkRz7Pmx-99XASmwNY0uGTxnw8ZpRb9J1Df0=.ac28473b-d9c2-4e0b-bdb3-da15343c9460@github.com>
Message-ID: <O8c8F3otzGPpaMkN-tX-eSqziWrhS8n8RaNCc7u3LOA=.5d329dda-2d69-4b37-b998-a2a28f13259c@github.com>

On Fri, 10 Oct 2025 16:09:39 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> When the width of the chart title label exceeds the left margin ( xOffset) reserved for it, the label is truncated without taking into account the width of the y-axis tick labels. This can potentially lead to overlapping between the chart title and the y-axis tick labels.
> 
> Currently, the width of the y-axis tick labels is determined at the formatter level and is not dynamically available during chart label truncation.
> 
> Two potential workarounds are :
> 
> - Increase the xOffset size for the affected chart, allocating enough space to display both the chart title and the tick labels without overlap.
> (This impacts only the chart in question.)
> - Base Chart title label truncation on a default value for y-axis tick labels, even without access to exact tick widths.
> (This impacts all charts.)
> 
> I followed the first strategy.
> 
> Screenshot of processes page post change : 
> 
> <img width="1173" height="343" alt="Screenshot 2025-10-10 at 17 02 40" src="https://github.com/user-attachments/assets/c490525f-b816-4bce-b242-621439ccf22e" />

@aymane-harmaz 
Your change (at version e6e197d259b47214ff458f5149bbd009e68f3f4e) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/678#issuecomment-3433598887

From aharmaz at openjdk.org  Thu Oct 23 14:35:54 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Thu, 23 Oct 2025 14:35:54 GMT
Subject: RFR: 6004: Should add tenuring summary to the GC visualization
 [v2]
In-Reply-To: <xJDBMcDqNzHZCxOBLHYoMxbd7OiV-YbT9RW5w01Ss94=.57626599-d845-4426-935d-63438bfb72a4@github.com>
References: <xJDBMcDqNzHZCxOBLHYoMxbd7OiV-YbT9RW5w01Ss94=.57626599-d845-4426-935d-63438bfb72a4@github.com>
Message-ID: <ZjwWIY4cpzIrcP-q5_WSoSMhlYJzw1H4M0b6vAz2N38=.8d2b93fa-dc14-4a9b-8ed4-1616ffa19ac3@github.com>

> This change adds a new tab to display the tenuring distribution for GC cycles.
> 
> There are 3 case scenarios:
> - Single GC cycle selected: A histogram chart is shown representing the tenuring distribution (total size across ages) for the selected cycle.
> - No GC cycle selected: An informational message is displayed to prompt the user to select a cycle.
> - Multiple GC cycles selected: An informational message is displayed indicating that only a single cycle can be viewed at a time.
> This enhancement improves visibility into object tenuring during individual GC cycles. 
> 
> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 19" src="https://github.com/user-attachments/assets/76ce69c2-60eb-48c8-be9f-6387cbfa7c42" />
> 
> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 34" src="https://github.com/user-attachments/assets/a5fc9bc9-fa72-42c9-aeb2-ecad21e4ac66" />
> 
> <img width="1174" height="599" alt="Screenshot 2025-10-15 at 16 51 57" src="https://github.com/user-attachments/assets/63ffba47-8e08-430a-9a28-11473b59e6dc" />

Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:

  Implemented review comments

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/679/files
  - new: https://git.openjdk.org/jmc/pull/679/files/fc0c4c26..18eeb4af

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=679&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=679&range=00-01

  Stats: 30 lines in 4 files changed: 14 ins; 1 del; 15 mod
  Patch: https://git.openjdk.org/jmc/pull/679.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/679/head:pull/679

PR: https://git.openjdk.org/jmc/pull/679

From aharmaz at openjdk.org  Thu Oct 23 14:58:27 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Thu, 23 Oct 2025 14:58:27 GMT
Subject: RFR: 6004: Should add tenuring summary to the GC visualization
In-Reply-To: <jE2re_PGYINdIxsbvxlPuGpIsdgw1iV9mNp4pW1Dv-I=.99625a8b-f9b3-4efd-991e-10e9f9e45edd@github.com>
References: <xJDBMcDqNzHZCxOBLHYoMxbd7OiV-YbT9RW5w01Ss94=.57626599-d845-4426-935d-63438bfb72a4@github.com>
 <jE2re_PGYINdIxsbvxlPuGpIsdgw1iV9mNp4pW1Dv-I=.99625a8b-f9b3-4efd-991e-10e9f9e45edd@github.com>
Message-ID: <34kxMkdjNn0le6cL25E7EJCEJwX-of6K1tSTBbzd2XE=.694d4737-7143-4af8-b13d-819420c030df@github.com>

On Wed, 22 Oct 2025 15:13:32 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Looks good Aymane! Do you also handle the case where the event is off, so that there aren't any tenuring distribution events available at all?

I have added in the latest commit checks on tenuring events, if not found, I display the following message for all kind of selections: 

<img width="1085" height="245" alt="NoTenuringEventMessage" src="https://github.com/user-attachments/assets/6397981f-d379-47aa-b05c-586df7fefa01" />

-------------

PR Comment: https://git.openjdk.org/jmc/pull/679#issuecomment-3437478067

From aharmaz at openjdk.org  Mon Oct 27 12:12:55 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Mon, 27 Oct 2025 12:12:55 GMT
Subject: RFR: 8451: Should make the Event Type the first column of event types
 tree table
Message-ID: <Oq4DVq2qFBXMvBSJC2JICk4zR1j_2niB92wR8nCHm30=.cc75c06a-a8cd-4037-b286-f26137fd1a7d@github.com>

This PR made sure to display the event type column as the first column in the table related to event types tree view to make it easier for the user to identify the event type of the rows he will be looking at when multiple event types are selected.

-------------

Commit messages:
 - 8451: Should make the Event Type the first column of event types tree table

Changes: https://git.openjdk.org/jmc/pull/681/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=681&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8451
  Stats: 6 lines in 2 files changed: 1 ins; 1 del; 4 mod
  Patch: https://git.openjdk.org/jmc/pull/681.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/681/head:pull/681

PR: https://git.openjdk.org/jmc/pull/681

From aharmaz at openjdk.org  Wed Oct 29 14:26:52 2025
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Wed, 29 Oct 2025 14:26:52 GMT
Subject: RFR: 8450: Improve usability of selectable action items by supporting
 keyboard and double-click interactions
Message-ID: <-Ek8pTmlYneSm3pS00SQtgVdoTe2IrnvEaXP9cWf8jE=.9fc2ebc1-aa75-4654-826d-b54bb76be3d1@github.com>

This PR adds more interaction capabilities to tree items and checkbox tables:

- Tree items: Added support for expanding/collapsing via double-click and Enter key press.
- Checkbox table: Added support for enabling/disabling via Enter key press.

-------------

Commit messages:
 - 8450: Improve usability of selectable action items by supporting keyboard and double-click interactions

Changes: https://git.openjdk.org/jmc/pull/682/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=682&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8450
  Stats: 136 lines in 6 files changed: 123 ins; 5 del; 8 mod
  Patch: https://git.openjdk.org/jmc/pull/682.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/682/head:pull/682

PR: https://git.openjdk.org/jmc/pull/682