RFR: 8365: Jolokia - Additional support for security mechanisms related to SSL / authentication, discovery restrictions [v3]

[Martin Skarsaune]

On Wed, 8 Oct 2025 16:21:42 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JMC-8365: Make secure button updating null safe
>
> application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizardPage.java line 441:
> 
>> 439: 			customUrlButton.setVisible(false);
>> 440: 		}
>> 441: 
> 
> Extra empty line

@aptmac fixed

> application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizardPage.java line 706:
> 
>> 704: 	}
>> 705: 
>> 706: 	private boolean requireSecureConnection() {
> 
> Small nit, but maybe this could be something like `isSecureConnectionRequired` ? Just thinking for initial readability where there's `requireSecureConnection(requireSecureConnection())` at line 682.

@aptmac fixed

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2426321833
PR Review Comment: https://git.openjdk.org/jmc/pull/665#discussion_r2426322266