From duke at openjdk.org  Tue Sep  2 12:00:23 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Tue, 2 Sep 2025 12:00:23 GMT
Subject: RFR: 8436: Formatting of rule descriptions with manual bullets / line
 breaks is gone on revisit
Message-ID: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>

Replaced manual bullet points and line breaks in rule descriptions with HTML entities and tags for improved rendering. the attached images show the issue


<img width="613" height="364" alt="First Visit" src="https://github.com/user-attachments/assets/34c6564b-0581-44e4-a9ba-650767ede309" />

<img width="612" height="364" alt="Second Visit" src="https://github.com/user-attachments/assets/0c6cc99f-9c4d-4d76-908f-ef2fa5e1579a" />

-------------

Commit messages:
 - 8436: Formatting of rule descriptions with manual bullets / line breaks is gone on revisit

Changes: https://git.openjdk.org/jmc/pull/669/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=669&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8436
  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/669.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/669/head:pull/669

PR: https://git.openjdk.org/jmc/pull/669

From schaturvedi at openjdk.org  Wed Sep  3 08:36:52 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Wed, 3 Sep 2025 08:36:52 GMT
Subject: RFR: 8436: Formatting of rule descriptions with manual bullets /
 line breaks is gone on revisit
In-Reply-To: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
References: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
Message-ID: <tOHMMM5GddFogbp_ewNBYB3umT4BDlT0fKbmTwhXUyw=.ebdccd93-be14-46ab-835c-a8579e1eb8f8@github.com>

On Mon, 1 Sep 2025 14:34:14 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Replaced manual bullet points and line breaks in rule descriptions with HTML entities and tags for improved rendering. the attached images show the issue
> 
> 
> <img width="613" height="364" alt="First Visit" src="https://github.com/user-attachments/assets/34c6564b-0581-44e4-a9ba-650767ede309" />
> 
> <img width="612" height="364" alt="Second Visit" src="https://github.com/user-attachments/assets/0c6cc99f-9c4d-4d76-908f-ef2fa5e1579a" />

@aymane-harmaz The change looks good. But there is only one check which is performed. Please check why other 4 checks are not executed.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/669#issuecomment-3248233017

From aptmac at openjdk.org  Wed Sep  3 13:27:48 2025
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 3 Sep 2025 13:27:48 GMT
Subject: RFR: 8436: Formatting of rule descriptions with manual bullets /
 line breaks is gone on revisit
In-Reply-To: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
References: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
Message-ID: <va_XaYVgcFpuKR_d6C9yTDmF33fqw1t_h1j6Tdn9rJY=.96d44533-4ce8-4c37-a118-33d0ecbed070@github.com>

On Mon, 1 Sep 2025 14:34:14 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Replaced manual bullet points and line breaks in rule descriptions with HTML entities and tags for improved rendering. the attached images show the issue
> 
> 
> <img width="613" height="364" alt="First Visit" src="https://github.com/user-attachments/assets/34c6564b-0581-44e4-a9ba-650767ede309" />
> 
> <img width="612" height="364" alt="Second Visit" src="https://github.com/user-attachments/assets/0c6cc99f-9c4d-4d76-908f-ef2fa5e1579a" />

You'll have to enable the workflows to run on your fork for the other checks to be performed, see: https://wiki.openjdk.org/display/SKARA/Testing#Testing-Configuringworkflowstorun

-------------

PR Comment: https://git.openjdk.org/jmc/pull/669#issuecomment-3249251018

From hirt at openjdk.org  Wed Sep  3 18:56:53 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 3 Sep 2025 18:56:53 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule [v3]
In-Reply-To: <SLhWu740a9N2vxZE6DBGuPPgP2a0l0mYR8C6GwzeOXo=.1fb66ace-2a5c-4e2a-81cf-f5c298fb489b@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
 <JAcLpUiFOVhyI70pJlnsJ4IdPnxdRwd9Bk6kEXECTQk=.5c540390-4c80-4d68-b5bf-e33aaf5fb925@github.com>
 <SLhWu740a9N2vxZE6DBGuPPgP2a0l0mYR8C6GwzeOXo=.1fb66ace-2a5c-4e2a-81cf-f5c298fb489b@github.com>
Message-ID: <oKFJNIXDDEggyzVqnDDQItRZaK_-DVo4A9csBKecpiQ=.20582343-51c7-4196-96f7-03351440104f@github.com>

On Wed, 27 Aug 2025 20:10:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Resolving merge conflict
>>  - Updated the rule as per new metric allocation stall rate
>>  - 6203: Add ZGC allocation stall rule
>
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/ZGCAllocationStallRule.java line 139:
> 
>> 137: 
>> 138: 			//Calculate time after JVM Start
>> 139: 			IQuantity timeAfterJVMStart = RulesToolkit.getEarliestStartTime(items)
> 
> Come to think of it - this will not work well for OldObjectSample events. They are a bit special and may be timestamped far earlier than the current recording period. I think we might want to add a RulesToolkit function that explicitly avoid the OldObjectSample events for this...

Suchita - I checked the jdk.OldObjectSample event after your slack message, and it turns out that there is a separate allocationTime for that event, so this isn't a problem. The timestamp on the events seem to be from the time of emission, so it should be all good.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2319898491

From hirt at openjdk.org  Wed Sep  3 19:16:50 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 3 Sep 2025 19:16:50 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artefact
In-Reply-To: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
Message-ID: <O9rrfshX0g105skR0EswEVGAMkiJnNCRNQxUtEiYkug=.25513ec8-ee22-451a-8150-9725865a2077@github.com>

On Sun, 27 Jul 2025 17:44:53 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> The Jolokia test plugin requires awaitility

I think Virag just meant the target platform, where all third party dependencies are exported over a p2.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/668#issuecomment-3250464142

From schaturvedi at openjdk.org  Thu Sep  4 07:33:27 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 4 Sep 2025 07:33:27 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule [v4]
In-Reply-To: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
Message-ID: <SCvQ08LRu-f7buJAldqcZOAfkYGwlvbvj7WeTA-LDdE=.8dc11014-dc6d-474c-a800-e8f876b6ae1e@github.com>

> This enhancement is to add new rule for ZGC Allocation Stall events.
> 
> The default configuration:
>  
> <img width="946" alt="image" src="https://github.com/user-attachments/assets/0d39ae26-fdc4-49e3-a0ed-fb7f7da8f709" />
> 
> Here are few screenshots for reference:
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/e7efe1e2-d6b3-4a05-8ea6-1bf2e8b8c15f" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/a3d3862f-96d2-4292-947f-4562c7f9f3d3" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/9616eea6-bce8-4395-a846-db343fe349f2" />
> 
> <img width="341" alt="image" src="https://github.com/user-attachments/assets/376a100e-ac05-48fe-a9c3-754923c3d79e" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/cfa7c5f1-08f0-44b4-a49d-28504439a631" />
> 
> Ignored
> 
> <img width="352" alt="image" src="https://github.com/user-attachments/assets/3c00c22e-e64d-46b0-8b64-ed653ed1fc4b" />
> 
> If we change default configuration as below:
> 
> <img width="367" alt="image" src="https://github.com/user-attachments/assets/8da64985-8446-44b8-bfb4-696a726b5255" />
> 
> <img width="350" alt="image" src="https://github.com/user-attachments/assets/ad89f02e-39b4-4df4-aae7-43cec9cc9a91" />
> 
> <img width="347" alt="image" src="https://github.com/user-attachments/assets/b3ec1081-26dd-4391-9e0f-0b4c64a7e3c1" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/106a7c3e-aaaf-495a-8c6f-281c96371e6e" />

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Implemented review comments

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/664/files
  - new: https://git.openjdk.org/jmc/pull/664/files/c1805581..4b543d9d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=664&range=03
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=664&range=02-03

  Stats: 6 lines in 3 files changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jmc/pull/664.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/664/head:pull/664

PR: https://git.openjdk.org/jmc/pull/664

From duke at openjdk.org  Thu Sep  4 07:54:48 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Thu, 4 Sep 2025 07:54:48 GMT
Subject: RFR: 8436: Formatting of rule descriptions with manual bullets /
 line breaks is gone on revisit
In-Reply-To: <tOHMMM5GddFogbp_ewNBYB3umT4BDlT0fKbmTwhXUyw=.ebdccd93-be14-46ab-835c-a8579e1eb8f8@github.com>
References: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
 <tOHMMM5GddFogbp_ewNBYB3umT4BDlT0fKbmTwhXUyw=.ebdccd93-be14-46ab-835c-a8579e1eb8f8@github.com>
Message-ID: <R3JPtQ4aoj4UD9Czo9ViTDJHUybdjuc694lXqjyFsSs=.6ea8fb44-c796-4b3b-b163-1bfbcd7ae64e@github.com>

On Wed, 3 Sep 2025 08:34:24 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> @aymane-harmaz The change looks good. But there is only one check which is performed. Please check why other 4 checks are not executed.

@Suchitainf Now only the build and test on macOS-latest fails, I think this have to do with the migration of macOS-latest label from using macos-14 into using macos-15

I have looked at previous commits in the repository that have passed this job successfully and they all have been created before the migration (4th of august)

-------------

PR Comment: https://git.openjdk.org/jmc/pull/669#issuecomment-3252366919

From schaturvedi at openjdk.org  Thu Sep  4 07:54:49 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 4 Sep 2025 07:54:49 GMT
Subject: RFR: 8436: Formatting of rule descriptions with manual bullets /
 line breaks is gone on revisit
In-Reply-To: <R3JPtQ4aoj4UD9Czo9ViTDJHUybdjuc694lXqjyFsSs=.6ea8fb44-c796-4b3b-b163-1bfbcd7ae64e@github.com>
References: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
 <tOHMMM5GddFogbp_ewNBYB3umT4BDlT0fKbmTwhXUyw=.ebdccd93-be14-46ab-835c-a8579e1eb8f8@github.com>
 <R3JPtQ4aoj4UD9Czo9ViTDJHUybdjuc694lXqjyFsSs=.6ea8fb44-c796-4b3b-b163-1bfbcd7ae64e@github.com>
Message-ID: <if0Nh82ldU-6pgU7kCs2L5TqX9K-exbk9L61NlqVchA=.124c26cd-26c1-42a6-9ca4-0daeef4918c1@github.com>

On Thu, 4 Sep 2025 07:49:48 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> > @aymane-harmaz The change looks good. But there is only one check which is performed. Please check why other 4 checks are not executed.
> 
> @Suchitainf Now only the build and test on macOS-latest fails, I think this have to do with the migration of macOS-latest label from using macos-14 into using macos-15
> 
> I have looked at previous commits in the repository that have passed this job successfully and they all have been created before the migration (4th of august)

@aymane-harmaz Yes, this failure is not related to your change. I have updated my ZGC PR and its failing for me also.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/669#issuecomment-3252375412

From duke at openjdk.org  Thu Sep  4 15:22:36 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Thu, 4 Sep 2025 15:22:36 GMT
Subject: RFR: 8437: JDP Tests are failing on macOS-15 Github Actions runner due
 to local network privacy restrictions
Message-ID: <dVjDC56XDB8MFyKW_PpGIq8OPl5AVHbdm2dJGDonAXA=.a713faf9-84ea-42eb-8c9f-bd69a4be467c@github.com>

Skipped the execution of JDP tests requiring multicast which is not supported on macOS-15 runner

This was the result of moving macOS-latest from 14 to 15

Similar issues are mentioned in the following links : 
https://github.com/orgs/community/discussions/170669
https://github.com/actions/runner-images/issues/10924

-------------

Commit messages:
 - 8437: JDP Tests are failing on macOS-15 Github Actions runner due to local network privacy restrictions

Changes: https://git.openjdk.org/jmc/pull/672/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=672&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8437
  Stats: 20 lines in 1 file changed: 20 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/672.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/672/head:pull/672

PR: https://git.openjdk.org/jmc/pull/672

From schaturvedi at openjdk.org  Thu Sep  4 17:48:48 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 4 Sep 2025 17:48:48 GMT
Subject: RFR: 8437: JDP Tests are failing on macOS-15 Github Actions runner
 due to local network privacy restrictions
In-Reply-To: <dVjDC56XDB8MFyKW_PpGIq8OPl5AVHbdm2dJGDonAXA=.a713faf9-84ea-42eb-8c9f-bd69a4be467c@github.com>
References: <dVjDC56XDB8MFyKW_PpGIq8OPl5AVHbdm2dJGDonAXA=.a713faf9-84ea-42eb-8c9f-bd69a4be467c@github.com>
Message-ID: <-OwcoOhPMRBdSFTWqkcJGoxFkW0MDHihurbQ-y4OZFo=.b78cb3ea-5ff4-412b-8184-e037547c068d@github.com>

On Thu, 4 Sep 2025 15:16:46 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Skipped the execution of JDP tests requiring multicast which is not supported on macOS-15 runner
> 
> This was the result of moving macOS-latest from 14 to 15
> 
> Similar issues are mentioned in the following links : 
> https://github.com/orgs/community/discussions/170669
> https://github.com/actions/runner-images/issues/10924

Looks good to me.

-------------

Marked as reviewed by schaturvedi (Committer).

PR Review: https://git.openjdk.org/jmc/pull/672#pullrequestreview-3186424358

From hirt at openjdk.org  Thu Sep  4 20:40:49 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 4 Sep 2025 20:40:49 GMT
Subject: RFR: 8437: JDP Tests are failing on macOS-15 Github Actions runner
 due to local network privacy restrictions
In-Reply-To: <dVjDC56XDB8MFyKW_PpGIq8OPl5AVHbdm2dJGDonAXA=.a713faf9-84ea-42eb-8c9f-bd69a4be467c@github.com>
References: <dVjDC56XDB8MFyKW_PpGIq8OPl5AVHbdm2dJGDonAXA=.a713faf9-84ea-42eb-8c9f-bd69a4be467c@github.com>
Message-ID: <-TUfvBFiO0ChKV3u6Sc25lCID7meP_1Vt0zlKLS1Wcc=.e96a603a-56e0-49d2-959d-c459ba812fac@github.com>

On Thu, 4 Sep 2025 15:16:46 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Skipped the execution of JDP tests requiring multicast which is not supported on macOS-15 runner
> 
> This was the result of moving macOS-latest from 14 to 15
> 
> Similar issues are mentioned in the following links : 
> https://github.com/orgs/community/discussions/170669
> https://github.com/actions/runner-images/issues/10924

Marked as reviewed by hirt (Lead).

Hi @aymane-harmaz! Looks good for now. Let?s watch that thread to see if Apple comes up with a solution that lets us run these tests. Please /integrate.

-------------

PR Review: https://git.openjdk.org/jmc/pull/672#pullrequestreview-3187176032
PR Comment: https://git.openjdk.org/jmc/pull/672#issuecomment-3255565286

From hirt at openjdk.org  Thu Sep  4 20:42:53 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 4 Sep 2025 20:42:53 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule [v4]
In-Reply-To: <SCvQ08LRu-f7buJAldqcZOAfkYGwlvbvj7WeTA-LDdE=.8dc11014-dc6d-474c-a800-e8f876b6ae1e@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
 <SCvQ08LRu-f7buJAldqcZOAfkYGwlvbvj7WeTA-LDdE=.8dc11014-dc6d-474c-a800-e8f876b6ae1e@github.com>
Message-ID: <zCo8xwaEDn88S2lBDhPeFu1jX4RvdHvha-2d3pYXO_M=.b8349473-a038-4d71-9448-9639b66a1515@github.com>

On Thu, 4 Sep 2025 07:33:27 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This enhancement is to add new rule for ZGC Allocation Stall events.
>> 
>> The default configuration:
>>  
>> <img width="946" alt="image" src="https://github.com/user-attachments/assets/0d39ae26-fdc4-49e3-a0ed-fb7f7da8f709" />
>> 
>> Here are few screenshots for reference:
>> 
>> <img width="344" alt="image" src="https://github.com/user-attachments/assets/e7efe1e2-d6b3-4a05-8ea6-1bf2e8b8c15f" />
>> 
>> <img width="353" alt="image" src="https://github.com/user-attachments/assets/a3d3862f-96d2-4292-947f-4562c7f9f3d3" />
>> 
>> <img width="344" alt="image" src="https://github.com/user-attachments/assets/9616eea6-bce8-4395-a846-db343fe349f2" />
>> 
>> <img width="341" alt="image" src="https://github.com/user-attachments/assets/376a100e-ac05-48fe-a9c3-754923c3d79e" />
>> 
>> <img width="353" alt="image" src="https://github.com/user-attachments/assets/cfa7c5f1-08f0-44b4-a49d-28504439a631" />
>> 
>> Ignored
>> 
>> <img width="352" alt="image" src="https://github.com/user-attachments/assets/3c00c22e-e64d-46b0-8b64-ed653ed1fc4b" />
>> 
>> If we change default configuration as below:
>> 
>> <img width="367" alt="image" src="https://github.com/user-attachments/assets/8da64985-8446-44b8-bfb4-696a726b5255" />
>> 
>> <img width="350" alt="image" src="https://github.com/user-attachments/assets/ad89f02e-39b4-4df4-aae7-43cec9cc9a91" />
>> 
>> <img width="347" alt="image" src="https://github.com/user-attachments/assets/b3ec1081-26dd-4391-9e0f-0b4c64a7e3c1" />
>> 
>> <img width="344" alt="image" src="https://github.com/user-attachments/assets/106a7c3e-aaaf-495a-8c6f-281c96371e6e" />
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments

The Mac JDP problem is unrelated, and is being fixed in #672.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/664#issuecomment-3255569926

From hirt at openjdk.org  Thu Sep  4 21:45:04 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 4 Sep 2025 21:45:04 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule [v4]
In-Reply-To: <SCvQ08LRu-f7buJAldqcZOAfkYGwlvbvj7WeTA-LDdE=.8dc11014-dc6d-474c-a800-e8f876b6ae1e@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
 <SCvQ08LRu-f7buJAldqcZOAfkYGwlvbvj7WeTA-LDdE=.8dc11014-dc6d-474c-a800-e8f876b6ae1e@github.com>
Message-ID: <WVB-1VfjptRY7VWsNHOvfElfK8UMOKCedHjFS9Q57PA=.73d6da31-5fb7-4bb0-b9c0-afa920db8517@github.com>

On Thu, 4 Sep 2025 07:33:27 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This enhancement is to add new rule for ZGC Allocation Stall events.
>> 
>> The default configuration:
>>  
>> <img width="946" alt="image" src="https://github.com/user-attachments/assets/0d39ae26-fdc4-49e3-a0ed-fb7f7da8f709" />
>> 
>> Here are few screenshots for reference:
>> 
>> <img width="344" alt="image" src="https://github.com/user-attachments/assets/e7efe1e2-d6b3-4a05-8ea6-1bf2e8b8c15f" />
>> 
>> <img width="353" alt="image" src="https://github.com/user-attachments/assets/a3d3862f-96d2-4292-947f-4562c7f9f3d3" />
>> 
>> <img width="344" alt="image" src="https://github.com/user-attachments/assets/9616eea6-bce8-4395-a846-db343fe349f2" />
>> 
>> <img width="341" alt="image" src="https://github.com/user-attachments/assets/376a100e-ac05-48fe-a9c3-754923c3d79e" />
>> 
>> <img width="353" alt="image" src="https://github.com/user-attachments/assets/cfa7c5f1-08f0-44b4-a49d-28504439a631" />
>> 
>> Ignored
>> 
>> <img width="352" alt="image" src="https://github.com/user-attachments/assets/3c00c22e-e64d-46b0-8b64-ed653ed1fc4b" />
>> 
>> If we change default configuration as below:
>> 
>> <img width="367" alt="image" src="https://github.com/user-attachments/assets/8da64985-8446-44b8-bfb4-696a726b5255" />
>> 
>> <img width="350" alt="image" src="https://github.com/user-attachments/assets/ad89f02e-39b4-4df4-aae7-43cec9cc9a91" />
>> 
>> <img width="347" alt="image" src="https://github.com/user-attachments/assets/b3ec1081-26dd-4391-9e0f-0b4c64a7e3c1" />
>> 
>> <img width="344" alt="image" src="https://github.com/user-attachments/assets/106a7c3e-aaaf-495a-8c6f-281c96371e6e" />
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments

Changes requested by hirt (Lead).

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/ZGCAllocationStallRule.java line 76:

> 74: 			JdkAggregators.ZGC_ALLOCATION_STALL_COUNT, UnitLookup.NUMBER, IQuantity.class);
> 75: 
> 76: 	public static final TypedResult<IQuantity> ZGC_ALLOCATION_STALL_LONGEST_DURATION = new TypedResult<>(

These are durations, so shouldn?t they use UnitLookup.MILLISECOND?

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/Messages.java line 322:

> 320: 	public static final String GcFreedRatioRule_RESULT_SHORT_DESCRIPTION = "GcFreedRatioRule_RESULT_SHORT_DESCRIPTION"; //$NON-NLS-1$
> 321: 	public static final String GarbageCollectionInfo_RULE_NAME = "GarbageCollectionInfo_RULE_NAME"; //$NON-NLS-1$
> 322: 	public static final String ZGCAllocationStall_RULE_NAME = "ZGCAllocationStall_RULE_NAME"; //$NON-NLS-1$

Consistent capitalization - you use Zgc elsewhere.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 763:

> 761: ZGCAllocationStallRule_CONFIG_WARN_LIMIT_LONG=The ZGC allocation stall time per minute needed to trigger a warning
> 762: ZGCAllocationStallRule_RATE=Allocation Stall time per minute
> 763: ZGCAllocationStallRule_RATE_LONG=The rate of ZGC Allocation Stall duration based on the time from when JVM was started

This is really not from when the JVM was started, but rather the average rate over the recording duration.

Perhaps something like:
?Average ZGC allocation stalls per minute over the recording period?

-------------

PR Review: https://git.openjdk.org/jmc/pull/664#pullrequestreview-3187220738
PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2323542383
PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2323533949
PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2323528202

From hirt at openjdk.org  Thu Sep  4 23:11:58 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 4 Sep 2025 23:11:58 GMT
Subject: RFR: 8437: JDP Tests are failing on macOS-15 Github Actions runner
 due to local network privacy restrictions
In-Reply-To: <dVjDC56XDB8MFyKW_PpGIq8OPl5AVHbdm2dJGDonAXA=.a713faf9-84ea-42eb-8c9f-bd69a4be467c@github.com>
References: <dVjDC56XDB8MFyKW_PpGIq8OPl5AVHbdm2dJGDonAXA=.a713faf9-84ea-42eb-8c9f-bd69a4be467c@github.com>
Message-ID: <byYIUREwg1msMeFST6y1hbLo7kLKstq3CkjoRzlslSY=.a3875402-b8a5-4bff-bb9a-0e0b65ff478e@github.com>

On Thu, 4 Sep 2025 15:16:46 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Skipped the execution of JDP tests requiring multicast which is not supported on macOS-15 runner
> 
> This was the result of moving macOS-latest from 14 to 15
> 
> Similar issues are mentioned in the following links : 
> https://github.com/orgs/community/discussions/170669
> https://github.com/actions/runner-images/issues/10924

Here's the ongoing discussion:
https://developer.apple.com/forums/thread/770473

-------------

PR Comment: https://git.openjdk.org/jmc/pull/672#issuecomment-3256155650

From duke at openjdk.org  Fri Sep  5 01:16:20 2025
From: duke at openjdk.org (Huang Xiao)
Date: Fri, 5 Sep 2025 01:16:20 GMT
Subject: RFR: 8406: Chinese Rule strings are out of date
In-Reply-To: <rp8J-l0H56cBq2pvvzMceVdg5rx8Ebqw433yACUgCxs=.ccddeb9a-30c9-4bf2-9ba8-a0da156b90b9@github.com>
References: <tWbPjLEUEI7aQGL1iRQRsR2dgIlsziw8kW_4etEMUI4=.29806163-ce7f-4148-a311-fbf23bb29bfe@github.com>
 <6ScvFiQ7HRsIKkP2UvJZ4HwvzWDhQ3cWL8KCA_BS9sk=.ac2a4a50-ddc3-409d-b6ce-1f616e5665f1@github.com>
 <6dejvCr84JVe2s5bWYLKko0eBOuLI5k0lGN7dZTEfzU=.09f95282-f79d-427f-aa66-f2562e4a2ab7@github.com>
 <rp8J-l0H56cBq2pvvzMceVdg5rx8Ebqw433yACUgCxs=.ccddeb9a-30c9-4bf2-9ba8-a0da156b90b9@github.com>
Message-ID: <YO0xLC_bAcin73ELRWCfI2682KqfaTR8E2v9L7s9jig=.8a73eed7-55af-4ffb-b289-a6027283648f@github.com>

On Tue, 26 Aug 2025 13:04:06 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Hi @aptmac , just checking in to see if there's anything else needed for this PR. Thanks!
>
> @youngledo Great, looks like it's all working now. The bot added the instructions here: https://github.com/openjdk/jmc/pull/662#issuecomment-3047096405
> 
> You'll have to type `/integrate` and then the PR should be ready for sponsoring afterwards.

@aptmac Hi, I discovered that there are other documents that urgently need translation, and I suggest that JMC introduce some AI tools to handle these tasks.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/662#issuecomment-3256704336

From duke at openjdk.org  Fri Sep  5 08:22:21 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Fri, 5 Sep 2025 08:22:21 GMT
Subject: RFR: 8437: JDP Tests are failing on macOS-15 Github Actions runner
 due to local network privacy restrictions
In-Reply-To: <dVjDC56XDB8MFyKW_PpGIq8OPl5AVHbdm2dJGDonAXA=.a713faf9-84ea-42eb-8c9f-bd69a4be467c@github.com>
References: <dVjDC56XDB8MFyKW_PpGIq8OPl5AVHbdm2dJGDonAXA=.a713faf9-84ea-42eb-8c9f-bd69a4be467c@github.com>
Message-ID: <vBaK8FLN20FP07ZnXM_5_pTfTY1KhiYcr-9zkuLz-64=.730abbae-afe5-439d-bd06-2df77640034a@github.com>

On Thu, 4 Sep 2025 15:16:46 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Skipped the execution of JDP tests requiring multicast which is not supported on macOS-15 runner
> 
> This was the result of moving macOS-latest from 14 to 15
> 
> Similar issues are mentioned in the following links : 
> https://github.com/orgs/community/discussions/170669
> https://github.com/actions/runner-images/issues/10924

Thanks for the reviews

-------------

PR Comment: https://git.openjdk.org/jmc/pull/672#issuecomment-3257488322

From duke at openjdk.org  Fri Sep  5 08:22:22 2025
From: duke at openjdk.org (duke)
Date: Fri, 5 Sep 2025 08:22:22 GMT
Subject: RFR: 8437: JDP Tests are failing on macOS-15 Github Actions runner
 due to local network privacy restrictions
In-Reply-To: <dVjDC56XDB8MFyKW_PpGIq8OPl5AVHbdm2dJGDonAXA=.a713faf9-84ea-42eb-8c9f-bd69a4be467c@github.com>
References: <dVjDC56XDB8MFyKW_PpGIq8OPl5AVHbdm2dJGDonAXA=.a713faf9-84ea-42eb-8c9f-bd69a4be467c@github.com>
Message-ID: <DaPzu4clYQ-i9rhbY92bM_MzqrEbU3_hLTRa5n5Wagk=.24b56239-08fe-41a4-8aac-b8f31ab1f750@github.com>

On Thu, 4 Sep 2025 15:16:46 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Skipped the execution of JDP tests requiring multicast which is not supported on macOS-15 runner
> 
> This was the result of moving macOS-latest from 14 to 15
> 
> Similar issues are mentioned in the following links : 
> https://github.com/orgs/community/discussions/170669
> https://github.com/actions/runner-images/issues/10924

@aymane-harmaz 
Your change (at version 1cce2a742f10b59c10c7d9c54f34129b284c07e8) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/672#issuecomment-3257489544

From schaturvedi at openjdk.org  Fri Sep  5 08:29:36 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Fri, 5 Sep 2025 08:29:36 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule [v5]
In-Reply-To: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
Message-ID: <9Wv2D5ls7WYKOkAYOtignug5EJYKtQcmv_4e3QBJ9Z0=.23c7861d-7c84-41e5-9f21-5d511908e855@github.com>

> This enhancement is to add new rule for ZGC Allocation Stall events.
> 
> The default configuration:
>  
> <img width="946" alt="image" src="https://github.com/user-attachments/assets/0d39ae26-fdc4-49e3-a0ed-fb7f7da8f709" />
> 
> Here are few screenshots for reference:
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/e7efe1e2-d6b3-4a05-8ea6-1bf2e8b8c15f" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/a3d3862f-96d2-4292-947f-4562c7f9f3d3" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/9616eea6-bce8-4395-a846-db343fe349f2" />
> 
> <img width="341" alt="image" src="https://github.com/user-attachments/assets/376a100e-ac05-48fe-a9c3-754923c3d79e" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/cfa7c5f1-08f0-44b4-a49d-28504439a631" />
> 
> Ignored
> 
> <img width="352" alt="image" src="https://github.com/user-attachments/assets/3c00c22e-e64d-46b0-8b64-ed653ed1fc4b" />
> 
> If we change default configuration as below:
> 
> <img width="367" alt="image" src="https://github.com/user-attachments/assets/8da64985-8446-44b8-bfb4-696a726b5255" />
> 
> <img width="350" alt="image" src="https://github.com/user-attachments/assets/ad89f02e-39b4-4df4-aae7-43cec9cc9a91" />
> 
> <img width="347" alt="image" src="https://github.com/user-attachments/assets/b3ec1081-26dd-4391-9e0f-0b4c64a7e3c1" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/106a7c3e-aaaf-495a-8c6f-281c96371e6e" />

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Implemented review comments

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/664/files
  - new: https://git.openjdk.org/jmc/pull/664/files/4b543d9d..1828c457

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=664&range=04
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=664&range=03-04

  Stats: 13 lines in 3 files changed: 0 ins; 0 del; 13 mod
  Patch: https://git.openjdk.org/jmc/pull/664.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/664/head:pull/664

PR: https://git.openjdk.org/jmc/pull/664

From duke at openjdk.org  Fri Sep  5 08:31:22 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Fri, 5 Sep 2025 08:31:22 GMT
Subject: Integrated: 8437: JDP Tests are failing on macOS-15 Github Actions
 runner due to local network privacy restrictions
In-Reply-To: <dVjDC56XDB8MFyKW_PpGIq8OPl5AVHbdm2dJGDonAXA=.a713faf9-84ea-42eb-8c9f-bd69a4be467c@github.com>
References: <dVjDC56XDB8MFyKW_PpGIq8OPl5AVHbdm2dJGDonAXA=.a713faf9-84ea-42eb-8c9f-bd69a4be467c@github.com>
Message-ID: <2RvEwxqvFgzoSTyG0WAlBL-otQnHEa0bC1EvSK703f4=.fa6d920c-f969-4295-8f9e-d1508685b99c@github.com>

On Thu, 4 Sep 2025 15:16:46 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Skipped the execution of JDP tests requiring multicast which is not supported on macOS-15 runner
> 
> This was the result of moving macOS-latest from 14 to 15
> 
> Similar issues are mentioned in the following links : 
> https://github.com/orgs/community/discussions/170669
> https://github.com/actions/runner-images/issues/10924

This pull request has now been integrated.

Changeset: 29a406f6
Author:    Aymane Harmaz <aymane.harmaz at oracle.com>
Committer: Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/29a406f649fa30a9e81daadc26798fdb96dbaac1
Stats:     20 lines in 1 file changed: 20 ins; 0 del; 0 mod

8437: JDP Tests are failing on macOS-15 Github Actions runner due to local network privacy restrictions

Reviewed-by: schaturvedi, hirt

-------------

PR: https://git.openjdk.org/jmc/pull/672

From schaturvedi at openjdk.org  Fri Sep  5 08:36:19 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Fri, 5 Sep 2025 08:36:19 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule [v4]
In-Reply-To: <WVB-1VfjptRY7VWsNHOvfElfK8UMOKCedHjFS9Q57PA=.73d6da31-5fb7-4bb0-b9c0-afa920db8517@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
 <SCvQ08LRu-f7buJAldqcZOAfkYGwlvbvj7WeTA-LDdE=.8dc11014-dc6d-474c-a800-e8f876b6ae1e@github.com>
 <WVB-1VfjptRY7VWsNHOvfElfK8UMOKCedHjFS9Q57PA=.73d6da31-5fb7-4bb0-b9c0-afa920db8517@github.com>
Message-ID: <i1iYs7OVXFHDmCETYGK_OfoqXG3TAYJl03WGImXVaHE=.69b0d3c6-c4f1-4f6d-b998-5569bde7f2ff@github.com>

On Thu, 4 Sep 2025 21:02:14 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implemented review comments
>
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/ZGCAllocationStallRule.java line 76:
> 
>> 74: 			JdkAggregators.ZGC_ALLOCATION_STALL_COUNT, UnitLookup.NUMBER, IQuantity.class);
>> 75: 
>> 76: 	public static final TypedResult<IQuantity> ZGC_ALLOCATION_STALL_LONGEST_DURATION = new TypedResult<>(
> 
> These are durations, so shouldn?t they use UnitLookup.MILLISECOND?

I have checked at other places. For Duration we have used UnitLookup.TIMESPAN. So I have used the same here.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2324463128

From hirt at openjdk.org  Fri Sep  5 19:36:23 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 5 Sep 2025 19:36:23 GMT
Subject: RFR: 6203: Add ZGC allocation stall rule [v5]
In-Reply-To: <9Wv2D5ls7WYKOkAYOtignug5EJYKtQcmv_4e3QBJ9Z0=.23c7861d-7c84-41e5-9f21-5d511908e855@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
 <9Wv2D5ls7WYKOkAYOtignug5EJYKtQcmv_4e3QBJ9Z0=.23c7861d-7c84-41e5-9f21-5d511908e855@github.com>
Message-ID: <lpz8DMmJduHB1kUyA09zhfCVBsMw5hyvP5kWups--zM=.fb352039-2cb9-4764-aca9-10c394e292f3@github.com>

On Fri, 5 Sep 2025 08:29:36 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This enhancement is to add new rule for ZGC Allocation Stall events.
>> 
>> The default configuration:
>>  
>> <img width="946" alt="image" src="https://github.com/user-attachments/assets/0d39ae26-fdc4-49e3-a0ed-fb7f7da8f709" />
>> 
>> Here are few screenshots for reference:
>> 
>> <img width="344" alt="image" src="https://github.com/user-attachments/assets/e7efe1e2-d6b3-4a05-8ea6-1bf2e8b8c15f" />
>> 
>> <img width="353" alt="image" src="https://github.com/user-attachments/assets/a3d3862f-96d2-4292-947f-4562c7f9f3d3" />
>> 
>> <img width="344" alt="image" src="https://github.com/user-attachments/assets/9616eea6-bce8-4395-a846-db343fe349f2" />
>> 
>> <img width="341" alt="image" src="https://github.com/user-attachments/assets/376a100e-ac05-48fe-a9c3-754923c3d79e" />
>> 
>> <img width="353" alt="image" src="https://github.com/user-attachments/assets/cfa7c5f1-08f0-44b4-a49d-28504439a631" />
>> 
>> Ignored
>> 
>> <img width="352" alt="image" src="https://github.com/user-attachments/assets/3c00c22e-e64d-46b0-8b64-ed653ed1fc4b" />
>> 
>> If we change default configuration as below:
>> 
>> <img width="367" alt="image" src="https://github.com/user-attachments/assets/8da64985-8446-44b8-bfb4-696a726b5255" />
>> 
>> <img width="350" alt="image" src="https://github.com/user-attachments/assets/ad89f02e-39b4-4df4-aae7-43cec9cc9a91" />
>> 
>> <img width="347" alt="image" src="https://github.com/user-attachments/assets/b3ec1081-26dd-4391-9e0f-0b4c64a7e3c1" />
>> 
>> <img width="344" alt="image" src="https://github.com/user-attachments/assets/106a7c3e-aaaf-495a-8c6f-281c96371e6e" />
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/664#pullrequestreview-3190564429

From hirt at openjdk.org  Fri Sep  5 19:58:18 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 5 Sep 2025 19:58:18 GMT
Subject: RFR: 8436: Formatting of rule descriptions with manual bullets /
 line breaks is gone on revisit
In-Reply-To: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
References: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
Message-ID: <UXurJs16rTfaCLu9MEF-a5VBaVwh9q9FDvoUS7JyN6s=.409900a3-f0be-4802-8a94-8560e411f22d@github.com>

On Mon, 1 Sep 2025 14:34:14 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Replaced manual bullet points and line breaks in rule descriptions with HTML entities and tags for improved rendering. the attached images show the issue
> 
> 
> <img width="613" height="364" alt="First Visit" src="https://github.com/user-attachments/assets/34c6564b-0581-44e4-a9ba-650767ede309" />
> 
> <img width="612" height="364" alt="Second Visit" src="https://github.com/user-attachments/assets/0c6cc99f-9c4d-4d76-908f-ef2fa5e1579a" />

Changes requested by hirt (Lead).

core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/html/internal/RulesHtmlToolkit.java line 255:

> 253: 		description += (solution != null) ? "<div class=\"longDescription\">" + solution + "</div>" : ""; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
> 254: 		Matcher matcher = LINK_PATTERN.matcher(description);
> 255: 		description = description.replace("\n", "</br>") //$NON-NLS-1$//$NON-NLS-2$

Should this be &lt;br/&gt;?

-------------

PR Review: https://git.openjdk.org/jmc/pull/669#pullrequestreview-3190613702
PR Review Comment: https://git.openjdk.org/jmc/pull/669#discussion_r2325926916

From schaturvedi at openjdk.org  Sat Sep  6 18:16:16 2025
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sat, 6 Sep 2025 18:16:16 GMT
Subject: Integrated: 6203: Add ZGC allocation stall rule
In-Reply-To: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
References: <PolIfz0mPOkAfQU7Sm-OY_9soKjKR6k-FoWm-aLGrU8=.b8979879-3f08-49c8-a47b-b68f274f9044@github.com>
Message-ID: <rp2_LfG4FF8vFJK7nm-_L3J76ziRQ9ccF9i9Iv_m5qo=.c27551b3-9eb4-435b-8d51-370fa21b55a2@github.com>

On Wed, 9 Jul 2025 14:17:10 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This enhancement is to add new rule for ZGC Allocation Stall events.
> 
> The default configuration:
>  
> <img width="946" alt="image" src="https://github.com/user-attachments/assets/0d39ae26-fdc4-49e3-a0ed-fb7f7da8f709" />
> 
> Here are few screenshots for reference:
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/e7efe1e2-d6b3-4a05-8ea6-1bf2e8b8c15f" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/a3d3862f-96d2-4292-947f-4562c7f9f3d3" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/9616eea6-bce8-4395-a846-db343fe349f2" />
> 
> <img width="341" alt="image" src="https://github.com/user-attachments/assets/376a100e-ac05-48fe-a9c3-754923c3d79e" />
> 
> <img width="353" alt="image" src="https://github.com/user-attachments/assets/cfa7c5f1-08f0-44b4-a49d-28504439a631" />
> 
> Ignored
> 
> <img width="352" alt="image" src="https://github.com/user-attachments/assets/3c00c22e-e64d-46b0-8b64-ed653ed1fc4b" />
> 
> If we change default configuration as below:
> 
> <img width="367" alt="image" src="https://github.com/user-attachments/assets/8da64985-8446-44b8-bfb4-696a726b5255" />
> 
> <img width="350" alt="image" src="https://github.com/user-attachments/assets/ad89f02e-39b4-4df4-aae7-43cec9cc9a91" />
> 
> <img width="347" alt="image" src="https://github.com/user-attachments/assets/b3ec1081-26dd-4391-9e0f-0b4c64a7e3c1" />
> 
> <img width="344" alt="image" src="https://github.com/user-attachments/assets/106a7c3e-aaaf-495a-8c6f-281c96371e6e" />

This pull request has now been integrated.

Changeset: 5c0e604a
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/5c0e604a4f11c2fb8523f20d4d83d3c2f60aa02b
Stats:     326 lines in 11 files changed: 322 ins; 0 del; 4 mod

6203: Add ZGC allocation stall rule

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/664

From duke at openjdk.org  Mon Sep  8 08:51:51 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Mon, 8 Sep 2025 08:51:51 GMT
Subject: RFR: 8436: Formatting of rule descriptions with manual bullets /
 line breaks is gone on revisit [v2]
In-Reply-To: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
References: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
Message-ID: <OXJtVf5agCFqT-qtas4vsnDK-I9Qe6wJDFetTMCjgag=.4b09da0f-d741-48cf-9b7e-1b427e5c9b2c@github.com>

> Replaced manual bullet points and line breaks in rule descriptions with HTML entities and tags for improved rendering. the attached images show the issue
> 
> 
> <img width="613" height="364" alt="First Visit" src="https://github.com/user-attachments/assets/34c6564b-0581-44e4-a9ba-650767ede309" />
> 
> <img width="612" height="364" alt="Second Visit" src="https://github.com/user-attachments/assets/0c6cc99f-9c4d-4d76-908f-ef2fa5e1579a" />

Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:

  Fix line break tag syntax

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/669/files
  - new: https://git.openjdk.org/jmc/pull/669/files/a84f0cf0..f6ae0d48

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=669&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=669&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/669.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/669/head:pull/669

PR: https://git.openjdk.org/jmc/pull/669

From duke at openjdk.org  Mon Sep  8 12:22:17 2025
From: duke at openjdk.org (Martin Skarsaune)
Date: Mon, 8 Sep 2025 12:22:17 GMT
Subject: RFR: 8425: Problem importing in Eclipse due to missing awatility
 3rd party artefact
In-Reply-To: <O9rrfshX0g105skR0EswEVGAMkiJnNCRNQxUtEiYkug=.25513ec8-ee22-451a-8150-9725865a2077@github.com>
References: <e7dRkHFXkQlphupxWFTJej_p9f6w2LSyZiNyBM2eVdE=.f1f6b1b0-9d7f-4f56-9e95-f371e19daf1a@github.com>
 <O9rrfshX0g105skR0EswEVGAMkiJnNCRNQxUtEiYkug=.25513ec8-ee22-451a-8150-9725865a2077@github.com>
Message-ID: <KRoJKVuAJ17lULGyyOxUzmJbRlzSgV_Wlveejuc-eNY=.afca9906-e7b1-4ec5-acd1-9ba0c771411d@github.com>

On Wed, 3 Sep 2025 19:14:31 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> I think Virag just meant the target platform, where all third party dependencies are exported over a p2.

Ok, I can try to include it

-------------

PR Comment: https://git.openjdk.org/jmc/pull/668#issuecomment-3266031196

From duke at openjdk.org  Mon Sep  8 15:14:56 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Mon, 8 Sep 2025 15:14:56 GMT
Subject: RFR: 8438: Update the version of JMC to 10.0.0
Message-ID: <6yCaQSeZmOuGUHGyxFbNXLlXoBP3nyp0-UGZSzdNpH8=.3a4e4789-9382-4e8e-96f6-966695b7b106@github.com>

Updated some versions in codebase that were referring to 9.1.0 toward 10.0.0

-------------

Commit messages:
 - 8438: Update the version of JMC to 10.0.0

Changes: https://git.openjdk.org/jmc/pull/673/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=673&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8438
  Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jmc/pull/673.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/673/head:pull/673

PR: https://git.openjdk.org/jmc/pull/673

From hirt at openjdk.org  Wed Sep 10 17:16:56 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 10 Sep 2025 17:16:56 GMT
Subject: RFR: 8438: Update the version of JMC to 10.0.0
In-Reply-To: <6yCaQSeZmOuGUHGyxFbNXLlXoBP3nyp0-UGZSzdNpH8=.3a4e4789-9382-4e8e-96f6-966695b7b106@github.com>
References: <6yCaQSeZmOuGUHGyxFbNXLlXoBP3nyp0-UGZSzdNpH8=.3a4e4789-9382-4e8e-96f6-966695b7b106@github.com>
Message-ID: <e5mYzSqRq2K9pHDLthGgjeReH4WZHVmskfHW1NCVchk=.be7c914b-6f4d-424a-bee2-2c0b38855c91@github.com>

On Mon, 8 Sep 2025 15:08:42 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Updated some versions in codebase that were referring to 9.1.0 toward 10.0.0

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/673#pullrequestreview-3207093322

From hirt at openjdk.org  Wed Sep 10 17:19:18 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 10 Sep 2025 17:19:18 GMT
Subject: RFR: 8436: Formatting of rule descriptions with manual bullets /
 line breaks is gone on revisit [v2]
In-Reply-To: <OXJtVf5agCFqT-qtas4vsnDK-I9Qe6wJDFetTMCjgag=.4b09da0f-d741-48cf-9b7e-1b427e5c9b2c@github.com>
References: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
 <OXJtVf5agCFqT-qtas4vsnDK-I9Qe6wJDFetTMCjgag=.4b09da0f-d741-48cf-9b7e-1b427e5c9b2c@github.com>
Message-ID: <yOaInjdOaH_NoPzSAnpgRbhZZCRgzOHTQMRWXC14JYo=.1eb7c0ab-4884-4dc7-b858-f11faf74b0c8@github.com>

On Mon, 8 Sep 2025 08:51:51 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

>> Replaced manual bullet points and line breaks in rule descriptions with HTML entities and tags for improved rendering. the attached images show the issue
>> 
>> 
>> <img width="613" height="364" alt="First Visit" src="https://github.com/user-attachments/assets/34c6564b-0581-44e4-a9ba-650767ede309" />
>> 
>> <img width="612" height="364" alt="Second Visit" src="https://github.com/user-attachments/assets/0c6cc99f-9c4d-4d76-908f-ef2fa5e1579a" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix line break tag syntax

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/669#pullrequestreview-3207104762

From duke at openjdk.org  Thu Sep 11 08:36:40 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Thu, 11 Sep 2025 08:36:40 GMT
Subject: RFR: 8436: Formatting of rule descriptions with manual bullets /
 line breaks is gone on revisit [v2]
In-Reply-To: <OXJtVf5agCFqT-qtas4vsnDK-I9Qe6wJDFetTMCjgag=.4b09da0f-d741-48cf-9b7e-1b427e5c9b2c@github.com>
References: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
 <OXJtVf5agCFqT-qtas4vsnDK-I9Qe6wJDFetTMCjgag=.4b09da0f-d741-48cf-9b7e-1b427e5c9b2c@github.com>
Message-ID: <Gux0dOumGFjKCUH7JAW0F8JbO86EtRw4Z-1_mweM-RA=.92f269fa-06dc-4666-aeff-d414dcded4b5@github.com>

On Mon, 8 Sep 2025 08:51:51 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

>> Replaced manual bullet points and line breaks in rule descriptions with HTML entities and tags for improved rendering. the attached images show the issue
>> 
>> 
>> <img width="613" height="364" alt="First Visit" src="https://github.com/user-attachments/assets/34c6564b-0581-44e4-a9ba-650767ede309" />
>> 
>> <img width="612" height="364" alt="Second Visit" src="https://github.com/user-attachments/assets/0c6cc99f-9c4d-4d76-908f-ef2fa5e1579a" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix line break tag syntax

Thanks for the review

-------------

PR Comment: https://git.openjdk.org/jmc/pull/669#issuecomment-3279180742

From duke at openjdk.org  Thu Sep 11 08:36:41 2025
From: duke at openjdk.org (duke)
Date: Thu, 11 Sep 2025 08:36:41 GMT
Subject: RFR: 8436: Formatting of rule descriptions with manual bullets /
 line breaks is gone on revisit [v2]
In-Reply-To: <OXJtVf5agCFqT-qtas4vsnDK-I9Qe6wJDFetTMCjgag=.4b09da0f-d741-48cf-9b7e-1b427e5c9b2c@github.com>
References: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
 <OXJtVf5agCFqT-qtas4vsnDK-I9Qe6wJDFetTMCjgag=.4b09da0f-d741-48cf-9b7e-1b427e5c9b2c@github.com>
Message-ID: <6THFKp4BgZFW8XbFh1MwH_23H_FujzoyyY1wDMmWvWE=.fa21f5fe-a61b-4764-97e6-ca040c387445@github.com>

On Mon, 8 Sep 2025 08:51:51 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

>> Replaced manual bullet points and line breaks in rule descriptions with HTML entities and tags for improved rendering. the attached images show the issue
>> 
>> 
>> <img width="613" height="364" alt="First Visit" src="https://github.com/user-attachments/assets/34c6564b-0581-44e4-a9ba-650767ede309" />
>> 
>> <img width="612" height="364" alt="Second Visit" src="https://github.com/user-attachments/assets/0c6cc99f-9c4d-4d76-908f-ef2fa5e1579a" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix line break tag syntax

@aymane-harmaz 
Your change (at version f6ae0d4835faba4002c29582d5fb117046dff8de) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/669#issuecomment-3279187437

From duke at openjdk.org  Thu Sep 11 08:49:09 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Thu, 11 Sep 2025 08:49:09 GMT
Subject: RFR: 8438: Update the version of JMC to 10.0.0
In-Reply-To: <6yCaQSeZmOuGUHGyxFbNXLlXoBP3nyp0-UGZSzdNpH8=.3a4e4789-9382-4e8e-96f6-966695b7b106@github.com>
References: <6yCaQSeZmOuGUHGyxFbNXLlXoBP3nyp0-UGZSzdNpH8=.3a4e4789-9382-4e8e-96f6-966695b7b106@github.com>
Message-ID: <T6tf-FBQHzzaE-90iV4P9tnx-wodBri5z-XKYnAWybs=.81083698-083c-45e9-9951-360b0c09c272@github.com>

On Mon, 8 Sep 2025 15:08:42 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Updated some versions in codebase that were referring to 9.1.0 toward 10.0.0

Thanks for the review

-------------

PR Comment: https://git.openjdk.org/jmc/pull/673#issuecomment-3279242402

From duke at openjdk.org  Thu Sep 11 08:52:24 2025
From: duke at openjdk.org (duke)
Date: Thu, 11 Sep 2025 08:52:24 GMT
Subject: RFR: 8438: Update the version of JMC to 10.0.0
In-Reply-To: <6yCaQSeZmOuGUHGyxFbNXLlXoBP3nyp0-UGZSzdNpH8=.3a4e4789-9382-4e8e-96f6-966695b7b106@github.com>
References: <6yCaQSeZmOuGUHGyxFbNXLlXoBP3nyp0-UGZSzdNpH8=.3a4e4789-9382-4e8e-96f6-966695b7b106@github.com>
Message-ID: <8xmc64C7SYIkkQ9hEBEOfgYEocS_MRloOh6zO94i1Ls=.c1d48837-3058-4173-886e-2a4e6d297e64@github.com>

On Mon, 8 Sep 2025 15:08:42 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Updated some versions in codebase that were referring to 9.1.0 toward 10.0.0

@aymane-harmaz 
Your change (at version f9f69f9c2ca532764b0c9205b9ff42c04fe987e3) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/673#issuecomment-3279254787

From duke at openjdk.org  Mon Sep 15 09:38:00 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Mon, 15 Sep 2025 09:38:00 GMT
Subject: Integrated: 8438: Update the version of JMC to 10.0.0
In-Reply-To: <6yCaQSeZmOuGUHGyxFbNXLlXoBP3nyp0-UGZSzdNpH8=.3a4e4789-9382-4e8e-96f6-966695b7b106@github.com>
References: <6yCaQSeZmOuGUHGyxFbNXLlXoBP3nyp0-UGZSzdNpH8=.3a4e4789-9382-4e8e-96f6-966695b7b106@github.com>
Message-ID: <y5r8i661KmNprs6i5_A8D557rc_LllgIm-rPoG1vbGI=.b6990654-c030-433b-9b05-117b04e2e11a@github.com>

On Mon, 8 Sep 2025 15:08:42 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Updated some versions in codebase that were referring to 9.1.0 toward 10.0.0

This pull request has now been integrated.

Changeset: 84b51275
Author:    Aymane Harmaz <aymane.harmaz at oracle.com>
Committer: Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/84b51275be1a20fd1fd192b7e57c58f79878c705
Stats:     4 lines in 3 files changed: 0 ins; 0 del; 4 mod

8438: Update the version of JMC to 10.0.0

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/673

From duke at openjdk.org  Mon Sep 15 09:41:34 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Mon, 15 Sep 2025 09:41:34 GMT
Subject: Integrated: 8436: Formatting of rule descriptions with manual bullets
 / line breaks is gone on revisit
In-Reply-To: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
References: <QaBl_dm2FCmKJuOoUFb4W2awiL-ivSrhBxV5UJHfIXE=.5f5b58ec-2e96-4608-a7e4-1f0eb74517f4@github.com>
Message-ID: <QbIVITsdgoT5VgRBNbqG38iUT4sMLUBOmhw8tCmZqHo=.ebfcc275-5956-4177-92be-85926e1437e5@github.com>

On Mon, 1 Sep 2025 14:34:14 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> Replaced manual bullet points and line breaks in rule descriptions with HTML entities and tags for improved rendering. the attached images show the issue
> 
> 
> <img width="613" height="364" alt="First Visit" src="https://github.com/user-attachments/assets/34c6564b-0581-44e4-a9ba-650767ede309" />
> 
> <img width="612" height="364" alt="Second Visit" src="https://github.com/user-attachments/assets/0c6cc99f-9c4d-4d76-908f-ef2fa5e1579a" />

This pull request has now been integrated.

Changeset: 25b8e1d1
Author:    Aymane Harmaz <aymane.harmaz at oracle.com>
Committer: Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/25b8e1d15d1f49f11ae021178e173b5346c4ed4b
Stats:     3 lines in 1 file changed: 2 ins; 0 del; 1 mod

8436: Formatting of rule descriptions with manual bullets / line breaks is gone on revisit

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/669

From duke at openjdk.org  Wed Sep 17 17:39:22 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Wed, 17 Sep 2025 17:39:22 GMT
Subject: RFR: 5608: Include top stack trace frames in errors and exceptions
 rules
Message-ID: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>

This PR includes : 
- Adding the most common error stack trace to the **Thrown Errors** rule
- Adding the most common exception to the **Thrown Exceptions** rule and its most common stack trace if **jdk.JavaExceptionThrow** event is enabled in recording configuration (for now the max number of stack trace frames displayed is 10)

<img width="587" height="458" alt="Screenshot 2025-09-17 at 17 30 16" src="https://github.com/user-attachments/assets/70240eef-f0c9-4231-a4e1-398e1af9f07b" />

-------------

Commit messages:
 - 5608: Include top stack trace frames in errors and exceptions rules

Changes: https://git.openjdk.org/jmc/pull/674/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=674&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-5608
  Stats: 106 lines in 6 files changed: 78 ins; 2 del; 26 mod
  Patch: https://git.openjdk.org/jmc/pull/674.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/674/head:pull/674

PR: https://git.openjdk.org/jmc/pull/674

From hirt at openjdk.org  Wed Sep 17 17:41:55 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 17 Sep 2025 17:41:55 GMT
Subject: RFR: 5608: Include top stack trace frames in errors and exceptions
 rules
In-Reply-To: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
References: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
Message-ID: <NiYCCuhSXiWxuxkeb2k4jPlKjrC2SPdI-Vog5HCUq48=.c97dddf2-0251-40be-8bba-c319be9f2fc3@github.com>

On Wed, 17 Sep 2025 17:33:07 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> This PR includes : 
> - Adding the most common error stack trace to the **Thrown Errors** rule
> - Adding the most common exception to the **Thrown Exceptions** rule and its most common stack trace if **jdk.JavaExceptionThrow** event is enabled in recording configuration (for now the max number of stack trace frames displayed is 10)
> 
> <img width="587" height="458" alt="Screenshot 2025-09-17 at 17 30 16" src="https://github.com/user-attachments/assets/70240eef-f0c9-4231-a4e1-398e1af9f07b" />

If there is an exception message available, perhaps you want to include the most common exception message too?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/674#issuecomment-3303971676

From duke at openjdk.org  Thu Sep 18 18:11:46 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Thu, 18 Sep 2025 18:11:46 GMT
Subject: RFR: 5608: Include top stack trace frames in errors and exceptions
 rules [v2]
In-Reply-To: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
References: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
Message-ID: <NM0QmLRTSkIEhfniD8xZeLWHHnlP6l7KJme9z4lRe5s=.29945d48-48e8-4069-8050-f3ad362e40e5@github.com>

> This PR includes : 
> - Adding the most common error stack trace to the **Thrown Errors** rule
> - Adding the most common exception to the **Thrown Exceptions** rule and its most common stack trace if **jdk.JavaExceptionThrow** event is enabled in recording configuration (for now the max number of stack trace frames displayed is 10)
> 
> <img width="587" height="458" alt="Screenshot 2025-09-17 at 17 30 16" src="https://github.com/user-attachments/assets/70240eef-f0c9-4231-a4e1-398e1af9f07b" />

Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:

  Adding most common error and exceprion message

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/674/files
  - new: https://git.openjdk.org/jmc/pull/674/files/c9ab4f3b..3d8d1252

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=674&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=674&range=00-01

  Stats: 74 lines in 5 files changed: 49 ins; 8 del; 17 mod
  Patch: https://git.openjdk.org/jmc/pull/674.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/674/head:pull/674

PR: https://git.openjdk.org/jmc/pull/674

From duke at openjdk.org  Thu Sep 18 18:20:15 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Thu, 18 Sep 2025 18:20:15 GMT
Subject: RFR: 5608: Include top stack trace frames in errors and exceptions
 rules [v2]
In-Reply-To: <NM0QmLRTSkIEhfniD8xZeLWHHnlP6l7KJme9z4lRe5s=.29945d48-48e8-4069-8050-f3ad362e40e5@github.com>
References: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
 <NM0QmLRTSkIEhfniD8xZeLWHHnlP6l7KJme9z4lRe5s=.29945d48-48e8-4069-8050-f3ad362e40e5@github.com>
Message-ID: <O_MaLpKdlf5y4dinfkecqXl8fHQtAgq01l0sKBuW9q4=.50a5694d-00cf-47e1-bf61-fb31542015a2@github.com>

On Thu, 18 Sep 2025 18:11:46 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

>> This PR includes : 
>> - Adding the most common error stack trace to the **Thrown Errors** rule
>> - Adding the most common exception to the **Thrown Exceptions** rule and its most common stack trace if **jdk.JavaExceptionThrow** event is enabled in recording configuration (for now the max number of stack trace frames displayed is 10)
>> 
>> <img width="587" height="458" alt="Screenshot 2025-09-17 at 17 30 16" src="https://github.com/user-attachments/assets/70240eef-f0c9-4231-a4e1-398e1af9f07b" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding most common error and exceprion message

Actual Rules overview

<img width="516" height="521" alt="Screenshot 2025-09-18 at 16 51 49" src="https://github.com/user-attachments/assets/a78ec8f2-888b-40df-a5d4-58f197e257bc" />

-------------

PR Comment: https://git.openjdk.org/jmc/pull/674#issuecomment-3308948359

From hirt at openjdk.org  Fri Sep 19 11:55:29 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 19 Sep 2025 11:55:29 GMT
Subject: RFR: 5608: Include top stack trace frames in errors and exceptions
 rules [v2]
In-Reply-To: <NM0QmLRTSkIEhfniD8xZeLWHHnlP6l7KJme9z4lRe5s=.29945d48-48e8-4069-8050-f3ad362e40e5@github.com>
References: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
 <NM0QmLRTSkIEhfniD8xZeLWHHnlP6l7KJme9z4lRe5s=.29945d48-48e8-4069-8050-f3ad362e40e5@github.com>
Message-ID: <lHZKkYLgtEaJrOAtFAOT8BwZite4as_vRj2grrxiLlY=.c1991591-5f0a-453d-bca5-f5fb09d932da@github.com>

On Thu, 18 Sep 2025 18:11:46 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

>> This PR includes : 
>> - Adding the most common error stack trace to the **Thrown Errors** rule
>> - Adding the most common exception to the **Thrown Exceptions** rule and its most common stack trace if **jdk.JavaExceptionThrow** event is enabled in recording configuration (for now the max number of stack trace frames displayed is 10)
>> 
>> <img width="587" height="458" alt="Screenshot 2025-09-17 at 17 30 16" src="https://github.com/user-attachments/assets/70240eef-f0c9-4231-a4e1-398e1af9f07b" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding most common error and exceprion message

Additional review comments.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/exceptions/ErrorRule.java line 118:

> 116: 	public static final TypedResult<String> MOST_COMMON_ERROR_STACKTRACE = new TypedResult<>(
> 117: 			"mostCommonErrorStacktrace", //$NON-NLS-1$
> 118: 			"Most Common Error Stacktrace", "The most common error stacktrace frames.", UnitLookup.PLAIN_TEXT,

In text we typically write stack trace instead of stacktrace, even if we often (and sorry about this) put STACKTRACE together in identifiers. For example, the Stack Trace view (we use capitalization / title case in views).

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/exceptions/ExceptionRule.java line 104:

> 102: 			"Most Common Exception Message", "The most common exception message.", UnitLookup.PLAIN_TEXT, String.class);
> 103: 	public static final TypedResult<String> MOST_COMMON_EXCEPTION_STACKTRACE = new TypedResult<>(
> 104: 			"mostCommonExceptionStacktrace", "Most Common Exception Stacktrace", //$NON-NLS-1$

Stack Trace

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/exceptions/ExceptionRule.java line 105:

> 103: 	public static final TypedResult<String> MOST_COMMON_EXCEPTION_STACKTRACE = new TypedResult<>(
> 104: 			"mostCommonExceptionStacktrace", "Most Common Exception Stacktrace", //$NON-NLS-1$
> 105: 			"The most common exception stacktrace frames.", UnitLookup.PLAIN_TEXT, String.class);

stack trace

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 236:

> 234: ErrorRule_TEXT_WARN_EXCLUDED_INFO=The following regular expression was used to exclude {excludedErrors} errors from this rule: ''{error.exclude.regexp}''.
> 235: # {mostCommonErrorMessage} is a string.
> 236: ErrorRule_TEXT_WARN_MOST_COMMON_ERROR_MESSAGE=The most common error message was : \n {mostCommonErrorMessage}

JMC avoids spacing before colon - should be "was:"

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 238:

> 236: ErrorRule_TEXT_WARN_MOST_COMMON_ERROR_MESSAGE=The most common error message was : \n {mostCommonErrorMessage}
> 237: # {mostCommonErrorStacktrace} is a string.
> 238: ErrorRule_TEXT_WARN_MOST_COMMON_ERROR_STACKTRACE=The most common error stackrace was : \n {mostCommonErrorStacktrace}

No space before colon.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 250:

> 248: ExceptionRule_TEXT_MESSAGE=The program generated {exceptionsRate} exceptions per second during {exceptionsWindow}.
> 249: #{mostCommonExceptionMessage} is a string
> 250: ExceptionRule_TEXT_MOST_COMMON_EXCEPTION_MESSAGE=The most common exception message was : \n {mostCommonExceptionMessage}

No space before colon.

core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 252:

> 250: ExceptionRule_TEXT_MOST_COMMON_EXCEPTION_MESSAGE=The most common exception message was : \n {mostCommonExceptionMessage}
> 251: #{mostCommonExceptionStacktrace} is a string.
> 252: ExceptionRule_TEXT_MOST_COMMON_EXCEPTION_STACKTRACE=The most common exception stacktrace was : \n {mostCommonExceptionStacktrace}

No space before colon.

core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/util/RulesToolkit.java line 1443:

> 1441: 
> 1442: 	/**
> 1443: 	 * Gets the top n frame in the most common stack trace. Useful when showing what called a

Maybe clarify this a bit in the javadoc, e.g. something like:

Returns up to {@code n} frames from the single most frequent branch in the aggregated stack traces for the provided  {@code items} . 

The result starts at the frame where the event(s) occurred and includes successive caller frames, up to the requested number. This is useful to see the most frequent path leading to calling an interesting method, like for example java.lang.Integer.valueOf (aka autoboxing).


@param items the events for which to aggregate stack traces
@param n the maximum number of frames to return
@return a string representation of up to {@code n} frames, starting at the
         event site and moving toward the callers


Feel free to edit.

core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/util/RulesToolkit.java line 1450:

> 1448: 	 * @return stack trace frames
> 1449: 	 */
> 1450: 	public static String getTopNFramesInMostCommonTrace(IItemCollection items, int n) {

Maybe add a small shim for people that might already use it outside of JMC?

public static String getSecondFrameInMostCommonTrace(IItemCollection items) {
	String frames = getTopNFramesInMostCommonTrace(items, 2);
	String[] parts = frames.split("\n");
	return parts.length >= 2 ? parts[1] : frames;
}

core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/main/resources/baseline/JfrRuleBaseline.xml line 6295:

> 6293: The most common error message was : 
> 6294:  &amp;lt;clinit&amp;gt;
> 6295: The most common error stackrace was : 

Typo: "stackrace" -> "stacktrace"

-------------

Changes requested by hirt (Lead).

PR Review: https://git.openjdk.org/jmc/pull/674#pullrequestreview-3244424631
PR Review Comment: https://git.openjdk.org/jmc/pull/674#discussion_r2362644568
PR Review Comment: https://git.openjdk.org/jmc/pull/674#discussion_r2362646265
PR Review Comment: https://git.openjdk.org/jmc/pull/674#discussion_r2362645740
PR Review Comment: https://git.openjdk.org/jmc/pull/674#discussion_r2362635799
PR Review Comment: https://git.openjdk.org/jmc/pull/674#discussion_r2362636500
PR Review Comment: https://git.openjdk.org/jmc/pull/674#discussion_r2362636832
PR Review Comment: https://git.openjdk.org/jmc/pull/674#discussion_r2362637330
PR Review Comment: https://git.openjdk.org/jmc/pull/674#discussion_r2362581446
PR Review Comment: https://git.openjdk.org/jmc/pull/674#discussion_r2362629086
PR Review Comment: https://git.openjdk.org/jmc/pull/674#discussion_r2362633661

From hirt at openjdk.org  Fri Sep 19 11:55:30 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 19 Sep 2025 11:55:30 GMT
Subject: RFR: 5608: Include top stack trace frames in errors and exceptions
 rules [v2]
In-Reply-To: <lHZKkYLgtEaJrOAtFAOT8BwZite4as_vRj2grrxiLlY=.c1991591-5f0a-453d-bca5-f5fb09d932da@github.com>
References: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
 <NM0QmLRTSkIEhfniD8xZeLWHHnlP6l7KJme9z4lRe5s=.29945d48-48e8-4069-8050-f3ad362e40e5@github.com>
 <lHZKkYLgtEaJrOAtFAOT8BwZite4as_vRj2grrxiLlY=.c1991591-5f0a-453d-bca5-f5fb09d932da@github.com>
Message-ID: <77qxPPpEwvHHAczoDVIueSaY6BsDZbuRzZRHpCHSThk=.2e39e1ce-a39f-4c36-8492-421119cee814@github.com>

On Fri, 19 Sep 2025 11:48:11 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding most common error and exceprion message
>
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 252:
> 
>> 250: ExceptionRule_TEXT_MOST_COMMON_EXCEPTION_MESSAGE=The most common exception message was : \n {mostCommonExceptionMessage}
>> 251: #{mostCommonExceptionStacktrace} is a string.
>> 252: ExceptionRule_TEXT_MOST_COMMON_EXCEPTION_STACKTRACE=The most common exception stacktrace was : \n {mostCommonExceptionStacktrace}
> 
> No space before colon.

And stack trace.

> core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/util/RulesToolkit.java line 1450:
> 
>> 1448: 	 * @return stack trace frames
>> 1449: 	 */
>> 1450: 	public static String getTopNFramesInMostCommonTrace(IItemCollection items, int n) {
> 
> Maybe add a small shim for people that might already use it outside of JMC?
> 
> public static String getSecondFrameInMostCommonTrace(IItemCollection items) {
> 	String frames = getTopNFramesInMostCommonTrace(items, 2);
> 	String[] parts = frames.split("\n");
> 	return parts.length >= 2 ? parts[1] : frames;
> }

You might also want for the Autoboxing rule to use the shim. :)

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/674#discussion_r2362647085
PR Review Comment: https://git.openjdk.org/jmc/pull/674#discussion_r2362630174

From duke at openjdk.org  Mon Sep 22 11:22:16 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Mon, 22 Sep 2025 11:22:16 GMT
Subject: RFR: 5608: Include top stack trace frames in errors and exceptions
 rules [v3]
In-Reply-To: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
References: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
Message-ID: <8SAWqHhyY4WF8-Ay2g161A07ek5WY9a4cHMHTnXTS7s=.6affa127-f5a2-4f66-bd68-0542964553b1@github.com>

> This PR includes : 
> - Adding the most common error stack trace to the **Thrown Errors** rule
> - Adding the most common exception to the **Thrown Exceptions** rule and its most common stack trace if **jdk.JavaExceptionThrow** event is enabled in recording configuration (for now the max number of stack trace frames displayed is 10)
> 
> <img width="587" height="458" alt="Screenshot 2025-09-17 at 17 30 16" src="https://github.com/user-attachments/assets/70240eef-f0c9-4231-a4e1-398e1af9f07b" />

Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:

  Implemented review comments

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/674/files
  - new: https://git.openjdk.org/jmc/pull/674/files/3d8d1252..9921a85b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=674&range=02
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=674&range=01-02

  Stats: 102 lines in 6 files changed: 61 ins; 7 del; 34 mod
  Patch: https://git.openjdk.org/jmc/pull/674.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/674/head:pull/674

PR: https://git.openjdk.org/jmc/pull/674

From duke at openjdk.org  Mon Sep 22 11:30:23 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Mon, 22 Sep 2025 11:30:23 GMT
Subject: RFR: 5608: Include top stack trace frames in errors and exceptions
 rules [v2]
In-Reply-To: <77qxPPpEwvHHAczoDVIueSaY6BsDZbuRzZRHpCHSThk=.2e39e1ce-a39f-4c36-8492-421119cee814@github.com>
References: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
 <NM0QmLRTSkIEhfniD8xZeLWHHnlP6l7KJme9z4lRe5s=.29945d48-48e8-4069-8050-f3ad362e40e5@github.com>
 <lHZKkYLgtEaJrOAtFAOT8BwZite4as_vRj2grrxiLlY=.c1991591-5f0a-453d-bca5-f5fb09d932da@github.com>
 <77qxPPpEwvHHAczoDVIueSaY6BsDZbuRzZRHpCHSThk=.2e39e1ce-a39f-4c36-8492-421119cee814@github.com>
Message-ID: <zvlT0UWG_MIDKK3O3xWhiigK9virihXE5Un28cMJNDo=.36da973c-489f-4d59-8161-0c43df3b2e4e@github.com>

On Fri, 19 Sep 2025 11:45:08 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> You might also want for the Autoboxing rule to use the shim. :)

I have noticed that the Autoboxing rule works with `IMCFrame` type, and since the `getSecondFrameInMostCommonTrace` was returning a String, I left its signature as it was, then I used the `getTopNFramesInMostCommonTrace` which I made return a List of Frames without formatting.

The formatting was left at the places using `getTopNFramesInMostCommonTrace` if it is needed.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/674#discussion_r2367810559

From hirt at openjdk.org  Mon Sep 22 15:49:29 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 22 Sep 2025 15:49:29 GMT
Subject: RFR: 5608: Include top stack trace frames in errors and exceptions
 rules [v3]
In-Reply-To: <8SAWqHhyY4WF8-Ay2g161A07ek5WY9a4cHMHTnXTS7s=.6affa127-f5a2-4f66-bd68-0542964553b1@github.com>
References: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
 <8SAWqHhyY4WF8-Ay2g161A07ek5WY9a4cHMHTnXTS7s=.6affa127-f5a2-4f66-bd68-0542964553b1@github.com>
Message-ID: <yqAAk6TUlEzO00tBvzJ8kEEVNIVA2TPfGEQwlqpnxHc=.a871b458-27c0-48c7-82b7-6ac01c32370c@github.com>

On Mon, 22 Sep 2025 11:22:16 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

>> This PR includes : 
>> - Adding the most common error stack trace to the **Thrown Errors** rule
>> - Adding the most common exception to the **Thrown Exceptions** rule and its most common stack trace if **jdk.JavaExceptionThrow** event is enabled in recording configuration (for now the max number of stack trace frames displayed is 10)
>> 
>> <img width="587" height="458" alt="Screenshot 2025-09-17 at 17 30 16" src="https://github.com/user-attachments/assets/70240eef-f0c9-4231-a4e1-398e1af9f07b" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments

Nice!

-------------

Marked as reviewed by hirt (Lead).

PR Review: https://git.openjdk.org/jmc/pull/674#pullrequestreview-3253660974

From duke at openjdk.org  Mon Sep 22 15:55:55 2025
From: duke at openjdk.org (duke)
Date: Mon, 22 Sep 2025 15:55:55 GMT
Subject: RFR: 5608: Include top stack trace frames in errors and exceptions
 rules [v3]
In-Reply-To: <8SAWqHhyY4WF8-Ay2g161A07ek5WY9a4cHMHTnXTS7s=.6affa127-f5a2-4f66-bd68-0542964553b1@github.com>
References: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
 <8SAWqHhyY4WF8-Ay2g161A07ek5WY9a4cHMHTnXTS7s=.6affa127-f5a2-4f66-bd68-0542964553b1@github.com>
Message-ID: <5gS7LCCkBurjgW1p3d8u9JKbEh8Oh_nhW7cELy4YLxs=.5928730c-dc58-4124-be38-db8b54135e20@github.com>

On Mon, 22 Sep 2025 11:22:16 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

>> This PR includes : 
>> - Adding the most common error stack trace to the **Thrown Errors** rule
>> - Adding the most common exception to the **Thrown Exceptions** rule and its most common stack trace if **jdk.JavaExceptionThrow** event is enabled in recording configuration (for now the max number of stack trace frames displayed is 10)
>> 
>> <img width="587" height="458" alt="Screenshot 2025-09-17 at 17 30 16" src="https://github.com/user-attachments/assets/70240eef-f0c9-4231-a4e1-398e1af9f07b" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comments

@aymane-harmaz 
Your change (at version 9921a85b4b7f8baad4b696561d3f126cde47ce49) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/674#issuecomment-3319867536

From duke at openjdk.org  Mon Sep 22 16:00:19 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Mon, 22 Sep 2025 16:00:19 GMT
Subject: Integrated: 5608: Include top stack trace frames in errors and
 exceptions rules
In-Reply-To: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
References: <3T9KQEM0zdNoAQcF0OvIUlXNSUdg1r3gqRf503EwJJQ=.986086b9-d0f0-49a4-a198-e09571a05869@github.com>
Message-ID: <9EUg7pCD-RzXuYfRzQ9gPiM2tyeVZZ_sF4GFnG9paXI=.92818c53-f5d9-470c-a273-0a9d1b6ad262@github.com>

On Wed, 17 Sep 2025 17:33:07 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> This PR includes : 
> - Adding the most common error stack trace to the **Thrown Errors** rule
> - Adding the most common exception to the **Thrown Exceptions** rule and its most common stack trace if **jdk.JavaExceptionThrow** event is enabled in recording configuration (for now the max number of stack trace frames displayed is 10)
> 
> <img width="587" height="458" alt="Screenshot 2025-09-17 at 17 30 16" src="https://github.com/user-attachments/assets/70240eef-f0c9-4231-a4e1-398e1af9f07b" />

This pull request has now been integrated.

Changeset: 181b8a03
Author:    Aymane Harmaz <aymane.harmaz at oracle.com>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/181b8a030c9d54104389318df575e7931df08d93
Stats:     219 lines in 7 files changed: 187 ins; 16 del; 16 mod

5608: Include top stack trace frames in errors and exceptions rules

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/674

From duke at openjdk.org  Tue Sep 23 10:14:06 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Tue, 23 Sep 2025 10:14:06 GMT
Subject: RFR: 8439: ArithmeticException thrown when plotting event count
 histogram with maxDuration set to 0
Message-ID: <qG9eXUVAkliCDipamMVPWCbSVYI5gu5Na1yyTW6BxFM=.e53e0667-99da-454f-a4a3-cd6b9223eb85@github.com>

When plotting event count histogram and all event durations are set to 0, the duration range will be evaluated to 0, leading to an ArithmeticException (divid by 0), which stops JMC from plotting that histogram.

This can be shown on the attached screenshot, where only the percentile table is shown and the histogram chart is missing

<img width="1506" height="865" alt="missing-histogram" src="https://github.com/user-attachments/assets/7a02b705-83f3-45e9-9feb-91c5904064e7" />

-------------

Commit messages:
 - 8439: ArithmeticException thrown when plotting event count histogram with maxDuration set to 0

Changes: https://git.openjdk.org/jmc/pull/675/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=675&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8439
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/675.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/675/head:pull/675

PR: https://git.openjdk.org/jmc/pull/675

From hirt at openjdk.org  Thu Sep 25 15:10:37 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 25 Sep 2025 15:10:37 GMT
Subject: RFR: 8439: ArithmeticException thrown when plotting event count
 histogram with maxDuration set to 0
In-Reply-To: <qG9eXUVAkliCDipamMVPWCbSVYI5gu5Na1yyTW6BxFM=.e53e0667-99da-454f-a4a3-cd6b9223eb85@github.com>
References: <qG9eXUVAkliCDipamMVPWCbSVYI5gu5Na1yyTW6BxFM=.e53e0667-99da-454f-a4a3-cd6b9223eb85@github.com>
Message-ID: <RDvsjxF38BGQnH2Lb3gnGVq7BzZrB_3p3r_u79DIwzI=.00e16e85-34d0-4699-9faf-a582e828f474@github.com>

On Tue, 23 Sep 2025 10:07:04 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

> When plotting event count histogram and all event durations are set to 0, the duration range will be evaluated to 0, leading to an ArithmeticException (divid by 0), which stops JMC from plotting that histogram.
> 
> This can be shown on the attached screenshot, where only the percentile table is shown and the histogram chart is missing
> 
> <img width="1506" height="865" alt="missing-histogram" src="https://github.com/user-attachments/assets/7a02b705-83f3-45e9-9feb-91c5904064e7" />

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/histogram/HDRHistogramView.java line 272:

> 270: 			// Get the maximum duration to set chart bounds
> 271: 			IQuantity maxDuration = itemsWithDuration.getAggregate(JdkAggregators.LONGEST_EVENT);
> 272: 			if (maxDuration == null || maxDuration.doubleValueIn(UnitLookup.MILLISECOND) == 0.0) {

Nice catch. To avoid FP equality and unit conversion surprises, please compare against zero using nanoseconds:
maxDuration.longValueIn(UnitLookup.NANOSECOND) == 0L

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/675#discussion_r2379491986

From duke at openjdk.org  Thu Sep 25 17:28:22 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Thu, 25 Sep 2025 17:28:22 GMT
Subject: RFR: 8439: ArithmeticException thrown when plotting event count
 histogram with maxDuration set to 0 [v2]
In-Reply-To: <qG9eXUVAkliCDipamMVPWCbSVYI5gu5Na1yyTW6BxFM=.e53e0667-99da-454f-a4a3-cd6b9223eb85@github.com>
References: <qG9eXUVAkliCDipamMVPWCbSVYI5gu5Na1yyTW6BxFM=.e53e0667-99da-454f-a4a3-cd6b9223eb85@github.com>
Message-ID: <qGZcNTgdvV0xlD3ZT0KoYJjiYo0l5ymD-NZAvWhbzYo=.1ff38c74-a764-46f1-879c-b000344250bf@github.com>

> When plotting event count histogram and all event durations are set to 0, the duration range will be evaluated to 0, leading to an ArithmeticException (divid by 0), which stops JMC from plotting that histogram.
> 
> This can be shown on the attached screenshot, where only the percentile table is shown and the histogram chart is missing
> 
> <img width="1506" height="865" alt="missing-histogram" src="https://github.com/user-attachments/assets/7a02b705-83f3-45e9-9feb-91c5904064e7" />

Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:

  Implemented review comment

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/675/files
  - new: https://git.openjdk.org/jmc/pull/675/files/469f134e..9e8221a5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=675&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=675&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/675.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/675/head:pull/675

PR: https://git.openjdk.org/jmc/pull/675

From duke at openjdk.org  Thu Sep 25 17:36:51 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Thu, 25 Sep 2025 17:36:51 GMT
Subject: RFR: 8439: ArithmeticException thrown when plotting event count
 histogram with maxDuration set to 0 [v2]
In-Reply-To: <RDvsjxF38BGQnH2Lb3gnGVq7BzZrB_3p3r_u79DIwzI=.00e16e85-34d0-4699-9faf-a582e828f474@github.com>
References: <qG9eXUVAkliCDipamMVPWCbSVYI5gu5Na1yyTW6BxFM=.e53e0667-99da-454f-a4a3-cd6b9223eb85@github.com>
 <RDvsjxF38BGQnH2Lb3gnGVq7BzZrB_3p3r_u79DIwzI=.00e16e85-34d0-4699-9faf-a582e828f474@github.com>
Message-ID: <nd60l0GeFwTfEgsc2a9UyPN6be9qKfQB5L7sJexJBbY=.39bc8ecd-4a14-4151-a1f9-b84c2926b73c@github.com>

On Thu, 25 Sep 2025 15:07:53 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Implemented review comment
>
> application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/histogram/HDRHistogramView.java line 272:
> 
>> 270: 			// Get the maximum duration to set chart bounds
>> 271: 			IQuantity maxDuration = itemsWithDuration.getAggregate(JdkAggregators.LONGEST_EVENT);
>> 272: 			if (maxDuration == null || maxDuration.doubleValueIn(UnitLookup.MILLISECOND) == 0.0) {
> 
> Nice catch. To avoid FP equality and unit conversion surprises, please compare against zero using nanoseconds:
> maxDuration.longValueIn(UnitLookup.NANOSECOND) == 0L

Thanks for the insight.
I used `clampedLongValueIn` as the only critical case here is equality with 0L, and this way we don?t need to handle conversion exceptions explicitly

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/675#discussion_r2379858839

From hirt at openjdk.org  Sat Sep 27 01:43:34 2025
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 27 Sep 2025 01:43:34 GMT
Subject: RFR: 8439: ArithmeticException thrown when plotting event count
 histogram with maxDuration set to 0 [v2]
In-Reply-To: <qGZcNTgdvV0xlD3ZT0KoYJjiYo0l5ymD-NZAvWhbzYo=.1ff38c74-a764-46f1-879c-b000344250bf@github.com>
References: <qG9eXUVAkliCDipamMVPWCbSVYI5gu5Na1yyTW6BxFM=.e53e0667-99da-454f-a4a3-cd6b9223eb85@github.com>
 <qGZcNTgdvV0xlD3ZT0KoYJjiYo0l5ymD-NZAvWhbzYo=.1ff38c74-a764-46f1-879c-b000344250bf@github.com>
Message-ID: <w1VIzsCuV-PFzLrPXASLADdZDxVi_QrfmXQiF2XwrJE=.1c57433a-3b35-41cd-801c-7ebe9a471781@github.com>

On Thu, 25 Sep 2025 17:28:22 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

>> When plotting event count histogram and all event durations are set to 0, the duration range will be evaluated to 0, leading to an ArithmeticException (divid by 0), which stops JMC from plotting that histogram.
>> 
>> This can be shown on the attached screenshot, where only the percentile table is shown and the histogram chart is missing
>> 
>> <img width="1506" height="865" alt="missing-histogram" src="https://github.com/user-attachments/assets/7a02b705-83f3-45e9-9feb-91c5904064e7" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comment

Marked as reviewed by hirt (Lead).

Good to go!

-------------

PR Review: https://git.openjdk.org/jmc/pull/675#pullrequestreview-3274361604
PR Comment: https://git.openjdk.org/jmc/pull/675#issuecomment-3340980166

From duke at openjdk.org  Sat Sep 27 09:22:33 2025
From: duke at openjdk.org (Aymane Harmaz)
Date: Sat, 27 Sep 2025 09:22:33 GMT
Subject: RFR: 8439: ArithmeticException thrown when plotting event count
 histogram with maxDuration set to 0 [v2]
In-Reply-To: <qGZcNTgdvV0xlD3ZT0KoYJjiYo0l5ymD-NZAvWhbzYo=.1ff38c74-a764-46f1-879c-b000344250bf@github.com>
References: <qG9eXUVAkliCDipamMVPWCbSVYI5gu5Na1yyTW6BxFM=.e53e0667-99da-454f-a4a3-cd6b9223eb85@github.com>
 <qGZcNTgdvV0xlD3ZT0KoYJjiYo0l5ymD-NZAvWhbzYo=.1ff38c74-a764-46f1-879c-b000344250bf@github.com>
Message-ID: <EoDBnqMogkRgg9rXB9iI8STjdR02A6-9HXBj0dCgjMU=.72d2942b-b12d-4a2a-899d-84c530559f9e@github.com>

On Thu, 25 Sep 2025 17:28:22 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

>> When plotting event count histogram and all event durations are set to 0, the duration range will be evaluated to 0, leading to an ArithmeticException (divid by 0), which stops JMC from plotting that histogram.
>> 
>> This can be shown on the attached screenshot, where only the percentile table is shown and the histogram chart is missing
>> 
>> <img width="1506" height="865" alt="missing-histogram" src="https://github.com/user-attachments/assets/7a02b705-83f3-45e9-9feb-91c5904064e7" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comment

Thanks for the review.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/675#issuecomment-3341439030

From duke at openjdk.org  Sat Sep 27 09:22:34 2025
From: duke at openjdk.org (duke)
Date: Sat, 27 Sep 2025 09:22:34 GMT
Subject: RFR: 8439: ArithmeticException thrown when plotting event count
 histogram with maxDuration set to 0 [v2]
In-Reply-To: <qGZcNTgdvV0xlD3ZT0KoYJjiYo0l5ymD-NZAvWhbzYo=.1ff38c74-a764-46f1-879c-b000344250bf@github.com>
References: <qG9eXUVAkliCDipamMVPWCbSVYI5gu5Na1yyTW6BxFM=.e53e0667-99da-454f-a4a3-cd6b9223eb85@github.com>
 <qGZcNTgdvV0xlD3ZT0KoYJjiYo0l5ymD-NZAvWhbzYo=.1ff38c74-a764-46f1-879c-b000344250bf@github.com>
Message-ID: <T5XMhHsCf5KUBjAKA8N9DhCeqQk-aNmji0368nNq4o4=.97849287-757e-4d38-8984-07490475f812@github.com>

On Thu, 25 Sep 2025 17:28:22 GMT, Aymane Harmaz <duke at openjdk.org> wrote:

>> When plotting event count histogram and all event durations are set to 0, the duration range will be evaluated to 0, leading to an ArithmeticException (divid by 0), which stops JMC from plotting that histogram.
>> 
>> This can be shown on the attached screenshot, where only the percentile table is shown and the histogram chart is missing
>> 
>> <img width="1506" height="865" alt="missing-histogram" src="https://github.com/user-attachments/assets/7a02b705-83f3-45e9-9feb-91c5904064e7" />
>
> Aymane Harmaz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented review comment

@aymane-harmaz 
Your change (at version 9e8221a5d9a516cb521f01e58ba7340c8fba5a18) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/675#issuecomment-3341439272