RFR: 6203: Add ZGC allocation stall rule [v4]
Suchita Chaturvedi
schaturvedi at openjdk.org
Fri Sep 5 08:36:19 UTC 2025
On Thu, 4 Sep 2025 21:02:14 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Implemented review comments
>
> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/ZGCAllocationStallRule.java line 76:
>
>> 74: JdkAggregators.ZGC_ALLOCATION_STALL_COUNT, UnitLookup.NUMBER, IQuantity.class);
>> 75:
>> 76: public static final TypedResult<IQuantity> ZGC_ALLOCATION_STALL_LONGEST_DURATION = new TypedResult<>(
>
> These are durations, so shouldn’t they use UnitLookup.MILLISECOND?
I have checked at other places. For Duration we have used UnitLookup.TIMESPAN. So I have used the same here.
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/664#discussion_r2324463128
More information about the jmc-dev
mailing list