RFR: 8436: Formatting of rule descriptions with manual bullets / line breaks is gone on revisit
Marcus Hirt
hirt at openjdk.org
Fri Sep 5 19:58:18 UTC 2025
On Mon, 1 Sep 2025 14:34:14 GMT, Aymane Harmaz <duke at openjdk.org> wrote:
> Replaced manual bullet points and line breaks in rule descriptions with HTML entities and tags for improved rendering. the attached images show the issue
>
>
> <img width="613" height="364" alt="First Visit" src="https://github.com/user-attachments/assets/34c6564b-0581-44e4-a9ba-650767ede309" />
>
> <img width="612" height="364" alt="Second Visit" src="https://github.com/user-attachments/assets/0c6cc99f-9c4d-4d76-908f-ef2fa5e1579a" />
Changes requested by hirt (Lead).
core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/html/internal/RulesHtmlToolkit.java line 255:
> 253: description += (solution != null) ? "<div class=\"longDescription\">" + solution + "</div>" : ""; //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
> 254: Matcher matcher = LINK_PATTERN.matcher(description);
> 255: description = description.replace("\n", "</br>") //$NON-NLS-1$//$NON-NLS-2$
Should this be <br/>?
-------------
PR Review: https://git.openjdk.org/jmc/pull/669#pullrequestreview-3190613702
PR Review Comment: https://git.openjdk.org/jmc/pull/669#discussion_r2325926916
More information about the jmc-dev
mailing list