From aharmaz at openjdk.org  Sat Jan  3 00:17:11 2026
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Sat, 3 Jan 2026 00:17:11 GMT
Subject: Integrated: 8432: Better exception handling for Email Trigger failure
In-Reply-To: <YY8qdB8d1a5LvWjKd-xtG_jnFb5bF3Qk01BqGtbY_iQ=.d749ffad-8ec5-4544-a5b3-454f66fb244d@github.com>
References: <YY8qdB8d1a5LvWjKd-xtG_jnFb5bF3Qk01BqGtbY_iQ=.d749ffad-8ec5-4544-a5b3-454f66fb244d@github.com>
Message-ID: <YMl8jv2wlz-jNkqQIo9EHA_nMnPL58LvrhokVyD14TU=.846a4781-03b3-4494-91a0-3a95de74cd13@github.com>

On Mon, 8 Dec 2025 11:31:36 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR : 
> - Restructures the exception message displayed when the email send trigger fails, to show the root cause of the issue at the top before the trigger message
> - Increases the initial height of alert dialog for a better visibility
> 
> Alert dialog after the change : 
> 
> <img width="609" height="348" alt="Screenshot 2025-12-08 at 12 23 02" src="https://github.com/user-attachments/assets/0f933b11-4b46-44e3-89fa-377633ff7f8c" />

This pull request has now been integrated.

Changeset: 5778a3e0
Author:    Aymane Harmaz <aharmaz at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/5778a3e0502237db43cb0aebd3fdf4062faa86f8
Stats:     19 lines in 3 files changed: 13 ins; 3 del; 3 mod

8432: Better exception handling for Email Trigger failure

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.org/jmc/pull/692

From aptmac at openjdk.org  Tue Jan  6 02:22:10 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 6 Jan 2026 02:22:10 GMT
Subject: RFR: 8489: Inaccurate Chinese translations.
In-Reply-To: <f7pBQb86jO04jkDcEmlwhRBesWkWNcOXGVeO3P0341Q=.a78ee52d-fe56-42f8-82dd-703f63de7338@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <f7pBQb86jO04jkDcEmlwhRBesWkWNcOXGVeO3P0341Q=.a78ee52d-fe56-42f8-82dd-703f63de7338@github.com>
Message-ID: <NmoYY4GB6OfRbQJCX7kI7CZcxPKfekPwcwcdXAxpv8g=.62e25e6b-c2b7-4a7b-8906-4321d1dc4065@github.com>

On Thu, 1 Jan 2026 15:37:49 GMT, Huang Xiao <duke at openjdk.org> wrote:

>> The translation of some column names is inaccurate:
>> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />
>
> I don't have access to JBS yet. Could someone please create an issue for this PR?

@youngledo Thanks for opening the PR! I've opened a jira ticket for you to use here: https://bugs.openjdk.org/browse/JMC-8489

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3710653329

From duke at openjdk.org  Tue Jan  6 02:22:09 2026
From: duke at openjdk.org (Huang Xiao)
Date: Tue, 6 Jan 2026 02:22:09 GMT
Subject: RFR: 8489: Inaccurate Chinese translations.
Message-ID: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>

The translation of some column names is inaccurate:
<img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

-------------

Commit messages:
 - Inaccurate Chinese translations.

Changes: https://git.openjdk.org/jmc/pull/697/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8489
  Stats: 12 lines in 2 files changed: 0 ins; 0 del; 12 mod
  Patch: https://git.openjdk.org/jmc/pull/697.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/697/head:pull/697

PR: https://git.openjdk.org/jmc/pull/697

From duke at openjdk.org  Tue Jan  6 02:22:10 2026
From: duke at openjdk.org (Huang Xiao)
Date: Tue, 6 Jan 2026 02:22:10 GMT
Subject: RFR: 8489: Inaccurate Chinese translations.
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <f7pBQb86jO04jkDcEmlwhRBesWkWNcOXGVeO3P0341Q=.a78ee52d-fe56-42f8-82dd-703f63de7338@github.com>

On Thu, 1 Jan 2026 15:25:25 GMT, Huang Xiao <duke at openjdk.org> wrote:

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

I don't have access to JBS yet. Could someone please create an issue for this PR?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3703833610

From duke at openjdk.org  Tue Jan  6 03:30:05 2026
From: duke at openjdk.org (Huang Xiao)
Date: Tue, 6 Jan 2026 03:30:05 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page
In-Reply-To: <f7pBQb86jO04jkDcEmlwhRBesWkWNcOXGVeO3P0341Q=.a78ee52d-fe56-42f8-82dd-703f63de7338@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <f7pBQb86jO04jkDcEmlwhRBesWkWNcOXGVeO3P0341Q=.a78ee52d-fe56-42f8-82dd-703f63de7338@github.com>
Message-ID: <4LaIHY3P0iXYShJNrNyT4L7bIjVIGnDdcnXNgeZTdMk=.8be0ca09-5012-42f6-b526-30a0577c15b5@github.com>

On Thu, 1 Jan 2026 15:37:49 GMT, Huang Xiao <duke at openjdk.org> wrote:

>> The translation of some column names is inaccurate:
>> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />
>
> I don't have access to JBS yet. Could someone please create an issue for this PR?

> @youngledo Thanks for opening the PR! I've opened a jira ticket for you to use here: https://bugs.openjdk.org/browse/JMC-8489

Thanks! Please continue to help me with code review.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3712962600

From schaturvedi at openjdk.org  Tue Jan  6 08:04:30 2026
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Tue, 6 Jan 2026 08:04:30 GMT
Subject: RFR: 8479: Update jolokia third party for JMC 10.0.0
In-Reply-To: <TEcElQah7utwYsji6uSBcAkZchMypgmD1Kr5oA-PGkc=.cc0f1478-6711-46c8-a015-b7d7fc4ea617@github.com>
References: <TEcElQah7utwYsji6uSBcAkZchMypgmD1Kr5oA-PGkc=.cc0f1478-6711-46c8-a015-b7d7fc4ea617@github.com>
Message-ID: <Cx_nUoxBHmPRkMKLZAsesS1KIREQq5pX72tWP3FC22I=.57a219c3-6593-4b57-8155-5e98effbac4b@github.com>

On Mon, 15 Dec 2025 21:20:45 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> Upgrade external jolokia dependencies 2.0.2 -> 2.4.2. There have been some name changes, that also require changes in JMC.

Looks good to me.

-------------

Marked as reviewed by schaturvedi (Committer).

PR Review: https://git.openjdk.org/jmc/pull/695#pullrequestreview-3629839439

From duke at openjdk.org  Tue Jan  6 12:27:32 2026
From: duke at openjdk.org (duke)
Date: Tue, 6 Jan 2026 12:27:32 GMT
Subject: RFR: 8479: Update jolokia third party for JMC 10.0.0
In-Reply-To: <TEcElQah7utwYsji6uSBcAkZchMypgmD1Kr5oA-PGkc=.cc0f1478-6711-46c8-a015-b7d7fc4ea617@github.com>
References: <TEcElQah7utwYsji6uSBcAkZchMypgmD1Kr5oA-PGkc=.cc0f1478-6711-46c8-a015-b7d7fc4ea617@github.com>
Message-ID: <xPilLVQCm0Im4It23Rb_zMBHBH5r-lw-eeD2_3DMfyo=.4d0d4215-f3d8-4644-a2af-0e350c76a793@github.com>

On Mon, 15 Dec 2025 21:20:45 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> Upgrade external jolokia dependencies 2.0.2 -> 2.4.2. There have been some name changes, that also require changes in JMC.

@skarsaune 
Your change (at version 327187415a7b4130d91ade34508d11b4cb2cc6f5) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/695#issuecomment-3714511368

From aptmac at openjdk.org  Tue Jan  6 15:16:11 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 6 Jan 2026 15:16:11 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <6vrFR7LupvSm0LGoudhYiFXUhc3E70kqv2fAy9NMEic=.b2a1de21-1a8b-4714-bea0-d32aa709b936@github.com>

On Thu, 1 Jan 2026 15:25:25 GMT, Huang Xiao <duke at openjdk.org> wrote:

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/697#pullrequestreview-3631282598

From aptmac at openjdk.org  Wed Jan  7 19:30:34 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 7 Jan 2026 19:30:34 GMT
Subject: RFR: 8476: Websocket server is tied to JfrEditor
Message-ID: <A6FmgeU8BxZdI8Z7adLM7k7Ig08no9HlOHRph5g3XaI=.656131b2-673a-45dd-b0cd-b8f1165321a5@github.com>

This PR addresses JMC-8476, in which the current websocket server implemention ties the server to a JfrEditor page.

At the moment, the Websocket server that is used to send selection data is created from within a JfrEditor page. So every time you open a new recording file, the JfrEditor code tries to start a new websocket server. This is a problem because there is only one field in the JMC settings to set the port number, and it is global to the application. So if I open recording-1, and then use the preferences menu to start the websocket server on port 8029, if I then open up recording-2 it will also try to open a websocket server on port 8029, and fail. As a result, sending data from recording-1 will work, but recording-2 will not (this can be seen in my "before" gif below).

I have extracted the websocket code out into it's own package and made it such that there is one server for the JMC application. So now if you toggle between recordings you can still send data to whatever application you want over websocket.

Before:
(exception thrown when trying to send events from the second recording)
![before](https://github.com/user-attachments/assets/8e9a3c97-f974-4409-99ea-6f86eb33e8cb)

After:
(selecting events from multiple recordings now works)
![after](https://github.com/user-attachments/assets/11ff55af-f691-4780-b504-adf4847be3e8)

-------------

Commit messages:
 - 8476: Websocket server is tied to JfrEditor

Changes: https://git.openjdk.org/jmc/pull/698/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=698&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8476
  Stats: 1154 lines in 23 files changed: 739 ins; 393 del; 22 mod
  Patch: https://git.openjdk.org/jmc/pull/698.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/698/head:pull/698

PR: https://git.openjdk.org/jmc/pull/698

From aptmac at openjdk.org  Wed Jan  7 19:39:49 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 7 Jan 2026 19:39:49 GMT
Subject: RFR: 8481: Update lz4-java to 1.10.2 [v4]
In-Reply-To: <N4Uae7vF_rOZcjCYDYhL-7aEM6ZKETXCZAiyLfGTXMg=.98cbddf2-9ac4-44fb-b6a9-d8e4dc67a5de@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
 <N4Uae7vF_rOZcjCYDYhL-7aEM6ZKETXCZAiyLfGTXMg=.98cbddf2-9ac4-44fb-b6a9-d8e4dc67a5de@github.com>
Message-ID: <rH7HolmtbPsDFqfnFZ4uOB2dYe1y1BnlFKUGBNI8Er0=.b5ba5334-2e18-4595-895f-01b91091e3b8@github.com>

On Tue, 16 Dec 2025 15:43:29 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> There's currently a security advisory open for the version of lz4-java we are using. lz4-java had been archived, but has been updated by a new maintainer with a fix for the security issue.
>> 
>> See: https://github.com/yawkat/lz4-java/security/advisories/GHSA-cmp6-m4wj-q63q
>
> Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update to 1.10.2

Gave this a test now that the 1.10.2 release is out, and it's working as expected now

-------------

PR Comment: https://git.openjdk.org/jmc/pull/694#issuecomment-3720458146

From duke at openjdk.org  Thu Jan  8 01:10:07 2026
From: duke at openjdk.org (Huang Xiao)
Date: Thu, 8 Jan 2026 01:10:07 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page
In-Reply-To: <NmoYY4GB6OfRbQJCX7kI7CZcxPKfekPwcwcdXAxpv8g=.62e25e6b-c2b7-4a7b-8906-4321d1dc4065@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <f7pBQb86jO04jkDcEmlwhRBesWkWNcOXGVeO3P0341Q=.a78ee52d-fe56-42f8-82dd-703f63de7338@github.com>
 <NmoYY4GB6OfRbQJCX7kI7CZcxPKfekPwcwcdXAxpv8g=.62e25e6b-c2b7-4a7b-8906-4321d1dc4065@github.com>
Message-ID: <ecYORkwlibF7kExA9z2pO7Yb9itPjXhxV_4JZWxtIGU=.4d521175-853a-47d9-9e52-7fe2aca693cb@github.com>

On Mon, 5 Jan 2026 14:26:17 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> I don't have access to JBS yet. Could someone please create an issue for this PR?
>
> @youngledo Thanks for opening the PR! I've opened a jira ticket for you to use here: https://bugs.openjdk.org/browse/JMC-8489

@aptmac Hello, I have already modified the title of the "PR" as requested. What should I do next?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3721481336

From aptmac at openjdk.org  Thu Jan  8 14:27:23 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 8 Jan 2026 14:27:23 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <-xI06nVhm3OBf2JkpIRmbaTmyTDAyuLr4wVQC-Zkfgw=.9372be41-892a-44da-9a9b-55c17da58d72@github.com>

On Thu, 1 Jan 2026 15:25:25 GMT, Huang Xiao <duke at openjdk.org> wrote:

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

You should enable the GitHub workflows on your fork: https://github.com/youngledo/jmc/actions

Once enabled the CI runs should appear on this PR too. 

Other than that, this PR should be good to go I think.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3724108316

From duke at openjdk.org  Fri Jan  9 01:44:47 2026
From: duke at openjdk.org (Huang Xiao)
Date: Fri, 9 Jan 2026 01:44:47 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v2]
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <rqt22uezkXeFWAtQO1uq2FFQh_1b49rhHyPAmBDFao4=.be944d7c-3863-413c-b2dd-0a6fc6775f2c@github.com>

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

Huang Xiao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'openjdk:master' into translation
 - Inaccurate Chinese translations.

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/697/files
  - new: https://git.openjdk.org/jmc/pull/697/files/98ca1d7e..814a2a6f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=00-01

  Stats: 19 lines in 3 files changed: 13 ins; 3 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/697.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/697/head:pull/697

PR: https://git.openjdk.org/jmc/pull/697

From duke at openjdk.org  Fri Jan  9 01:50:40 2026
From: duke at openjdk.org (Huang Xiao)
Date: Fri, 9 Jan 2026 01:50:40 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v3]
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <A6UD4nZTz5iw2y68GwPXLpwOwoyz3v8uk132AasXnyI=.5ebfecff-0ed5-4801-a605-365268217278@github.com>

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

Huang Xiao has updated the pull request incrementally with one additional commit since the last revision:

  8489: Inaccurate Chinese translations.

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/697/files
  - new: https://git.openjdk.org/jmc/pull/697/files/814a2a6f..6faae7a4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=02
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/697.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/697/head:pull/697

PR: https://git.openjdk.org/jmc/pull/697

From duke at openjdk.org  Fri Jan  9 01:53:35 2026
From: duke at openjdk.org (Huang Xiao)
Date: Fri, 9 Jan 2026 01:53:35 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v4]
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <DpPOheMmL7E-C7TKz_udK4sPRGlkOtrHx55SFN957oU=.278a3f2d-b1a3-426b-a204-74c58d854384@github.com>

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

Huang Xiao has updated the pull request incrementally with one additional commit since the last revision:

  8489: Inaccurate Chinese translations(Update copyright year to 2026).

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/697/files
  - new: https://git.openjdk.org/jmc/pull/697/files/6faae7a4..eb0c6186

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=03
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=02-03

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/697.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/697/head:pull/697

PR: https://git.openjdk.org/jmc/pull/697

From aptmac at openjdk.org  Fri Jan  9 01:53:36 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 9 Jan 2026 01:53:36 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v2]
In-Reply-To: <rqt22uezkXeFWAtQO1uq2FFQh_1b49rhHyPAmBDFao4=.be944d7c-3863-413c-b2dd-0a6fc6775f2c@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <rqt22uezkXeFWAtQO1uq2FFQh_1b49rhHyPAmBDFao4=.be944d7c-3863-413c-b2dd-0a6fc6775f2c@github.com>
Message-ID: <1Pi-42bT84ItHWYiZdoXo-dutisYGPkYZXtDCSR-S-8=.27ecae8f-bf92-4ba0-a043-c2586ce7f275@github.com>

On Fri, 9 Jan 2026 01:44:47 GMT, Huang Xiao <duke at openjdk.org> wrote:

>> The translation of some column names is inaccurate:
>> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />
>
> Huang Xiao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into translation
>  - Inaccurate Chinese translations.

https://github.com/youngledo/jmc/actions/runs/20838309150/job/59867456583#step:3:29

Ah, the license headers on those files need to be updated to 2026

(Edit) just noticed you did that, excellent

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3726704866

From aptmac at openjdk.org  Fri Jan  9 02:08:54 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 9 Jan 2026 02:08:54 GMT
Subject: RFR: 8481: Update lz4-java to 1.10.2 [v5]
In-Reply-To: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
Message-ID: <4AsP_UtEDx60p8bty3VyKdxMUiaGJK6sGxt4ncIchp0=.80fa3f99-dd52-46df-8197-ea80e95ee42b@github.com>

> There's currently a security advisory open for the version of lz4-java we are using. lz4-java had been archived, but has been updated by a new maintainer with a fix for the security issue.
> 
> See: https://github.com/yawkat/lz4-java/security/advisories/GHSA-cmp6-m4wj-q63q

Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:

  fix version in platform definitions

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/694/files
  - new: https://git.openjdk.org/jmc/pull/694/files/bdd083f6..2cd87152

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=694&range=04
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=694&range=03-04

  Stats: 11 lines in 4 files changed: 0 ins; 0 del; 11 mod
  Patch: https://git.openjdk.org/jmc/pull/694.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/694/head:pull/694

PR: https://git.openjdk.org/jmc/pull/694

From duke at openjdk.org  Fri Jan  9 07:02:28 2026
From: duke at openjdk.org (Huang Xiao)
Date: Fri, 9 Jan 2026 07:02:28 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v2]
In-Reply-To: <1Pi-42bT84ItHWYiZdoXo-dutisYGPkYZXtDCSR-S-8=.27ecae8f-bf92-4ba0-a043-c2586ce7f275@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <rqt22uezkXeFWAtQO1uq2FFQh_1b49rhHyPAmBDFao4=.be944d7c-3863-413c-b2dd-0a6fc6775f2c@github.com>
 <1Pi-42bT84ItHWYiZdoXo-dutisYGPkYZXtDCSR-S-8=.27ecae8f-bf92-4ba0-a043-c2586ce7f275@github.com>
Message-ID: <SOq_jHfSYbpnTgrvdKerilOXJr-8bCPLwQ4dZuAtJuQ=.67ce4c8e-a6df-4708-8069-121d3c98b291@github.com>

On Fri, 9 Jan 2026 01:50:34 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Huang Xiao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into translation
>>  - Inaccurate Chinese translations.
>
> https://github.com/youngledo/jmc/actions/runs/20838309150/job/59867456583#step:3:29
> 
> Ah, the license headers on those files need to be updated to 2026
> 
> (Edit) just noticed you did that, excellent

@aptmac Thanks, completed.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3727476711

From aptmac at openjdk.org  Fri Jan  9 14:29:04 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 9 Jan 2026 14:29:04 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v4]
In-Reply-To: <DpPOheMmL7E-C7TKz_udK4sPRGlkOtrHx55SFN957oU=.278a3f2d-b1a3-426b-a204-74c58d854384@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <DpPOheMmL7E-C7TKz_udK4sPRGlkOtrHx55SFN957oU=.278a3f2d-b1a3-426b-a204-74c58d854384@github.com>
Message-ID: <VlPgJyGnMuLOE2poNaNhrxA36Tu6ic6A88b2HFiE8Sk=.503e8aad-f840-4041-81d5-97fb1c22a640@github.com>

On Fri, 9 Jan 2026 01:53:35 GMT, Huang Xiao <duke at openjdk.org> wrote:

>> The translation of some column names is inaccurate:
>> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />
>
> Huang Xiao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8489: Inaccurate Chinese translations(Update copyright year to 2026).

Great! The PR should be ready for your `/integrate` command, and then I can sponsor it afterwards.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3729123909

From aptmac at openjdk.org  Fri Jan  9 14:33:33 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 9 Jan 2026 14:33:33 GMT
Subject: RFR: 8481: Update lz4-java to 1.10.2 [v6]
In-Reply-To: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
Message-ID: <nbe3iV0-GU-CUhSjpMGc6LBuiyttExiIZAdVyxwlH_Q=.4e56d37c-b312-46c7-b7c7-27890b391b25@github.com>

> There's currently a security advisory open for the version of lz4-java we are using. lz4-java had been archived, but has been updated by a new maintainer with a fix for the security issue.
> 
> See: https://github.com/yawkat/lz4-java/security/advisories/GHSA-cmp6-m4wj-q63q

Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - fix version in platform definitions
 - update to 1.10.2
 - 8481: Update lz4-java to 1.10.1

-------------

Changes: https://git.openjdk.org/jmc/pull/694/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=694&range=05
  Stats: 17 lines in 8 files changed: 0 ins; 0 del; 17 mod
  Patch: https://git.openjdk.org/jmc/pull/694.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/694/head:pull/694

PR: https://git.openjdk.org/jmc/pull/694

From duke at openjdk.org  Fri Jan  9 14:46:06 2026
From: duke at openjdk.org (duke)
Date: Fri, 9 Jan 2026 14:46:06 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v4]
In-Reply-To: <DpPOheMmL7E-C7TKz_udK4sPRGlkOtrHx55SFN957oU=.278a3f2d-b1a3-426b-a204-74c58d854384@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <DpPOheMmL7E-C7TKz_udK4sPRGlkOtrHx55SFN957oU=.278a3f2d-b1a3-426b-a204-74c58d854384@github.com>
Message-ID: <sYBrUxxAUdr7nsMaJKaEYAeYcuIPGf15VPNsqAu5nOM=.2f8b5a69-b8cd-4605-9ae3-9fe4c4eed0da@github.com>

On Fri, 9 Jan 2026 01:53:35 GMT, Huang Xiao <duke at openjdk.org> wrote:

>> The translation of some column names is inaccurate:
>> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />
>
> Huang Xiao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8489: Inaccurate Chinese translations(Update copyright year to 2026).

@youngledo 
Your change (at version eb0c6186b3cfef03a3f2ed5ab9750f27b57e53eb) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3729197978

From duke at openjdk.org  Fri Jan  9 15:17:20 2026
From: duke at openjdk.org (Huang Xiao)
Date: Fri, 9 Jan 2026 15:17:20 GMT
Subject: Integrated: 8489: Inaccurate Chinese translations on TLAB page
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <_fJd-j33p7sdXNBNm4mbrYPqdwUSBZL1GEr7XZGknYU=.8d9de575-36fb-47bc-8ca8-0a87e2fcbf21@github.com>

On Thu, 1 Jan 2026 15:25:25 GMT, Huang Xiao <duke at openjdk.org> wrote:

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

This pull request has now been integrated.

Changeset: eb78a2d9
Author:    Huang Xiao <youngledo at qq.com>
Committer: Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/eb78a2d9d3cb39c2abb386d3524239186a2b0336
Stats:     14 lines in 2 files changed: 0 ins; 0 del; 14 mod

8489: Inaccurate Chinese translations on TLAB page

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/697

From aptmac at openjdk.org  Fri Jan  9 15:17:26 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 9 Jan 2026 15:17:26 GMT
Subject: RFR: 8481: Update lz4-java to 1.10.2 [v7]
In-Reply-To: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
Message-ID: <BdE5tmpFBhBii-CgKoq9zXHYRyGakPvG3tCZNuw9Wwg=.04b92811-5d8c-4ccc-8085-c642f9fcc891@github.com>

> There's currently a security advisory open for the version of lz4-java we are using. lz4-java had been archived, but has been updated by a new maintainer with a fix for the security issue.
> 
> See: https://github.com/yawkat/lz4-java/security/advisories/GHSA-cmp6-m4wj-q63q

Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:

  update missed license headers

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/694/files
  - new: https://git.openjdk.org/jmc/pull/694/files/fed802c2..1ddd237a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=694&range=06
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=694&range=05-06

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/694.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/694/head:pull/694

PR: https://git.openjdk.org/jmc/pull/694

From duke at openjdk.org  Mon Jan 12 10:04:27 2026
From: duke at openjdk.org (Huang Xiao)
Date: Mon, 12 Jan 2026 10:04:27 GMT
Subject: RFR: 8490: Include numeric types without Persister in
 "Add Filter from Attribute" menu
Message-ID: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>

### Problem

  Attributes with numeric ContentTypes that don't have a Persister (such as primitive types: byte, short, int, long, float, double, char) are
  excluded from the "Add Filter from Attribute" context menu in the Event Browser's filter editor.

#### Steps to reproduce:
  1. Open a JFR file containing events with primitive numeric fields (e.g., Spring Framework's FlightRecorderStartupEvent with long eventId and
  long parentId)
  2. In Event Browser, right-click on a column ? Select "Show Filter"
  3. Right-click on the filter area ? Select "Add Filter from Attribute"
  4. Expected: All filterable attributes should appear in the menu
  5. Actual: Primitive numeric type attributes are missing from the menu

<img width="2420" height="1362" alt="image" src="https://github.com/user-attachments/assets/70bcb795-7a7b-42f0-a83e-e34cb8e50361" />

#### Root Cause

  The getPersistableAttributes() method in DataPageToolkit.java (line 1006-1007) filters attributes based on whether their ContentType has a
  Persister:

  ```java
  .filter(a -> a.equals(JfrAttributes.EVENT_TYPE) || (a.getContentType() instanceof RangeContentType)
      || (a.getContentType().getPersister() != null))
  ```

  However, primitive numeric types use these ContentTypes which don't have a Persister:
  - UnitLookup.RAW_NUMBER - used by all primitive numeric types (byte, short, int, long, float, double, char)
  - UnitLookup.RAW_LONG - used by some custom Long attributes
  - UnitLookup.COUNT, UnitLookup.INDEX, UnitLookup.IDENTIFIER - legacy numeric types

  These types return null from getPersister() (see ContentType.java:99-101), causing them to be filtered out.

### Why this is incorrect:

  Even though these types cannot be persisted to strings, they fully support filtering via ItemFilters.equals(). Excluding them from the filter
  menu is inconsistent with their actual capabilities.

### Solution

  Add a helper method isFilterableNumericType() to identify numeric ContentTypes that support filtering even without a Persister, and include them
   in the filter:

private static boolean isFilterableNumericType(IAttribute<?> attribute) {
      org.openjdk.jmc.common.unit.ContentType<?> ct = attribute.getContentType();
      return ct.equals(UnitLookup.RAW_NUMBER) || ct.equals(UnitLookup.RAW_LONG)|| ct.equals(UnitLookup.COUNT) || ct.equals(UnitLookup.INDEX)
              || ct.equals(UnitLookup.IDENTIFIER);
  }


Update the filter condition to include these types:

  .filter(a -> a.equals(JfrAttributes.EVENT_TYPE)
      || (a.getContentType() instanceof RangeContentType)
      || (a.getContentType().getPersister() != null)
      || isFilterableNumericType(a))


### Testing

  Tested with Spring Framework's FlightRecorderStartupEvent which has primitive long fields:
  - Before fix: eventId and parentId attributes were missing from "Add Filter from Attribute" menu
  - After fix: All primitive numeric attributes appear correctly in the menu and filters work as expected

<img width="2928" height="1366" alt="453be33a-e65c-4fe2-9a84-a060afa99671" src="https://github.com/user-attachments/assets/5f3759e5-933e-4f7f-9e2c-d5b8372507f9" />

**Attachment**: [app.jfr.zip](https://github.com/user-attachments/files/24521734/app.jfr.zip)

**Related issues**: https://github.com/spring-projects/spring-framework/pull/36077#issuecomment-3722544246

-------------

Commit messages:
 - Fix: Include numeric types without Persister in "Add Filter from Attribute" menu(Apply Spotless formatting).
 - Fix: Include numeric types without Persister in "Add Filter from Attribute" menu(Update copyright year to 2026).
 - Fix: Include numeric types without Persister in "Add Filter from Attribute" menu.

Changes: https://git.openjdk.org/jmc/pull/699/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=699&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8490
  Stats: 23 lines in 2 files changed: 19 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jmc/pull/699.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/699/head:pull/699

PR: https://git.openjdk.org/jmc/pull/699

From aharmaz at openjdk.org  Mon Jan 12 10:04:29 2026
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Mon, 12 Jan 2026 10:04:29 GMT
Subject: RFR: 8490: Include numeric types without Persister in
 "Add Filter from Attribute" menu
In-Reply-To: <HvR9tXtuJNi3tKaxe97Al1-hwrASCglMXHALgwVEEns=.556767cf-fcaf-4d64-ae17-04fa38153acb@github.com>
References: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
 <HvR9tXtuJNi3tKaxe97Al1-hwrASCglMXHALgwVEEns=.556767cf-fcaf-4d64-ae17-04fa38153acb@github.com>
Message-ID: <MZ6MQEN5uHUtFm1JYKxijUmzMMty5ICnETU5FSsftDo=.bc24fa6e-cc32-45e7-8d3c-02ee5bd30964@github.com>

On Fri, 9 Jan 2026 07:06:55 GMT, Huang Xiao <duke at openjdk.org> wrote:

>> ### Problem
>> 
>>   Attributes with numeric ContentTypes that don't have a Persister (such as primitive types: byte, short, int, long, float, double, char) are
>>   excluded from the "Add Filter from Attribute" context menu in the Event Browser's filter editor.
>> 
>> #### Steps to reproduce:
>>   1. Open a JFR file containing events with primitive numeric fields (e.g., Spring Framework's FlightRecorderStartupEvent with long eventId and
>>   long parentId)
>>   2. In Event Browser, right-click on a column ? Select "Show Filter"
>>   3. Right-click on the filter area ? Select "Add Filter from Attribute"
>>   4. Expected: All filterable attributes should appear in the menu
>>   5. Actual: Primitive numeric type attributes are missing from the menu
>> 
>> <img width="2420" height="1362" alt="image" src="https://github.com/user-attachments/assets/70bcb795-7a7b-42f0-a83e-e34cb8e50361" />
>> 
>> #### Root Cause
>> 
>>   The getPersistableAttributes() method in DataPageToolkit.java (line 1006-1007) filters attributes based on whether their ContentType has a
>>   Persister:
>> 
>>   ```java
>>   .filter(a -> a.equals(JfrAttributes.EVENT_TYPE) || (a.getContentType() instanceof RangeContentType)
>>       || (a.getContentType().getPersister() != null))
>>   ```
>> 
>>   However, primitive numeric types use these ContentTypes which don't have a Persister:
>>   - UnitLookup.RAW_NUMBER - used by all primitive numeric types (byte, short, int, long, float, double, char)
>>   - UnitLookup.RAW_LONG - used by some custom Long attributes
>>   - UnitLookup.COUNT, UnitLookup.INDEX, UnitLookup.IDENTIFIER - legacy numeric types
>> 
>>   These types return null from getPersister() (see ContentType.java:99-101), causing them to be filtered out.
>> 
>> ### Why this is incorrect:
>> 
>>   Even though these types cannot be persisted to strings, they fully support filtering via ItemFilters.equals(). Excluding them from the filter
>>   menu is inconsistent with their actual capabilities.
>> 
>> ### Solution
>> 
>>   Add a helper method isFilterableNumericType() to identify numeric ContentTypes that support filtering even without a Persister, and include them
>>    in the filter:
>> 
>> private static boolean isFilterableNumericType(IAttribute<?> attribute) {
>>       org.openjdk.jmc.common.unit.ContentType<?> ct = attribute.getContentType();
>>       return ct.equals(UnitLookup.RAW_NUMBER) || ct.equals(UnitLookup.RAW_LONG)|| ct.equals(UnitLookup.COUNT) || ct.equals(UnitLookup.INDEX)
>>               || ct.equals(UnitLookup.IDEN...
>
> I don't have access to JBS yet. Could someone please create an issue for this PR?
> 
> @aymane-harmaz  Hello, Can you help me? 
> May I ask, what are the ways I can apply for this account?

@youngledo Thanks for opening this PR.

I have opened a JBS ticket for you here : https://bugs.openjdk.org/browse/JMC-8490

In order to obtain write access to JBS you need to have the Author role, You can find more information about the process and requirements here : https://openjdk.org/guide/#becoming-an-author

-------------

PR Comment: https://git.openjdk.org/jmc/pull/699#issuecomment-3737400035

From duke at openjdk.org  Mon Jan 12 10:04:28 2026
From: duke at openjdk.org (Huang Xiao)
Date: Mon, 12 Jan 2026 10:04:28 GMT
Subject: RFR: 8490: Include numeric types without Persister in
 "Add Filter from Attribute" menu
In-Reply-To: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
References: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
Message-ID: <HvR9tXtuJNi3tKaxe97Al1-hwrASCglMXHALgwVEEns=.556767cf-fcaf-4d64-ae17-04fa38153acb@github.com>

On Fri, 9 Jan 2026 07:04:09 GMT, Huang Xiao <duke at openjdk.org> wrote:

> ### Problem
> 
>   Attributes with numeric ContentTypes that don't have a Persister (such as primitive types: byte, short, int, long, float, double, char) are
>   excluded from the "Add Filter from Attribute" context menu in the Event Browser's filter editor.
> 
> #### Steps to reproduce:
>   1. Open a JFR file containing events with primitive numeric fields (e.g., Spring Framework's FlightRecorderStartupEvent with long eventId and
>   long parentId)
>   2. In Event Browser, right-click on a column ? Select "Show Filter"
>   3. Right-click on the filter area ? Select "Add Filter from Attribute"
>   4. Expected: All filterable attributes should appear in the menu
>   5. Actual: Primitive numeric type attributes are missing from the menu
> 
> <img width="2420" height="1362" alt="image" src="https://github.com/user-attachments/assets/70bcb795-7a7b-42f0-a83e-e34cb8e50361" />
> 
> #### Root Cause
> 
>   The getPersistableAttributes() method in DataPageToolkit.java (line 1006-1007) filters attributes based on whether their ContentType has a
>   Persister:
> 
>   ```java
>   .filter(a -> a.equals(JfrAttributes.EVENT_TYPE) || (a.getContentType() instanceof RangeContentType)
>       || (a.getContentType().getPersister() != null))
>   ```
> 
>   However, primitive numeric types use these ContentTypes which don't have a Persister:
>   - UnitLookup.RAW_NUMBER - used by all primitive numeric types (byte, short, int, long, float, double, char)
>   - UnitLookup.RAW_LONG - used by some custom Long attributes
>   - UnitLookup.COUNT, UnitLookup.INDEX, UnitLookup.IDENTIFIER - legacy numeric types
> 
>   These types return null from getPersister() (see ContentType.java:99-101), causing them to be filtered out.
> 
> ### Why this is incorrect:
> 
>   Even though these types cannot be persisted to strings, they fully support filtering via ItemFilters.equals(). Excluding them from the filter
>   menu is inconsistent with their actual capabilities.
> 
> ### Solution
> 
>   Add a helper method isFilterableNumericType() to identify numeric ContentTypes that support filtering even without a Persister, and include them
>    in the filter:
> 
> private static boolean isFilterableNumericType(IAttribute<?> attribute) {
>       org.openjdk.jmc.common.unit.ContentType<?> ct = attribute.getContentType();
>       return ct.equals(UnitLookup.RAW_NUMBER) || ct.equals(UnitLookup.RAW_LONG)|| ct.equals(UnitLookup.COUNT) || ct.equals(UnitLookup.INDEX)
>               || ct.equals(UnitLookup.IDENTIFIER);
>   }
> 
> 
> Update the filter condition to include these types:
> 
>   .filter(a -> a.equals(...

I don't have access to JBS yet. Could someone please create an issue for this PR?

@aymane-harmaz  Hello, Can you help me? 
May I ask, what are the ways I can apply for this account?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/699#issuecomment-3727492219