From aharmaz at openjdk.org  Sat Jan  3 00:17:11 2026
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Sat, 3 Jan 2026 00:17:11 GMT
Subject: Integrated: 8432: Better exception handling for Email Trigger failure
In-Reply-To: <YY8qdB8d1a5LvWjKd-xtG_jnFb5bF3Qk01BqGtbY_iQ=.d749ffad-8ec5-4544-a5b3-454f66fb244d@github.com>
References: <YY8qdB8d1a5LvWjKd-xtG_jnFb5bF3Qk01BqGtbY_iQ=.d749ffad-8ec5-4544-a5b3-454f66fb244d@github.com>
Message-ID: <YMl8jv2wlz-jNkqQIo9EHA_nMnPL58LvrhokVyD14TU=.846a4781-03b3-4494-91a0-3a95de74cd13@github.com>

On Mon, 8 Dec 2025 11:31:36 GMT, Aymane Harmaz <aharmaz at openjdk.org> wrote:

> This PR : 
> - Restructures the exception message displayed when the email send trigger fails, to show the root cause of the issue at the top before the trigger message
> - Increases the initial height of alert dialog for a better visibility
> 
> Alert dialog after the change : 
> 
> <img width="609" height="348" alt="Screenshot 2025-12-08 at 12 23 02" src="https://github.com/user-attachments/assets/0f933b11-4b46-44e3-89fa-377633ff7f8c" />

This pull request has now been integrated.

Changeset: 5778a3e0
Author:    Aymane Harmaz <aharmaz at openjdk.org>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/5778a3e0502237db43cb0aebd3fdf4062faa86f8
Stats:     19 lines in 3 files changed: 13 ins; 3 del; 3 mod

8432: Better exception handling for Email Trigger failure

Reviewed-by: hdafgard

-------------

PR: https://git.openjdk.org/jmc/pull/692

From aptmac at openjdk.org  Tue Jan  6 02:22:10 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 6 Jan 2026 02:22:10 GMT
Subject: RFR: 8489: Inaccurate Chinese translations.
In-Reply-To: <f7pBQb86jO04jkDcEmlwhRBesWkWNcOXGVeO3P0341Q=.a78ee52d-fe56-42f8-82dd-703f63de7338@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <f7pBQb86jO04jkDcEmlwhRBesWkWNcOXGVeO3P0341Q=.a78ee52d-fe56-42f8-82dd-703f63de7338@github.com>
Message-ID: <NmoYY4GB6OfRbQJCX7kI7CZcxPKfekPwcwcdXAxpv8g=.62e25e6b-c2b7-4a7b-8906-4321d1dc4065@github.com>

On Thu, 1 Jan 2026 15:37:49 GMT, Huang Xiao <duke at openjdk.org> wrote:

>> The translation of some column names is inaccurate:
>> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />
>
> I don't have access to JBS yet. Could someone please create an issue for this PR?

@youngledo Thanks for opening the PR! I've opened a jira ticket for you to use here: https://bugs.openjdk.org/browse/JMC-8489

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3710653329

From duke at openjdk.org  Tue Jan  6 02:22:09 2026
From: duke at openjdk.org (Huang Xiao)
Date: Tue, 6 Jan 2026 02:22:09 GMT
Subject: RFR: 8489: Inaccurate Chinese translations.
Message-ID: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>

The translation of some column names is inaccurate:
<img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

-------------

Commit messages:
 - Inaccurate Chinese translations.

Changes: https://git.openjdk.org/jmc/pull/697/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8489
  Stats: 12 lines in 2 files changed: 0 ins; 0 del; 12 mod
  Patch: https://git.openjdk.org/jmc/pull/697.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/697/head:pull/697

PR: https://git.openjdk.org/jmc/pull/697

From duke at openjdk.org  Tue Jan  6 02:22:10 2026
From: duke at openjdk.org (Huang Xiao)
Date: Tue, 6 Jan 2026 02:22:10 GMT
Subject: RFR: 8489: Inaccurate Chinese translations.
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <f7pBQb86jO04jkDcEmlwhRBesWkWNcOXGVeO3P0341Q=.a78ee52d-fe56-42f8-82dd-703f63de7338@github.com>

On Thu, 1 Jan 2026 15:25:25 GMT, Huang Xiao <duke at openjdk.org> wrote:

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

I don't have access to JBS yet. Could someone please create an issue for this PR?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3703833610

From duke at openjdk.org  Tue Jan  6 03:30:05 2026
From: duke at openjdk.org (Huang Xiao)
Date: Tue, 6 Jan 2026 03:30:05 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page
In-Reply-To: <f7pBQb86jO04jkDcEmlwhRBesWkWNcOXGVeO3P0341Q=.a78ee52d-fe56-42f8-82dd-703f63de7338@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <f7pBQb86jO04jkDcEmlwhRBesWkWNcOXGVeO3P0341Q=.a78ee52d-fe56-42f8-82dd-703f63de7338@github.com>
Message-ID: <4LaIHY3P0iXYShJNrNyT4L7bIjVIGnDdcnXNgeZTdMk=.8be0ca09-5012-42f6-b526-30a0577c15b5@github.com>

On Thu, 1 Jan 2026 15:37:49 GMT, Huang Xiao <duke at openjdk.org> wrote:

>> The translation of some column names is inaccurate:
>> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />
>
> I don't have access to JBS yet. Could someone please create an issue for this PR?

> @youngledo Thanks for opening the PR! I've opened a jira ticket for you to use here: https://bugs.openjdk.org/browse/JMC-8489

Thanks! Please continue to help me with code review.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3712962600

From schaturvedi at openjdk.org  Tue Jan  6 08:04:30 2026
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Tue, 6 Jan 2026 08:04:30 GMT
Subject: RFR: 8479: Update jolokia third party for JMC 10.0.0
In-Reply-To: <TEcElQah7utwYsji6uSBcAkZchMypgmD1Kr5oA-PGkc=.cc0f1478-6711-46c8-a015-b7d7fc4ea617@github.com>
References: <TEcElQah7utwYsji6uSBcAkZchMypgmD1Kr5oA-PGkc=.cc0f1478-6711-46c8-a015-b7d7fc4ea617@github.com>
Message-ID: <Cx_nUoxBHmPRkMKLZAsesS1KIREQq5pX72tWP3FC22I=.57a219c3-6593-4b57-8155-5e98effbac4b@github.com>

On Mon, 15 Dec 2025 21:20:45 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> Upgrade external jolokia dependencies 2.0.2 -> 2.4.2. There have been some name changes, that also require changes in JMC.

Looks good to me.

-------------

Marked as reviewed by schaturvedi (Committer).

PR Review: https://git.openjdk.org/jmc/pull/695#pullrequestreview-3629839439

From duke at openjdk.org  Tue Jan  6 12:27:32 2026
From: duke at openjdk.org (duke)
Date: Tue, 6 Jan 2026 12:27:32 GMT
Subject: RFR: 8479: Update jolokia third party for JMC 10.0.0
In-Reply-To: <TEcElQah7utwYsji6uSBcAkZchMypgmD1Kr5oA-PGkc=.cc0f1478-6711-46c8-a015-b7d7fc4ea617@github.com>
References: <TEcElQah7utwYsji6uSBcAkZchMypgmD1Kr5oA-PGkc=.cc0f1478-6711-46c8-a015-b7d7fc4ea617@github.com>
Message-ID: <xPilLVQCm0Im4It23Rb_zMBHBH5r-lw-eeD2_3DMfyo=.4d0d4215-f3d8-4644-a2af-0e350c76a793@github.com>

On Mon, 15 Dec 2025 21:20:45 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> Upgrade external jolokia dependencies 2.0.2 -> 2.4.2. There have been some name changes, that also require changes in JMC.

@skarsaune 
Your change (at version 327187415a7b4130d91ade34508d11b4cb2cc6f5) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/695#issuecomment-3714511368

From aptmac at openjdk.org  Tue Jan  6 15:16:11 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 6 Jan 2026 15:16:11 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <6vrFR7LupvSm0LGoudhYiFXUhc3E70kqv2fAy9NMEic=.b2a1de21-1a8b-4714-bea0-d32aa709b936@github.com>

On Thu, 1 Jan 2026 15:25:25 GMT, Huang Xiao <duke at openjdk.org> wrote:

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/697#pullrequestreview-3631282598

From aptmac at openjdk.org  Wed Jan  7 19:30:34 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 7 Jan 2026 19:30:34 GMT
Subject: RFR: 8476: Websocket server is tied to JfrEditor
Message-ID: <A6FmgeU8BxZdI8Z7adLM7k7Ig08no9HlOHRph5g3XaI=.656131b2-673a-45dd-b0cd-b8f1165321a5@github.com>

This PR addresses JMC-8476, in which the current websocket server implemention ties the server to a JfrEditor page.

At the moment, the Websocket server that is used to send selection data is created from within a JfrEditor page. So every time you open a new recording file, the JfrEditor code tries to start a new websocket server. This is a problem because there is only one field in the JMC settings to set the port number, and it is global to the application. So if I open recording-1, and then use the preferences menu to start the websocket server on port 8029, if I then open up recording-2 it will also try to open a websocket server on port 8029, and fail. As a result, sending data from recording-1 will work, but recording-2 will not (this can be seen in my "before" gif below).

I have extracted the websocket code out into it's own package and made it such that there is one server for the JMC application. So now if you toggle between recordings you can still send data to whatever application you want over websocket.

Before:
(exception thrown when trying to send events from the second recording)
![before](https://github.com/user-attachments/assets/8e9a3c97-f974-4409-99ea-6f86eb33e8cb)

After:
(selecting events from multiple recordings now works)
![after](https://github.com/user-attachments/assets/11ff55af-f691-4780-b504-adf4847be3e8)

-------------

Commit messages:
 - 8476: Websocket server is tied to JfrEditor

Changes: https://git.openjdk.org/jmc/pull/698/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=698&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8476
  Stats: 1154 lines in 23 files changed: 739 ins; 393 del; 22 mod
  Patch: https://git.openjdk.org/jmc/pull/698.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/698/head:pull/698

PR: https://git.openjdk.org/jmc/pull/698

From aptmac at openjdk.org  Wed Jan  7 19:39:49 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 7 Jan 2026 19:39:49 GMT
Subject: RFR: 8481: Update lz4-java to 1.10.2 [v4]
In-Reply-To: <N4Uae7vF_rOZcjCYDYhL-7aEM6ZKETXCZAiyLfGTXMg=.98cbddf2-9ac4-44fb-b6a9-d8e4dc67a5de@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
 <N4Uae7vF_rOZcjCYDYhL-7aEM6ZKETXCZAiyLfGTXMg=.98cbddf2-9ac4-44fb-b6a9-d8e4dc67a5de@github.com>
Message-ID: <rH7HolmtbPsDFqfnFZ4uOB2dYe1y1BnlFKUGBNI8Er0=.b5ba5334-2e18-4595-895f-01b91091e3b8@github.com>

On Tue, 16 Dec 2025 15:43:29 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> There's currently a security advisory open for the version of lz4-java we are using. lz4-java had been archived, but has been updated by a new maintainer with a fix for the security issue.
>> 
>> See: https://github.com/yawkat/lz4-java/security/advisories/GHSA-cmp6-m4wj-q63q
>
> Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update to 1.10.2

Gave this a test now that the 1.10.2 release is out, and it's working as expected now

-------------

PR Comment: https://git.openjdk.org/jmc/pull/694#issuecomment-3720458146

From duke at openjdk.org  Thu Jan  8 01:10:07 2026
From: duke at openjdk.org (Huang Xiao)
Date: Thu, 8 Jan 2026 01:10:07 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page
In-Reply-To: <NmoYY4GB6OfRbQJCX7kI7CZcxPKfekPwcwcdXAxpv8g=.62e25e6b-c2b7-4a7b-8906-4321d1dc4065@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <f7pBQb86jO04jkDcEmlwhRBesWkWNcOXGVeO3P0341Q=.a78ee52d-fe56-42f8-82dd-703f63de7338@github.com>
 <NmoYY4GB6OfRbQJCX7kI7CZcxPKfekPwcwcdXAxpv8g=.62e25e6b-c2b7-4a7b-8906-4321d1dc4065@github.com>
Message-ID: <ecYORkwlibF7kExA9z2pO7Yb9itPjXhxV_4JZWxtIGU=.4d521175-853a-47d9-9e52-7fe2aca693cb@github.com>

On Mon, 5 Jan 2026 14:26:17 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> I don't have access to JBS yet. Could someone please create an issue for this PR?
>
> @youngledo Thanks for opening the PR! I've opened a jira ticket for you to use here: https://bugs.openjdk.org/browse/JMC-8489

@aptmac Hello, I have already modified the title of the "PR" as requested. What should I do next?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3721481336

From aptmac at openjdk.org  Thu Jan  8 14:27:23 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 8 Jan 2026 14:27:23 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <-xI06nVhm3OBf2JkpIRmbaTmyTDAyuLr4wVQC-Zkfgw=.9372be41-892a-44da-9a9b-55c17da58d72@github.com>

On Thu, 1 Jan 2026 15:25:25 GMT, Huang Xiao <duke at openjdk.org> wrote:

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

You should enable the GitHub workflows on your fork: https://github.com/youngledo/jmc/actions

Once enabled the CI runs should appear on this PR too. 

Other than that, this PR should be good to go I think.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3724108316

From duke at openjdk.org  Fri Jan  9 01:44:47 2026
From: duke at openjdk.org (Huang Xiao)
Date: Fri, 9 Jan 2026 01:44:47 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v2]
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <rqt22uezkXeFWAtQO1uq2FFQh_1b49rhHyPAmBDFao4=.be944d7c-3863-413c-b2dd-0a6fc6775f2c@github.com>

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

Huang Xiao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'openjdk:master' into translation
 - Inaccurate Chinese translations.

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/697/files
  - new: https://git.openjdk.org/jmc/pull/697/files/98ca1d7e..814a2a6f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=00-01

  Stats: 19 lines in 3 files changed: 13 ins; 3 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/697.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/697/head:pull/697

PR: https://git.openjdk.org/jmc/pull/697

From duke at openjdk.org  Fri Jan  9 01:50:40 2026
From: duke at openjdk.org (Huang Xiao)
Date: Fri, 9 Jan 2026 01:50:40 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v3]
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <A6UD4nZTz5iw2y68GwPXLpwOwoyz3v8uk132AasXnyI=.5ebfecff-0ed5-4801-a605-365268217278@github.com>

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

Huang Xiao has updated the pull request incrementally with one additional commit since the last revision:

  8489: Inaccurate Chinese translations.

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/697/files
  - new: https://git.openjdk.org/jmc/pull/697/files/814a2a6f..6faae7a4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=02
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/697.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/697/head:pull/697

PR: https://git.openjdk.org/jmc/pull/697

From duke at openjdk.org  Fri Jan  9 01:53:35 2026
From: duke at openjdk.org (Huang Xiao)
Date: Fri, 9 Jan 2026 01:53:35 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v4]
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <DpPOheMmL7E-C7TKz_udK4sPRGlkOtrHx55SFN957oU=.278a3f2d-b1a3-426b-a204-74c58d854384@github.com>

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

Huang Xiao has updated the pull request incrementally with one additional commit since the last revision:

  8489: Inaccurate Chinese translations(Update copyright year to 2026).

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/697/files
  - new: https://git.openjdk.org/jmc/pull/697/files/6faae7a4..eb0c6186

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=03
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=697&range=02-03

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/697.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/697/head:pull/697

PR: https://git.openjdk.org/jmc/pull/697

From aptmac at openjdk.org  Fri Jan  9 01:53:36 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 9 Jan 2026 01:53:36 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v2]
In-Reply-To: <rqt22uezkXeFWAtQO1uq2FFQh_1b49rhHyPAmBDFao4=.be944d7c-3863-413c-b2dd-0a6fc6775f2c@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <rqt22uezkXeFWAtQO1uq2FFQh_1b49rhHyPAmBDFao4=.be944d7c-3863-413c-b2dd-0a6fc6775f2c@github.com>
Message-ID: <1Pi-42bT84ItHWYiZdoXo-dutisYGPkYZXtDCSR-S-8=.27ecae8f-bf92-4ba0-a043-c2586ce7f275@github.com>

On Fri, 9 Jan 2026 01:44:47 GMT, Huang Xiao <duke at openjdk.org> wrote:

>> The translation of some column names is inaccurate:
>> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />
>
> Huang Xiao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into translation
>  - Inaccurate Chinese translations.

https://github.com/youngledo/jmc/actions/runs/20838309150/job/59867456583#step:3:29

Ah, the license headers on those files need to be updated to 2026

(Edit) just noticed you did that, excellent

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3726704866

From aptmac at openjdk.org  Fri Jan  9 02:08:54 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 9 Jan 2026 02:08:54 GMT
Subject: RFR: 8481: Update lz4-java to 1.10.2 [v5]
In-Reply-To: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
Message-ID: <4AsP_UtEDx60p8bty3VyKdxMUiaGJK6sGxt4ncIchp0=.80fa3f99-dd52-46df-8197-ea80e95ee42b@github.com>

> There's currently a security advisory open for the version of lz4-java we are using. lz4-java had been archived, but has been updated by a new maintainer with a fix for the security issue.
> 
> See: https://github.com/yawkat/lz4-java/security/advisories/GHSA-cmp6-m4wj-q63q

Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:

  fix version in platform definitions

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/694/files
  - new: https://git.openjdk.org/jmc/pull/694/files/bdd083f6..2cd87152

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=694&range=04
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=694&range=03-04

  Stats: 11 lines in 4 files changed: 0 ins; 0 del; 11 mod
  Patch: https://git.openjdk.org/jmc/pull/694.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/694/head:pull/694

PR: https://git.openjdk.org/jmc/pull/694

From duke at openjdk.org  Fri Jan  9 07:02:28 2026
From: duke at openjdk.org (Huang Xiao)
Date: Fri, 9 Jan 2026 07:02:28 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v2]
In-Reply-To: <1Pi-42bT84ItHWYiZdoXo-dutisYGPkYZXtDCSR-S-8=.27ecae8f-bf92-4ba0-a043-c2586ce7f275@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <rqt22uezkXeFWAtQO1uq2FFQh_1b49rhHyPAmBDFao4=.be944d7c-3863-413c-b2dd-0a6fc6775f2c@github.com>
 <1Pi-42bT84ItHWYiZdoXo-dutisYGPkYZXtDCSR-S-8=.27ecae8f-bf92-4ba0-a043-c2586ce7f275@github.com>
Message-ID: <SOq_jHfSYbpnTgrvdKerilOXJr-8bCPLwQ4dZuAtJuQ=.67ce4c8e-a6df-4708-8069-121d3c98b291@github.com>

On Fri, 9 Jan 2026 01:50:34 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Huang Xiao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into translation
>>  - Inaccurate Chinese translations.
>
> https://github.com/youngledo/jmc/actions/runs/20838309150/job/59867456583#step:3:29
> 
> Ah, the license headers on those files need to be updated to 2026
> 
> (Edit) just noticed you did that, excellent

@aptmac Thanks, completed.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3727476711

From aptmac at openjdk.org  Fri Jan  9 14:29:04 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 9 Jan 2026 14:29:04 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v4]
In-Reply-To: <DpPOheMmL7E-C7TKz_udK4sPRGlkOtrHx55SFN957oU=.278a3f2d-b1a3-426b-a204-74c58d854384@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <DpPOheMmL7E-C7TKz_udK4sPRGlkOtrHx55SFN957oU=.278a3f2d-b1a3-426b-a204-74c58d854384@github.com>
Message-ID: <VlPgJyGnMuLOE2poNaNhrxA36Tu6ic6A88b2HFiE8Sk=.503e8aad-f840-4041-81d5-97fb1c22a640@github.com>

On Fri, 9 Jan 2026 01:53:35 GMT, Huang Xiao <duke at openjdk.org> wrote:

>> The translation of some column names is inaccurate:
>> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />
>
> Huang Xiao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8489: Inaccurate Chinese translations(Update copyright year to 2026).

Great! The PR should be ready for your `/integrate` command, and then I can sponsor it afterwards.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3729123909

From aptmac at openjdk.org  Fri Jan  9 14:33:33 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 9 Jan 2026 14:33:33 GMT
Subject: RFR: 8481: Update lz4-java to 1.10.2 [v6]
In-Reply-To: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
Message-ID: <nbe3iV0-GU-CUhSjpMGc6LBuiyttExiIZAdVyxwlH_Q=.4e56d37c-b312-46c7-b7c7-27890b391b25@github.com>

> There's currently a security advisory open for the version of lz4-java we are using. lz4-java had been archived, but has been updated by a new maintainer with a fix for the security issue.
> 
> See: https://github.com/yawkat/lz4-java/security/advisories/GHSA-cmp6-m4wj-q63q

Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - fix version in platform definitions
 - update to 1.10.2
 - 8481: Update lz4-java to 1.10.1

-------------

Changes: https://git.openjdk.org/jmc/pull/694/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=694&range=05
  Stats: 17 lines in 8 files changed: 0 ins; 0 del; 17 mod
  Patch: https://git.openjdk.org/jmc/pull/694.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/694/head:pull/694

PR: https://git.openjdk.org/jmc/pull/694

From duke at openjdk.org  Fri Jan  9 14:46:06 2026
From: duke at openjdk.org (duke)
Date: Fri, 9 Jan 2026 14:46:06 GMT
Subject: RFR: 8489: Inaccurate Chinese translations on TLAB page [v4]
In-Reply-To: <DpPOheMmL7E-C7TKz_udK4sPRGlkOtrHx55SFN957oU=.278a3f2d-b1a3-426b-a204-74c58d854384@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
 <DpPOheMmL7E-C7TKz_udK4sPRGlkOtrHx55SFN957oU=.278a3f2d-b1a3-426b-a204-74c58d854384@github.com>
Message-ID: <sYBrUxxAUdr7nsMaJKaEYAeYcuIPGf15VPNsqAu5nOM=.2f8b5a69-b8cd-4605-9ae3-9fe4c4eed0da@github.com>

On Fri, 9 Jan 2026 01:53:35 GMT, Huang Xiao <duke at openjdk.org> wrote:

>> The translation of some column names is inaccurate:
>> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />
>
> Huang Xiao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8489: Inaccurate Chinese translations(Update copyright year to 2026).

@youngledo 
Your change (at version eb0c6186b3cfef03a3f2ed5ab9750f27b57e53eb) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/697#issuecomment-3729197978

From duke at openjdk.org  Fri Jan  9 15:17:20 2026
From: duke at openjdk.org (Huang Xiao)
Date: Fri, 9 Jan 2026 15:17:20 GMT
Subject: Integrated: 8489: Inaccurate Chinese translations on TLAB page
In-Reply-To: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
References: <LjViNCGyr1OdSW_TXEgWqLsYRGXFzJOJ6vAp22rYgms=.0d1b6ede-ec74-4ac8-aaee-a5cac3178fc1@github.com>
Message-ID: <_fJd-j33p7sdXNBNm4mbrYPqdwUSBZL1GEr7XZGknYU=.8d9de575-36fb-47bc-8ca8-0a87e2fcbf21@github.com>

On Thu, 1 Jan 2026 15:25:25 GMT, Huang Xiao <duke at openjdk.org> wrote:

> The translation of some column names is inaccurate:
> <img width="2256" height="804" alt="ac4b982f45335662a154698b2c1c8027" src="https://github.com/user-attachments/assets/6e160e0e-3e6d-4067-9a89-d65cf27547b4" />

This pull request has now been integrated.

Changeset: eb78a2d9
Author:    Huang Xiao <youngledo at qq.com>
Committer: Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/eb78a2d9d3cb39c2abb386d3524239186a2b0336
Stats:     14 lines in 2 files changed: 0 ins; 0 del; 14 mod

8489: Inaccurate Chinese translations on TLAB page

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/697

From aptmac at openjdk.org  Fri Jan  9 15:17:26 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 9 Jan 2026 15:17:26 GMT
Subject: RFR: 8481: Update lz4-java to 1.10.2 [v7]
In-Reply-To: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
Message-ID: <BdE5tmpFBhBii-CgKoq9zXHYRyGakPvG3tCZNuw9Wwg=.04b92811-5d8c-4ccc-8085-c642f9fcc891@github.com>

> There's currently a security advisory open for the version of lz4-java we are using. lz4-java had been archived, but has been updated by a new maintainer with a fix for the security issue.
> 
> See: https://github.com/yawkat/lz4-java/security/advisories/GHSA-cmp6-m4wj-q63q

Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:

  update missed license headers

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/694/files
  - new: https://git.openjdk.org/jmc/pull/694/files/fed802c2..1ddd237a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=694&range=06
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=694&range=05-06

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/694.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/694/head:pull/694

PR: https://git.openjdk.org/jmc/pull/694

From duke at openjdk.org  Mon Jan 12 10:04:27 2026
From: duke at openjdk.org (Huang Xiao)
Date: Mon, 12 Jan 2026 10:04:27 GMT
Subject: RFR: 8490: Include numeric types without Persister in
 "Add Filter from Attribute" menu
Message-ID: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>

### Problem

  Attributes with numeric ContentTypes that don't have a Persister (such as primitive types: byte, short, int, long, float, double, char) are
  excluded from the "Add Filter from Attribute" context menu in the Event Browser's filter editor.

#### Steps to reproduce:
  1. Open a JFR file containing events with primitive numeric fields (e.g., Spring Framework's FlightRecorderStartupEvent with long eventId and
  long parentId)
  2. In Event Browser, right-click on a column ? Select "Show Filter"
  3. Right-click on the filter area ? Select "Add Filter from Attribute"
  4. Expected: All filterable attributes should appear in the menu
  5. Actual: Primitive numeric type attributes are missing from the menu

<img width="2420" height="1362" alt="image" src="https://github.com/user-attachments/assets/70bcb795-7a7b-42f0-a83e-e34cb8e50361" />

#### Root Cause

  The getPersistableAttributes() method in DataPageToolkit.java (line 1006-1007) filters attributes based on whether their ContentType has a
  Persister:

  ```java
  .filter(a -> a.equals(JfrAttributes.EVENT_TYPE) || (a.getContentType() instanceof RangeContentType)
      || (a.getContentType().getPersister() != null))
  ```

  However, primitive numeric types use these ContentTypes which don't have a Persister:
  - UnitLookup.RAW_NUMBER - used by all primitive numeric types (byte, short, int, long, float, double, char)
  - UnitLookup.RAW_LONG - used by some custom Long attributes
  - UnitLookup.COUNT, UnitLookup.INDEX, UnitLookup.IDENTIFIER - legacy numeric types

  These types return null from getPersister() (see ContentType.java:99-101), causing them to be filtered out.

### Why this is incorrect:

  Even though these types cannot be persisted to strings, they fully support filtering via ItemFilters.equals(). Excluding them from the filter
  menu is inconsistent with their actual capabilities.

### Solution

  Add a helper method isFilterableNumericType() to identify numeric ContentTypes that support filtering even without a Persister, and include them
   in the filter:

private static boolean isFilterableNumericType(IAttribute<?> attribute) {
      org.openjdk.jmc.common.unit.ContentType<?> ct = attribute.getContentType();
      return ct.equals(UnitLookup.RAW_NUMBER) || ct.equals(UnitLookup.RAW_LONG)|| ct.equals(UnitLookup.COUNT) || ct.equals(UnitLookup.INDEX)
              || ct.equals(UnitLookup.IDENTIFIER);
  }


Update the filter condition to include these types:

  .filter(a -> a.equals(JfrAttributes.EVENT_TYPE)
      || (a.getContentType() instanceof RangeContentType)
      || (a.getContentType().getPersister() != null)
      || isFilterableNumericType(a))


### Testing

  Tested with Spring Framework's FlightRecorderStartupEvent which has primitive long fields:
  - Before fix: eventId and parentId attributes were missing from "Add Filter from Attribute" menu
  - After fix: All primitive numeric attributes appear correctly in the menu and filters work as expected

<img width="2928" height="1366" alt="453be33a-e65c-4fe2-9a84-a060afa99671" src="https://github.com/user-attachments/assets/5f3759e5-933e-4f7f-9e2c-d5b8372507f9" />

**Attachment**: [app.jfr.zip](https://github.com/user-attachments/files/24521734/app.jfr.zip)

**Related issues**: https://github.com/spring-projects/spring-framework/pull/36077#issuecomment-3722544246

-------------

Commit messages:
 - Fix: Include numeric types without Persister in "Add Filter from Attribute" menu(Apply Spotless formatting).
 - Fix: Include numeric types without Persister in "Add Filter from Attribute" menu(Update copyright year to 2026).
 - Fix: Include numeric types without Persister in "Add Filter from Attribute" menu.

Changes: https://git.openjdk.org/jmc/pull/699/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=699&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8490
  Stats: 23 lines in 2 files changed: 19 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jmc/pull/699.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/699/head:pull/699

PR: https://git.openjdk.org/jmc/pull/699

From aharmaz at openjdk.org  Mon Jan 12 10:04:29 2026
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Mon, 12 Jan 2026 10:04:29 GMT
Subject: RFR: 8490: Include numeric types without Persister in
 "Add Filter from Attribute" menu
In-Reply-To: <HvR9tXtuJNi3tKaxe97Al1-hwrASCglMXHALgwVEEns=.556767cf-fcaf-4d64-ae17-04fa38153acb@github.com>
References: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
 <HvR9tXtuJNi3tKaxe97Al1-hwrASCglMXHALgwVEEns=.556767cf-fcaf-4d64-ae17-04fa38153acb@github.com>
Message-ID: <MZ6MQEN5uHUtFm1JYKxijUmzMMty5ICnETU5FSsftDo=.bc24fa6e-cc32-45e7-8d3c-02ee5bd30964@github.com>

On Fri, 9 Jan 2026 07:06:55 GMT, Huang Xiao <duke at openjdk.org> wrote:

>> ### Problem
>> 
>>   Attributes with numeric ContentTypes that don't have a Persister (such as primitive types: byte, short, int, long, float, double, char) are
>>   excluded from the "Add Filter from Attribute" context menu in the Event Browser's filter editor.
>> 
>> #### Steps to reproduce:
>>   1. Open a JFR file containing events with primitive numeric fields (e.g., Spring Framework's FlightRecorderStartupEvent with long eventId and
>>   long parentId)
>>   2. In Event Browser, right-click on a column ? Select "Show Filter"
>>   3. Right-click on the filter area ? Select "Add Filter from Attribute"
>>   4. Expected: All filterable attributes should appear in the menu
>>   5. Actual: Primitive numeric type attributes are missing from the menu
>> 
>> <img width="2420" height="1362" alt="image" src="https://github.com/user-attachments/assets/70bcb795-7a7b-42f0-a83e-e34cb8e50361" />
>> 
>> #### Root Cause
>> 
>>   The getPersistableAttributes() method in DataPageToolkit.java (line 1006-1007) filters attributes based on whether their ContentType has a
>>   Persister:
>> 
>>   ```java
>>   .filter(a -> a.equals(JfrAttributes.EVENT_TYPE) || (a.getContentType() instanceof RangeContentType)
>>       || (a.getContentType().getPersister() != null))
>>   ```
>> 
>>   However, primitive numeric types use these ContentTypes which don't have a Persister:
>>   - UnitLookup.RAW_NUMBER - used by all primitive numeric types (byte, short, int, long, float, double, char)
>>   - UnitLookup.RAW_LONG - used by some custom Long attributes
>>   - UnitLookup.COUNT, UnitLookup.INDEX, UnitLookup.IDENTIFIER - legacy numeric types
>> 
>>   These types return null from getPersister() (see ContentType.java:99-101), causing them to be filtered out.
>> 
>> ### Why this is incorrect:
>> 
>>   Even though these types cannot be persisted to strings, they fully support filtering via ItemFilters.equals(). Excluding them from the filter
>>   menu is inconsistent with their actual capabilities.
>> 
>> ### Solution
>> 
>>   Add a helper method isFilterableNumericType() to identify numeric ContentTypes that support filtering even without a Persister, and include them
>>    in the filter:
>> 
>> private static boolean isFilterableNumericType(IAttribute<?> attribute) {
>>       org.openjdk.jmc.common.unit.ContentType<?> ct = attribute.getContentType();
>>       return ct.equals(UnitLookup.RAW_NUMBER) || ct.equals(UnitLookup.RAW_LONG)|| ct.equals(UnitLookup.COUNT) || ct.equals(UnitLookup.INDEX)
>>               || ct.equals(UnitLookup.IDEN...
>
> I don't have access to JBS yet. Could someone please create an issue for this PR?
> 
> @aymane-harmaz  Hello, Can you help me? 
> May I ask, what are the ways I can apply for this account?

@youngledo Thanks for opening this PR.

I have opened a JBS ticket for you here : https://bugs.openjdk.org/browse/JMC-8490

In order to obtain write access to JBS you need to have the Author role, You can find more information about the process and requirements here : https://openjdk.org/guide/#becoming-an-author

-------------

PR Comment: https://git.openjdk.org/jmc/pull/699#issuecomment-3737400035

From duke at openjdk.org  Mon Jan 12 10:04:28 2026
From: duke at openjdk.org (Huang Xiao)
Date: Mon, 12 Jan 2026 10:04:28 GMT
Subject: RFR: 8490: Include numeric types without Persister in
 "Add Filter from Attribute" menu
In-Reply-To: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
References: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
Message-ID: <HvR9tXtuJNi3tKaxe97Al1-hwrASCglMXHALgwVEEns=.556767cf-fcaf-4d64-ae17-04fa38153acb@github.com>

On Fri, 9 Jan 2026 07:04:09 GMT, Huang Xiao <duke at openjdk.org> wrote:

> ### Problem
> 
>   Attributes with numeric ContentTypes that don't have a Persister (such as primitive types: byte, short, int, long, float, double, char) are
>   excluded from the "Add Filter from Attribute" context menu in the Event Browser's filter editor.
> 
> #### Steps to reproduce:
>   1. Open a JFR file containing events with primitive numeric fields (e.g., Spring Framework's FlightRecorderStartupEvent with long eventId and
>   long parentId)
>   2. In Event Browser, right-click on a column ? Select "Show Filter"
>   3. Right-click on the filter area ? Select "Add Filter from Attribute"
>   4. Expected: All filterable attributes should appear in the menu
>   5. Actual: Primitive numeric type attributes are missing from the menu
> 
> <img width="2420" height="1362" alt="image" src="https://github.com/user-attachments/assets/70bcb795-7a7b-42f0-a83e-e34cb8e50361" />
> 
> #### Root Cause
> 
>   The getPersistableAttributes() method in DataPageToolkit.java (line 1006-1007) filters attributes based on whether their ContentType has a
>   Persister:
> 
>   ```java
>   .filter(a -> a.equals(JfrAttributes.EVENT_TYPE) || (a.getContentType() instanceof RangeContentType)
>       || (a.getContentType().getPersister() != null))
>   ```
> 
>   However, primitive numeric types use these ContentTypes which don't have a Persister:
>   - UnitLookup.RAW_NUMBER - used by all primitive numeric types (byte, short, int, long, float, double, char)
>   - UnitLookup.RAW_LONG - used by some custom Long attributes
>   - UnitLookup.COUNT, UnitLookup.INDEX, UnitLookup.IDENTIFIER - legacy numeric types
> 
>   These types return null from getPersister() (see ContentType.java:99-101), causing them to be filtered out.
> 
> ### Why this is incorrect:
> 
>   Even though these types cannot be persisted to strings, they fully support filtering via ItemFilters.equals(). Excluding them from the filter
>   menu is inconsistent with their actual capabilities.
> 
> ### Solution
> 
>   Add a helper method isFilterableNumericType() to identify numeric ContentTypes that support filtering even without a Persister, and include them
>    in the filter:
> 
> private static boolean isFilterableNumericType(IAttribute<?> attribute) {
>       org.openjdk.jmc.common.unit.ContentType<?> ct = attribute.getContentType();
>       return ct.equals(UnitLookup.RAW_NUMBER) || ct.equals(UnitLookup.RAW_LONG)|| ct.equals(UnitLookup.COUNT) || ct.equals(UnitLookup.INDEX)
>               || ct.equals(UnitLookup.IDENTIFIER);
>   }
> 
> 
> Update the filter condition to include these types:
> 
>   .filter(a -> a.equals(...

I don't have access to JBS yet. Could someone please create an issue for this PR?

@aymane-harmaz  Hello, Can you help me? 
May I ask, what are the ways I can apply for this account?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/699#issuecomment-3727492219

From jbachorik at openjdk.org  Thu Jan 15 11:27:56 2026
From: jbachorik at openjdk.org (Jaroslav Bachorik)
Date: Thu, 15 Jan 2026 11:27:56 GMT
Subject: RFR: 8475: Writing events with fields not explicitly set can
 corrupt the recording [v2]
In-Reply-To: <HZ3o6BzgwA-V8iI4ra5tOvWEw8EKc2M4wdD3rUKGZz0=.173b7bd1-22a2-4611-827e-c9066010febc@github.com>
References: <pu1GsrnjX-UVUD6Pr_SumH9KEe2bXbKMtNEjW8YWuEo=.79e00cb5-3b0f-4d3b-bd92-cba42bf8429d@github.com>
 <HZ3o6BzgwA-V8iI4ra5tOvWEw8EKc2M4wdD3rUKGZz0=.173b7bd1-22a2-4611-827e-c9066010febc@github.com>
Message-ID: <Mjof3DmwowBlLN16l9skv0HVHSj6vVdcPVPKY37AnlY=.324ac87b-d370-405b-9668-0fa3dd3615fc@github.com>

On Wed, 3 Dec 2025 16:24:51 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> ## Summary
>> Fixes an issue where events written with builtin type fields that are not explicitly set could cause field misalignment during JFR recording parsing, leading to corrupted field values.
>> 
>> ## Problem
>> When writing JFR events using the Writer API without explicitly setting values for builtin type fields (byte, char, short, int, long, float, double, boolean, string), the previous implementation in `Chunk.writeBuiltinType()` would skip writing null builtin values (except for strings). This caused field alignment issues during parsing, where subsequent field values would be read at incorrect offsets.
>> 
>> ## Solution
>> Modified `Chunk.writeBuiltinType()` (lines 88-150) to write appropriate default values for null builtin types instead of skipping them:
>> - Numeric types (byte, char, short, int, long, float, double): Write `0`
>> - Boolean: Write `false`  
>> - String: Continue to write null encoding (existing behavior)
>> 
>> Additionally enhanced `TypedValueImpl.getDefaultImplicitFieldValue()` to provide `System.nanoTime()` as default for `@Timestamp` annotated fields in event types, ensuring valid monotonic timestamps.
>> 
>> ## Testing
>> Added comprehensive test `ImplicitEventFieldsTest.eventWithAllBuiltinFieldsUnset()` that:
>> - Creates an event with all 9 builtin type fields
>> - Writes the event without setting any builtin field values
>> - Includes a final field with an explicit value (99999L) to verify alignment
>> - Verifies all default values are correct and the explicit field reads back correctly
>> 
>> All 277 existing tests pass with the changes.
>> 
>> ## Files Changed
>> - `Chunk.java`: Fixed builtin type serialization to write defaults instead of skipping
>> - `TypedValueImpl.java`: Enhanced default value handling for timestamp fields
>> - `ImplicitEventFieldsTest.java`: Added comprehensive test for builtin defaults
>> - `Type.java`, `TypedValueBuilder.java`: Enhanced documentation
>> 
>> Fixes #8475
>> 
>> ? Generated with [Claude Code](https://claude.com/claude-code)
>
> Jaroslav Bachorik has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8475: Writing events with fields not explicitly set can corrupt the recording

gentle ping?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/690#issuecomment-3754262373

From aharmaz at openjdk.org  Mon Jan 19 18:34:21 2026
From: aharmaz at openjdk.org (Aymane Harmaz)
Date: Mon, 19 Jan 2026 18:34:21 GMT
Subject: RFR: 6832: Should allow plotting line charts for all quantities
 [v2]
In-Reply-To: <iOjydd_VWy1O-7YOp24id9trousaAKK_WzY0lzVbmT8=.2e2acd01-b1c9-4237-82e7-2f6341f32438@github.com>
References: <iOjydd_VWy1O-7YOp24id9trousaAKK_WzY0lzVbmT8=.2e2acd01-b1c9-4237-82e7-2f6341f32438@github.com>
Message-ID: <BqDJDZzLzuW_ZBdL5hVr9Kt_3lIHp2HOvKZ_6EBXER4=.e1499d82-4a01-49a3-bd2a-5ce18c5375d3@github.com>

> This PR makes sure line charts cover all the events across multiple IItemIterables, and makes it possible for linear quantities to be represented as line charts on custom pages.

Aymane Harmaz has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - update copyright year in AttributeComponentConfiguration
 - implemented merge sorting of items from multiple chunks
 - 6832: Should allow plotting line charts for all quantities

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/688/files
  - new: https://git.openjdk.org/jmc/pull/688/files/5b5654df..4e2ff3f4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=688&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=688&range=00-01

  Stats: 868 lines in 46 files changed: 489 ins; 281 del; 98 mod
  Patch: https://git.openjdk.org/jmc/pull/688.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/688/head:pull/688

PR: https://git.openjdk.org/jmc/pull/688

From jbechberger at openjdk.org  Thu Jan 22 08:37:53 2026
From: jbechberger at openjdk.org (Johannes Bechberger)
Date: Thu, 22 Jan 2026 08:37:53 GMT
Subject: RFR: 8481: Update lz4-java to 1.10.2 [v7]
In-Reply-To: <BdE5tmpFBhBii-CgKoq9zXHYRyGakPvG3tCZNuw9Wwg=.04b92811-5d8c-4ccc-8085-c642f9fcc891@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
 <BdE5tmpFBhBii-CgKoq9zXHYRyGakPvG3tCZNuw9Wwg=.04b92811-5d8c-4ccc-8085-c642f9fcc891@github.com>
Message-ID: <LehQg0QrHEQSZv0XfTDEypQsT8dTFrQToMyTZw1yATY=.ba81c9a7-4a69-4945-b23c-f385b3546d40@github.com>

On Fri, 9 Jan 2026 15:17:26 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> There's currently a security advisory open for the version of lz4-java we are using. lz4-java had been archived, but has been updated by a new maintainer with a fix for the security issue.
>> 
>> See: https://github.com/yawkat/lz4-java/security/advisories/GHSA-cmp6-m4wj-q63q
>
> Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update missed license headers

Could we merge this soon?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/694#issuecomment-3783180820

From aptmac at openjdk.org  Thu Jan 22 14:16:54 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 22 Jan 2026 14:16:54 GMT
Subject: RFR: 8481: Update lz4-java to 1.10.2 [v7]
In-Reply-To: <LehQg0QrHEQSZv0XfTDEypQsT8dTFrQToMyTZw1yATY=.ba81c9a7-4a69-4945-b23c-f385b3546d40@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
 <BdE5tmpFBhBii-CgKoq9zXHYRyGakPvG3tCZNuw9Wwg=.04b92811-5d8c-4ccc-8085-c642f9fcc891@github.com>
 <LehQg0QrHEQSZv0XfTDEypQsT8dTFrQToMyTZw1yATY=.ba81c9a7-4a69-4945-b23c-f385b3546d40@github.com>
Message-ID: <kiPWn7ggrKlqeBwIMKSI3KtYdMrZxNErbLbhCPtwpDo=.09d492fd-3aea-44a1-aa61-770eda675042@github.com>

On Thu, 22 Jan 2026 08:34:41 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:

> Could we merge this soon?

Yeah, but it needs a review first

-------------

PR Comment: https://git.openjdk.org/jmc/pull/694#issuecomment-3784622361

From jbechberger at openjdk.org  Thu Jan 22 14:16:56 2026
From: jbechberger at openjdk.org (Johannes Bechberger)
Date: Thu, 22 Jan 2026 14:16:56 GMT
Subject: RFR: 8481: Update lz4-java to 1.10.2 [v7]
In-Reply-To: <BdE5tmpFBhBii-CgKoq9zXHYRyGakPvG3tCZNuw9Wwg=.04b92811-5d8c-4ccc-8085-c642f9fcc891@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
 <BdE5tmpFBhBii-CgKoq9zXHYRyGakPvG3tCZNuw9Wwg=.04b92811-5d8c-4ccc-8085-c642f9fcc891@github.com>
Message-ID: <jZM0BQj_JTmH8mTwALQuCdt6Io4ZYVQoVL5zFBcMuYo=.9ce8756c-156e-40c8-bea9-a4532feaadc4@github.com>

On Fri, 9 Jan 2026 15:17:26 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> There's currently a security advisory open for the version of lz4-java we are using. lz4-java had been archived, but has been updated by a new maintainer with a fix for the security issue.
>> 
>> See: https://github.com/yawkat/lz4-java/security/advisories/GHSA-cmp6-m4wj-q63q
>
> Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update missed license headers

Sorry, I mistook it for another PR.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/694#issuecomment-3784627424

From aptmac at openjdk.org  Thu Jan 22 18:59:04 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 22 Jan 2026 18:59:04 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy [v5]
In-Reply-To: <AZemjrScwDLTC8Ou195m7g3N2aePKWH1khjLVOQgCb8=.d0daaa31-18a6-4980-a1c1-ae1864169dff@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
 <AZemjrScwDLTC8Ou195m7g3N2aePKWH1khjLVOQgCb8=.d0daaa31-18a6-4980-a1c1-ae1864169dff@github.com>
Message-ID: <R-6m6tSM2_9MU0kTK6CLs4UQdm9aJC7jU_rkdVz2A6k=.ffbcc67c-48fb-4101-8e6b-9f25c6b83976@github.com>

On Sun, 12 Oct 2025 18:35:12 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
>> 
>> Testing connectivity:
>> - [x]  Docker desktop kubernetes 
>> - [x]  Azure AKS
>> - [x]  Amazon EKS
>> - [x]  Google GKE
>> 
>> Other things observed:
>> 
>> - [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
>> - [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
>> - [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
>> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
>> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
>> - [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:
> 
>  - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
>  - JMC-8237: Upgrade jolokia 2.2.2 -> 2.2.9
>  - JMC-8237: Upgrade jolokia 2.2.2 -> 2.2.9
>  - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
>  - JMC-8237: Removed dead assignment
>  - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
>  - JMC-8237: Remove unneeded changes
>  - JMC-8237: Updated bundle version to 10.0.0. Updated copyright year
>  - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
>  - JMC-8237: Upgrade to jolokia 2.2.2
>  - ... and 19 more: https://git.openjdk.org/jmc/compare/58ca84a3...2fed8612

Finally got around to giving this PR a test, and it's looking good from what I've done so far.

Code-wise it looks good, from a formatting standpoint there's some inconsistency in using new lines with comments, I'll point some out.

I think this is ready for re-testing, the licenses will just need to be updated to be 2026, and potentially the dependencies updated along with rebasing ontop of main.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaPlugin.java line 78:

> 76: 		JolokiaServiceManager serviceManager = JolokiaServiceManagerFactory.createJolokiaServiceManager(configuration,
> 77: 				new JulLogHandler(PLUGIN_ID), new AllowAllRestrictor(),
> 78: 				logHandleer -> new TreeSet<ServerDetector>(Arrays.asList(ServerDetector.FALLBACK)));

typo, should be "logHandler"

application/org.openjdk.jmc.kubernetes/OSGI-INF/l10n/bundle.properties line 3:

> 1: #Properties file for org.openjdk.jmc.kubernetes
> 2: page.name = Kubernetes
> 3: Bundle-Name = Kubernetes JMC extensions

newline at the end of the file

application/org.openjdk.jmc.kubernetes/src/main/java/org/openjdk/jmc/kubernetes/JmcKubernetesJmxConnection.java line 65:

> 63: 	protected J4pResponse unwrapException(J4pException e) throws IOException, InstanceNotFoundException {
> 64: 		// recognize signs of disconnect and signal to the application for better
> 65: 		// handling

could the comment be one line?

application/org.openjdk.jmc.kubernetes/src/main/java/org/openjdk/jmc/kubernetes/JmcKubernetesPlugin.java line 86:

> 84: 	public boolean scanForInstances() {
> 85: 		// If credentials are locked and credentials are required, the scanner thread
> 86: 		// will get hung

this comment could probably be one line less too?

application/org.openjdk.jmc.kubernetes/src/main/java/org/openjdk/jmc/kubernetes/KubernetesDiscoveryListener.java line 121:

> 119: 		File configPath = new File(path);
> 120: 		if (contexts != null && contextsCached > configPath.lastModified()) {// the YAML parsing is soo incredibly
> 121: 																				// sloow, hence cache context names for

the comments here could be moved to fit onto a single line?

-------------

PR Review: https://git.openjdk.org/jmc/pull/576#pullrequestreview-3694033387
PR Review Comment: https://git.openjdk.org/jmc/pull/576#discussion_r2718180498
PR Review Comment: https://git.openjdk.org/jmc/pull/576#discussion_r2718181516
PR Review Comment: https://git.openjdk.org/jmc/pull/576#discussion_r2718184376
PR Review Comment: https://git.openjdk.org/jmc/pull/576#discussion_r2718185412
PR Review Comment: https://git.openjdk.org/jmc/pull/576#discussion_r2718186401

From duke at openjdk.org  Thu Jan 22 20:59:40 2026
From: duke at openjdk.org (Martin Skarsaune)
Date: Thu, 22 Jan 2026 20:59:40 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy [v5]
In-Reply-To: <R-6m6tSM2_9MU0kTK6CLs4UQdm9aJC7jU_rkdVz2A6k=.ffbcc67c-48fb-4101-8e6b-9f25c6b83976@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
 <AZemjrScwDLTC8Ou195m7g3N2aePKWH1khjLVOQgCb8=.d0daaa31-18a6-4980-a1c1-ae1864169dff@github.com>
 <R-6m6tSM2_9MU0kTK6CLs4UQdm9aJC7jU_rkdVz2A6k=.ffbcc67c-48fb-4101-8e6b-9f25c6b83976@github.com>
Message-ID: <wpMy51i1pLMiwfJhtWdWHdQgFoX7pMhzB4uinrKlTmU=.8398171f-af9d-48a5-bd56-2011d8583edb@github.com>

On Thu, 22 Jan 2026 18:56:35 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> Finally got around to giving this PR a test, and it's looking good from what I've done so far.
> 
> Code-wise it looks good, from a formatting standpoint there's some inconsistency in using new lines with comments, I'll point some out.
> 
> I think this is ready for re-testing, the licenses will just need to be updated to be 2026, and potentially the dependencies updated along with rebasing ontop of main.

Yeah, it has been stable for a bit. I will fix the formatting. I have to merge/rebase and retest everything once https://github.com/openjdk/jmc/pull/695 is merged.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/576#issuecomment-3786652255

From duke at openjdk.org  Thu Jan 22 21:21:54 2026
From: duke at openjdk.org (Martin Skarsaune)
Date: Thu, 22 Jan 2026 21:21:54 GMT
Subject: Integrated: 8479: Update jolokia third party for JMC 10.0.0
In-Reply-To: <TEcElQah7utwYsji6uSBcAkZchMypgmD1Kr5oA-PGkc=.cc0f1478-6711-46c8-a015-b7d7fc4ea617@github.com>
References: <TEcElQah7utwYsji6uSBcAkZchMypgmD1Kr5oA-PGkc=.cc0f1478-6711-46c8-a015-b7d7fc4ea617@github.com>
Message-ID: <RFRFQfiCugCztB8aysQz7gQGqxLmU73XQznCOGT5RzM=.d5bd591a-b7bb-40e1-acf2-75801f2f5ec5@github.com>

On Mon, 15 Dec 2025 21:20:45 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> Upgrade external jolokia dependencies 2.0.2 -> 2.4.2. There have been some name changes, that also require changes in JMC.

This pull request has now been integrated.

Changeset: 3f115945
Author:    Martin Skarsaune <martin at skarsaune.net>
Committer: Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/3f11594584cd62ee2a7e1a18a2e9b6e7cd8c048a
Stats:     21 lines in 11 files changed: 0 ins; 0 del; 21 mod

8479: Update jolokia third party for JMC 10.0.0

Reviewed-by: schaturvedi

-------------

PR: https://git.openjdk.org/jmc/pull/695

From aptmac at openjdk.org  Thu Jan 22 21:21:59 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 22 Jan 2026 21:21:59 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy [v5]
In-Reply-To: <AZemjrScwDLTC8Ou195m7g3N2aePKWH1khjLVOQgCb8=.d0daaa31-18a6-4980-a1c1-ae1864169dff@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
 <AZemjrScwDLTC8Ou195m7g3N2aePKWH1khjLVOQgCb8=.d0daaa31-18a6-4980-a1c1-ae1864169dff@github.com>
Message-ID: <RCT5IXe16Ue3k7Lay3tq66wuWk6O_V15vV--OZKxj4Y=.ecb6dac5-d939-4544-89f4-dbaed7edc05e@github.com>

On Sun, 12 Oct 2025 18:35:12 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
>> 
>> Testing connectivity:
>> - [x]  Docker desktop kubernetes 
>> - [x]  Azure AKS
>> - [x]  Amazon EKS
>> - [x]  Google GKE
>> 
>> Other things observed:
>> 
>> - [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
>> - [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
>> - [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
>> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
>> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
>> - [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:
> 
>  - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
>  - JMC-8237: Upgrade jolokia 2.2.2 -> 2.2.9
>  - JMC-8237: Upgrade jolokia 2.2.2 -> 2.2.9
>  - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
>  - JMC-8237: Removed dead assignment
>  - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
>  - JMC-8237: Remove unneeded changes
>  - JMC-8237: Updated bundle version to 10.0.0. Updated copyright year
>  - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
>  - JMC-8237: Upgrade to jolokia 2.2.2
>  - ... and 19 more: https://git.openjdk.org/jmc/compare/58ca84a3...2fed8612

Great, I sponsored that and it's integrated now

-------------

PR Comment: https://git.openjdk.org/jmc/pull/576#issuecomment-3786742888

From duke at openjdk.org  Thu Jan 22 21:29:05 2026
From: duke at openjdk.org (Martin Skarsaune)
Date: Thu, 22 Jan 2026 21:29:05 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy [v6]
In-Reply-To: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
Message-ID: <V0NgvzSGlZHV8Lw8dCbjn2rBNkxZyOCZvR8oIVPAeWI=.dc332f9b-9c76-4371-b272-c17a4936e2c4@github.com>

> JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
> 
> Testing connectivity:
> - [x]  Docker desktop kubernetes 
> - [x]  Azure AKS
> - [x]  Amazon EKS
> - [x]  Google GKE
> 
> Other things observed:
> 
> - [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
> - [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
> - [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
> - [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 31 commits:

 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - JMC-8237: PR cleanup: formatting and comments
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - JMC-8237: Upgrade jolokia 2.2.2 -> 2.2.9
 - JMC-8237: Upgrade jolokia 2.2.2 -> 2.2.9
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - JMC-8237: Removed dead assignment
 - Merge remote-tracking branch 'origin/master' into JMC-8237-kubernetes-proxy
 - JMC-8237: Remove unneeded changes
 - JMC-8237: Updated bundle version to 10.0.0. Updated copyright year
 - ... and 21 more: https://git.openjdk.org/jmc/compare/3f115945...89b21741

-------------

Changes: https://git.openjdk.org/jmc/pull/576/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=576&range=05
  Stats: 2398 lines in 55 files changed: 2391 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jmc/pull/576.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/576/head:pull/576

PR: https://git.openjdk.org/jmc/pull/576

From duke at openjdk.org  Thu Jan 22 21:37:02 2026
From: duke at openjdk.org (Martin Skarsaune)
Date: Thu, 22 Jan 2026 21:37:02 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy [v7]
In-Reply-To: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
Message-ID: <zBMYE33Q2rAVzhRHMbIBLbPzgYNFgGl7A5vgRFZy89k=.bf32d6e9-0c7e-4065-8b7b-647760381215@github.com>

> JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
> 
> Testing connectivity:
> - [x]  Docker desktop kubernetes 
> - [x]  Azure AKS
> - [x]  Amazon EKS
> - [x]  Google GKE
> 
> Other things observed:
> 
> - [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
> - [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
> - [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
> - [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-8237: Fixed copyright for this year

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/576/files
  - new: https://git.openjdk.org/jmc/pull/576/files/89b21741..846881db

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=576&range=06
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=576&range=05-06

  Stats: 28 lines in 14 files changed: 0 ins; 0 del; 28 mod
  Patch: https://git.openjdk.org/jmc/pull/576.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/576/head:pull/576

PR: https://git.openjdk.org/jmc/pull/576

From duke at openjdk.org  Fri Jan 23 06:14:54 2026
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 23 Jan 2026 06:14:54 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy [v8]
In-Reply-To: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
Message-ID: <cZRiAuiGJnmiskfE6666CqmvptA7Ghjdpafy8bArKPA=.a1eef5a4-c47d-46f6-ab93-2223d2b595c1@github.com>

> JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
> 
> Testing connectivity:
> - [x]  Docker desktop kubernetes 
> - [x]  Azure AKS
> - [x]  Amazon EKS
> - [x]  Google GKE
> 
> Other things observed:
> 
> - [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
> - [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
> - [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
> - [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-8237: Fix more copyright years

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/576/files
  - new: https://git.openjdk.org/jmc/pull/576/files/846881db..e40caece

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=576&range=07
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=576&range=06-07

  Stats: 9 lines in 6 files changed: 0 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jmc/pull/576.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/576/head:pull/576

PR: https://git.openjdk.org/jmc/pull/576

From hirt at openjdk.org  Fri Jan 23 12:47:30 2026
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 23 Jan 2026 12:47:30 GMT
Subject: RFR: 8512: Fixing various minor typos and nits
Message-ID: <U-lMIRx2NYmNJ9MOhnUjdNIK3WmIal0lyFYzglRBORU=.7aaad8f5-5eaa-4ad9-95cb-f8428266861c@github.com>

Eclipse spelling error and some other minor nits.

-------------

Commit messages:
 - Fixing additional nits
 - 8512: Fixing various spelling errors and minor nits

Changes: https://git.openjdk.org/jmc/pull/700/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=700&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8512
  Stats: 14 lines in 5 files changed: 0 ins; 1 del; 13 mod
  Patch: https://git.openjdk.org/jmc/pull/700.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/700/head:pull/700

PR: https://git.openjdk.org/jmc/pull/700

From aptmac at openjdk.org  Fri Jan 23 14:19:39 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 23 Jan 2026 14:19:39 GMT
Subject: RFR: 8512: Fixing various minor typos and nits
In-Reply-To: <U-lMIRx2NYmNJ9MOhnUjdNIK3WmIal0lyFYzglRBORU=.7aaad8f5-5eaa-4ad9-95cb-f8428266861c@github.com>
References: <U-lMIRx2NYmNJ9MOhnUjdNIK3WmIal0lyFYzglRBORU=.7aaad8f5-5eaa-4ad9-95cb-f8428266861c@github.com>
Message-ID: <hdli-XRaP0J1DbZXkdx7lbapkCKaFnOUd0d50LTe5BY=.5c740461-b9db-470b-932e-9ae6a50a1aff@github.com>

On Fri, 23 Jan 2026 12:37:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Eclipse spelling error and some other minor nits.

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/700#pullrequestreview-3697728354

From aptmac at openjdk.org  Fri Jan 23 14:19:47 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 23 Jan 2026 14:19:47 GMT
Subject: RFR: 8237: Add support for Jolokia over Kubernetes proxy [v8]
In-Reply-To: <cZRiAuiGJnmiskfE6666CqmvptA7Ghjdpafy8bArKPA=.a1eef5a4-c47d-46f6-ab93-2223d2b595c1@github.com>
References: <gV8_jofch-kEuflmNxgL3bwYCa9wsgdYeEiVorlQGC4=.c690afbc-bf0e-475c-8a9e-47d933e637fa@github.com>
 <cZRiAuiGJnmiskfE6666CqmvptA7Ghjdpafy8bArKPA=.a1eef5a4-c47d-46f6-ab93-2223d2b595c1@github.com>
Message-ID: <1VTYQmYNC1FABPKiWxIztVtulWFpGTlUPODKnkuzOPU=.2e6a9cda-f4d2-42df-ba16-a31e92f81f11@github.com>

On Fri, 23 Jan 2026 06:14:54 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
>> 
>> Testing connectivity:
>> - [x]  Docker desktop kubernetes 
>> - [x]  Azure AKS
>> - [x]  Amazon EKS
>> - [x]  Google GKE
>> 
>> Other things observed:
>> 
>> - [x] * Option to install agent should be disabled (debug difference with jolokia) - ***see below****
>> - [x] * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
>> - [x] * SLF4J(W): No SLF4J providers were found. ***OK for now, can investigate more later***
>> SLF4J(W): Defaulting to no-operation (NOP) logger implementation
>> SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
>> - [x] Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JMC-8237: Fix more copyright years

It's stuck on some formatting, it'll fix once you run `mvn spotless:apply`

-------------

PR Comment: https://git.openjdk.org/jmc/pull/576#issuecomment-3790460328

From clanger at openjdk.org  Mon Jan 26 17:17:51 2026
From: clanger at openjdk.org (Christoph Langer)
Date: Mon, 26 Jan 2026 17:17:51 GMT
Subject: RFR: 8481: Update lz4-java to 1.10.2 [v7]
In-Reply-To: <BdE5tmpFBhBii-CgKoq9zXHYRyGakPvG3tCZNuw9Wwg=.04b92811-5d8c-4ccc-8085-c642f9fcc891@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
 <BdE5tmpFBhBii-CgKoq9zXHYRyGakPvG3tCZNuw9Wwg=.04b92811-5d8c-4ccc-8085-c642f9fcc891@github.com>
Message-ID: <77yPG3ryHbua7f7TsV886d4xOvzixW2NuollgmZzTXM=.cea4dac2-41dd-466c-b824-710d42580939@github.com>

On Fri, 9 Jan 2026 15:17:26 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> There's currently a security advisory open for the version of lz4-java we are using. lz4-java had been archived, but has been updated by a new maintainer with a fix for the security issue.
>> 
>> See: https://github.com/yawkat/lz4-java/security/advisories/GHSA-cmp6-m4wj-q63q
>
> Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update missed license headers

Looks correct and tests are green.

-------------

Marked as reviewed by clanger (Reviewer).

PR Review: https://git.openjdk.org/jmc/pull/694#pullrequestreview-3707093418

From clanger at openjdk.org  Mon Jan 26 17:19:19 2026
From: clanger at openjdk.org (Christoph Langer)
Date: Mon, 26 Jan 2026 17:19:19 GMT
Subject: RFR: 8512: Fixing various minor typos and nits
In-Reply-To: <U-lMIRx2NYmNJ9MOhnUjdNIK3WmIal0lyFYzglRBORU=.7aaad8f5-5eaa-4ad9-95cb-f8428266861c@github.com>
References: <U-lMIRx2NYmNJ9MOhnUjdNIK3WmIal0lyFYzglRBORU=.7aaad8f5-5eaa-4ad9-95cb-f8428266861c@github.com>
Message-ID: <9CBbsAy_YeF-lkz2PXWHJDxzDgA2l6wTg0-8rvyOGrM=.a9772ec9-7697-4c2d-b479-88e298bff78e@github.com>

On Fri, 23 Jan 2026 12:37:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Eclipse spelling error and some other minor nits.

Marked as reviewed by clanger (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/700#pullrequestreview-3707097931

From schaturvedi at openjdk.org  Wed Jan 28 22:16:30 2026
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Wed, 28 Jan 2026 22:16:30 GMT
Subject: RFR: 8524: Update third parties for 9.1.2
Message-ID: <BVNb4I1wBZo-0tDWtsqvRiHK-ozvyWJsL3VIkTLtIS8=.c513f67a-2302-42cc-8648-c433346d8116@github.com>

Updating below third parties:

Lz4 - 1.10.2
Angus mail - 2.0.5
Angus activation - 2.0.3
Jaf api - 2.1.4

-------------

Commit messages:
 - 8524: Update third parties for 9.1.2

Changes: https://git.openjdk.org/jmc/pull/702/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=702&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8524
  Stats: 38 lines in 12 files changed: 0 ins; 0 del; 38 mod
  Patch: https://git.openjdk.org/jmc/pull/702.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/702/head:pull/702

PR: https://git.openjdk.org/jmc/pull/702

From schaturvedi at openjdk.org  Wed Jan 28 22:16:41 2026
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Wed, 28 Jan 2026 22:16:41 GMT
Subject: RFR: 8523: Update version to 9.1.2
Message-ID: <jBjZY6kYLOzWZkUA3HZha-nPSgSd5UozQwHgAXOGHWw=.7a6a3529-8de2-413b-8661-1f69f4aff89f@github.com>

This PR is to Update version to 9.1.2

-------------

Commit messages:
 - 8523: Update version to 9.1.2

Changes: https://git.openjdk.org/jmc/pull/701/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=701&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8523
  Stats: 224 lines in 152 files changed: 0 ins; 0 del; 224 mod
  Patch: https://git.openjdk.org/jmc/pull/701.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/701/head:pull/701

PR: https://git.openjdk.org/jmc/pull/701

From hirt at openjdk.org  Thu Jan 29 13:49:21 2026
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 29 Jan 2026 13:49:21 GMT
Subject: RFR: 8523: Update version to 9.1.2
In-Reply-To: <jBjZY6kYLOzWZkUA3HZha-nPSgSd5UozQwHgAXOGHWw=.7a6a3529-8de2-413b-8661-1f69f4aff89f@github.com>
References: <jBjZY6kYLOzWZkUA3HZha-nPSgSd5UozQwHgAXOGHWw=.7a6a3529-8de2-413b-8661-1f69f4aff89f@github.com>
Message-ID: <PY2xb8hETc66OuaUqN3MX3gL4L5zm6gW8yuTQvEx0Zs=.bae17e70-3698-4800-933b-d3a9b38dde09@github.com>

On Wed, 28 Jan 2026 18:36:14 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR is to Update version to 9.1.2

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/701#pullrequestreview-3722833389

From hirt at openjdk.org  Thu Jan 29 14:22:36 2026
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 29 Jan 2026 14:22:36 GMT
Subject: RFR: 8525: Update 9.1 splash copyright year
Message-ID: <e0vTPDfGsGNEOWX4-rNii1XydlzbRkLAydUwcUG160I=.2baf9309-8569-482e-b75f-b9b58772ad39@github.com>

Updating the copyright year for the 9.1.2 release.

-------------

Commit messages:
 - 8525: Update 9.1 splash copyright year

Changes: https://git.openjdk.org/jmc/pull/703/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=703&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8525
  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/703.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/703/head:pull/703

PR: https://git.openjdk.org/jmc/pull/703

From schaturvedi at openjdk.org  Thu Jan 29 15:01:23 2026
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 29 Jan 2026 15:01:23 GMT
Subject: Integrated: 8523: Update version to 9.1.2
In-Reply-To: <jBjZY6kYLOzWZkUA3HZha-nPSgSd5UozQwHgAXOGHWw=.7a6a3529-8de2-413b-8661-1f69f4aff89f@github.com>
References: <jBjZY6kYLOzWZkUA3HZha-nPSgSd5UozQwHgAXOGHWw=.7a6a3529-8de2-413b-8661-1f69f4aff89f@github.com>
Message-ID: <cb0h5H5hLfOMLc2ySCElTqEyvbLxwLhRKictEnIRsw4=.cb20edb3-3b0f-4204-8ec7-b58e7853722f@github.com>

On Wed, 28 Jan 2026 18:36:14 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR is to Update version to 9.1.2

This pull request has now been integrated.

Changeset: 21f665df
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/21f665df61a8dbf70d00d3ba158c43390178abf5
Stats:     224 lines in 152 files changed: 0 ins; 0 del; 224 mod

8523: Update version to 9.1.2

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/701

From schaturvedi at openjdk.org  Thu Jan 29 15:03:04 2026
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 29 Jan 2026 15:03:04 GMT
Subject: RFR: 8525: Update 9.1 splash copyright year
In-Reply-To: <e0vTPDfGsGNEOWX4-rNii1XydlzbRkLAydUwcUG160I=.2baf9309-8569-482e-b75f-b9b58772ad39@github.com>
References: <e0vTPDfGsGNEOWX4-rNii1XydlzbRkLAydUwcUG160I=.2baf9309-8569-482e-b75f-b9b58772ad39@github.com>
Message-ID: <so4gmGfpx5nc2QIsghGit6VND_eNUhikm0NToErYuAg=.bf7aa36d-62d0-49af-a3a1-7f14bcea630e@github.com>

On Thu, 29 Jan 2026 14:16:55 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Updating the copyright year for the 9.1.2 release.

Looks good.

-------------

Marked as reviewed by schaturvedi (Committer).

PR Review: https://git.openjdk.org/jmc/pull/703#pullrequestreview-3723269429

From hirt at openjdk.org  Thu Jan 29 15:16:24 2026
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 29 Jan 2026 15:16:24 GMT
Subject: Integrated: 8525: Update 9.1 splash copyright year
In-Reply-To: <e0vTPDfGsGNEOWX4-rNii1XydlzbRkLAydUwcUG160I=.2baf9309-8569-482e-b75f-b9b58772ad39@github.com>
References: <e0vTPDfGsGNEOWX4-rNii1XydlzbRkLAydUwcUG160I=.2baf9309-8569-482e-b75f-b9b58772ad39@github.com>
Message-ID: <SqJ5fU1WszIYK581MCmjLhNq9Veo-byRtkgSow3hBbM=.2b381c3e-5efc-4544-91c7-6c2cc857c6d8@github.com>

On Thu, 29 Jan 2026 14:16:55 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Updating the copyright year for the 9.1.2 release.

This pull request has now been integrated.

Changeset: 8b142622
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/8b142622814acf993a7d54ab2beceea14a7b665f
Stats:     0 lines in 1 file changed: 0 ins; 0 del; 0 mod

8525: Update 9.1 splash copyright year

Reviewed-by: schaturvedi

-------------

PR: https://git.openjdk.org/jmc/pull/703

From aptmac at openjdk.org  Thu Jan 29 15:48:12 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 29 Jan 2026 15:48:12 GMT
Subject: Withdrawn: 8481: Update lz4-java to 1.10.2
In-Reply-To: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
Message-ID: <Qdh35Cgwz6_ekrtoVEytrXu9-GtwkShWkUfYCM47Ao8=.f961cae6-0b6a-47ad-b24c-87a11d573636@github.com>

On Fri, 12 Dec 2025 15:27:03 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> There's currently a security advisory open for the version of lz4-java we are using. lz4-java had been archived, but has been updated by a new maintainer with a fix for the security issue.
> 
> See: https://github.com/yawkat/lz4-java/security/advisories/GHSA-cmp6-m4wj-q63q

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jmc/pull/694

From aptmac at openjdk.org  Thu Jan 29 15:48:11 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 29 Jan 2026 15:48:11 GMT
Subject: RFR: 8481: Update lz4-java to 1.10.2 [v7]
In-Reply-To: <BdE5tmpFBhBii-CgKoq9zXHYRyGakPvG3tCZNuw9Wwg=.04b92811-5d8c-4ccc-8085-c642f9fcc891@github.com>
References: <q34nRKrJvvxKWlCx4lU2q8MHijlRQ0uwC6RwMZnkUX4=.1aa17e78-faff-4387-8324-b562efdc8d74@github.com>
 <BdE5tmpFBhBii-CgKoq9zXHYRyGakPvG3tCZNuw9Wwg=.04b92811-5d8c-4ccc-8085-c642f9fcc891@github.com>
Message-ID: <o--Isfnbv4n465se2fE9ZH945aVexsp0S31xm-uCrWA=.d76f3680-fb07-4560-95c8-d1e353e1723b@github.com>

On Fri, 9 Jan 2026 15:17:26 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> There's currently a security advisory open for the version of lz4-java we are using. lz4-java had been archived, but has been updated by a new maintainer with a fix for the security issue.
>> 
>> See: https://github.com/yawkat/lz4-java/security/advisories/GHSA-cmp6-m4wj-q63q
>
> Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update missed license headers

Closing in-favor of https://github.com/openjdk/jmc/pull/702, upstream should be updated with everything else Oracle included in their latest release

-------------

PR Comment: https://git.openjdk.org/jmc/pull/694#issuecomment-3818511423

From aptmac at openjdk.org  Thu Jan 29 15:51:24 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 29 Jan 2026 15:51:24 GMT
Subject: RFR: 8524: Update third parties for 9.1.2
In-Reply-To: <BVNb4I1wBZo-0tDWtsqvRiHK-ozvyWJsL3VIkTLtIS8=.c513f67a-2302-42cc-8648-c433346d8116@github.com>
References: <BVNb4I1wBZo-0tDWtsqvRiHK-ozvyWJsL3VIkTLtIS8=.c513f67a-2302-42cc-8648-c433346d8116@github.com>
Message-ID: <XxJBaHmMDpAqF0oymS66kbxoRuaCI6z29Wqgl13h3HU=.2ad5c742-4f2d-4fca-aaaf-d66625a80c8a@github.com>

On Wed, 28 Jan 2026 22:09:03 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Updating below third parties:
> 
> Lz4 - 1.10.2
> Angus mail - 2.0.5
> Angus activation - 2.0.3
> Jaf api - 2.1.4

This PR also targets the jmc9 branch, it would be nice to have this on the main branch as well

releng/third-party/pom.xml line 41:

> 39: 	<artifactId>external-dependencies</artifactId>
> 40: 	<packaging>war</packaging>
> 41: 	<version>9.1.2-SNAPSHOT</version>

This file will need a license date bump to 2026

-------------

PR Comment: https://git.openjdk.org/jmc/pull/702#issuecomment-3818533517
PR Review Comment: https://git.openjdk.org/jmc/pull/702#discussion_r2742313247

From schaturvedi at openjdk.org  Thu Jan 29 16:13:51 2026
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 29 Jan 2026 16:13:51 GMT
Subject: RFR: 8524: Update third parties for 9.1.2 [v2]
In-Reply-To: <BVNb4I1wBZo-0tDWtsqvRiHK-ozvyWJsL3VIkTLtIS8=.c513f67a-2302-42cc-8648-c433346d8116@github.com>
References: <BVNb4I1wBZo-0tDWtsqvRiHK-ozvyWJsL3VIkTLtIS8=.c513f67a-2302-42cc-8648-c433346d8116@github.com>
Message-ID: <OB62RtDYHfvoJaZfkLm2DVYZTDeK7Osp8_k5MO6EVck=.d71eded7-e96b-467e-93f6-92c60d2cabbe@github.com>

> Updating below third parties:
> 
> Lz4 - 1.10.2
> Angus mail - 2.0.5
> Angus activation - 2.0.3
> Jaf api - 2.1.4

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Updating copyright year for releng/third-party/pom.xml

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/702/files
  - new: https://git.openjdk.org/jmc/pull/702/files/201256d0..eef6670d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=702&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=702&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/702.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/702/head:pull/702

PR: https://git.openjdk.org/jmc/pull/702

From aptmac at openjdk.org  Thu Jan 29 16:13:59 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 29 Jan 2026 16:13:59 GMT
Subject: RFR: 8524: Update third parties for 9.1.2 [v2]
In-Reply-To: <OB62RtDYHfvoJaZfkLm2DVYZTDeK7Osp8_k5MO6EVck=.d71eded7-e96b-467e-93f6-92c60d2cabbe@github.com>
References: <BVNb4I1wBZo-0tDWtsqvRiHK-ozvyWJsL3VIkTLtIS8=.c513f67a-2302-42cc-8648-c433346d8116@github.com>
 <OB62RtDYHfvoJaZfkLm2DVYZTDeK7Osp8_k5MO6EVck=.d71eded7-e96b-467e-93f6-92c60d2cabbe@github.com>
Message-ID: <hBI93T2M7KRhzVGfrZMKOtZsCG5IZCNCiHjdrktnmT8=.8b4f89fd-178d-4095-bee7-431661879d8b@github.com>

On Thu, 29 Jan 2026 16:10:34 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> Updating below third parties:
>> 
>> Lz4 - 1.10.2
>> Angus mail - 2.0.5
>> Angus activation - 2.0.3
>> Jaf api - 2.1.4
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updating copyright year for releng/third-party/pom.xml

Marked as reviewed by aptmac (Reviewer).

Missed some of these before I hit approve that last time:

releng/platform-definitions/platform-definition-2024-06/platform-definition-2024-06.target line 3:

> 1: <?xml version="1.0" encoding="UTF-8" standalone="no"?>
> 2: <!--
> 3:    Copyright (c) 2024, 2026, Oracle and/or its affiliates. All rights reserved.

DD year update as well

releng/platform-definitions/platform-definition-2024-09/platform-definition-2024-09.target line 3:

> 1: <?xml version="1.0" encoding="UTF-8" standalone="no"?>
> 2: <!--
> 3:    Copyright (c) 2024, 2026, Oracle and/or its affiliates. All rights reserved.

Update the DD one too

releng/platform-definitions/platform-definition-2024-12/platform-definition-2024-12.target line 3:

> 1: <?xml version="1.0" encoding="UTF-8" standalone="no"?>
> 2: <!--
> 3:    Copyright (c) 2024, 2026, Oracle and/or its affiliates. All rights reserved.

Will need to update the DD one below as well

releng/platform-definitions/platform-definition-2025-03/platform-definition-2025-03.target line 4:

> 2: <!--
> 3:    Copyright (c) 2024, 2026, Oracle and/or its affiliates. All rights reserved.
> 4:    Copyright (c) 2024, 2025, Datadog, Inc. All rights reserved.

2025, 2026

releng/platform-definitions/platform-definition-2025-06/platform-definition-2025-06.target line 3:

> 1: <?xml version="1.0" encoding="UTF-8" standalone="no"?>
> 2: <!--
> 3:    Copyright (c) 2025, 2026, Oracle and/or its affiliates. All rights reserved.

2025, 2026 for both

releng/platform-definitions/platform-definition-2025-06/pom.xml line 4:

> 2: <!--
> 3:    Copyright (c) 2024, 2026, Oracle and/or its affiliates. All rights reserved.
> 4:    Copyright (c) 2024, 2025, Datadog, Inc. All rights reserved.

er, these should be 2025, 2026 for both

-------------

PR Review: https://git.openjdk.org/jmc/pull/702#pullrequestreview-3723657019
PR Review: https://git.openjdk.org/jmc/pull/702#pullrequestreview-3723667009
PR Review Comment: https://git.openjdk.org/jmc/pull/702#discussion_r2742426289
PR Review Comment: https://git.openjdk.org/jmc/pull/702#discussion_r2742425314
PR Review Comment: https://git.openjdk.org/jmc/pull/702#discussion_r2742424524
PR Review Comment: https://git.openjdk.org/jmc/pull/702#discussion_r2742422725
PR Review Comment: https://git.openjdk.org/jmc/pull/702#discussion_r2742421700
PR Review Comment: https://git.openjdk.org/jmc/pull/702#discussion_r2742419287

From schaturvedi at openjdk.org  Thu Jan 29 16:14:04 2026
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 29 Jan 2026 16:14:04 GMT
Subject: Integrated: 8524: Update third parties for 9.1.2
In-Reply-To: <BVNb4I1wBZo-0tDWtsqvRiHK-ozvyWJsL3VIkTLtIS8=.c513f67a-2302-42cc-8648-c433346d8116@github.com>
References: <BVNb4I1wBZo-0tDWtsqvRiHK-ozvyWJsL3VIkTLtIS8=.c513f67a-2302-42cc-8648-c433346d8116@github.com>
Message-ID: <DbJ4T5DjOP9rlBUJZRxkmtWhrQ7ZdQG9f9A25SiVTlA=.acda26b6-a450-437a-91cb-7843f1b0b887@github.com>

On Wed, 28 Jan 2026 22:09:03 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Updating below third parties:
> 
> Lz4 - 1.10.2
> Angus mail - 2.0.5
> Angus activation - 2.0.3
> Jaf api - 2.1.4

This pull request has now been integrated.

Changeset: 81016573
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/81016573aa4d97234ef6c0d3e7394dec6758b7f4
Stats:     39 lines in 12 files changed: 0 ins; 0 del; 39 mod

8524: Update third parties for 9.1.2

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/702

From schaturvedi at openjdk.org  Thu Jan 29 16:14:01 2026
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 29 Jan 2026 16:14:01 GMT
Subject: RFR: 8524: Update third parties for 9.1.2
In-Reply-To: <XxJBaHmMDpAqF0oymS66kbxoRuaCI6z29Wqgl13h3HU=.2ad5c742-4f2d-4fca-aaaf-d66625a80c8a@github.com>
References: <BVNb4I1wBZo-0tDWtsqvRiHK-ozvyWJsL3VIkTLtIS8=.c513f67a-2302-42cc-8648-c433346d8116@github.com>
 <XxJBaHmMDpAqF0oymS66kbxoRuaCI6z29Wqgl13h3HU=.2ad5c742-4f2d-4fca-aaaf-d66625a80c8a@github.com>
Message-ID: <rxY2ap4f2l8sR8UknX5PdxjVOeh-nj--6aKvLjEff18=.64bc3260-3dc2-4c85-a6f4-42e79bb4fe24@github.com>

On Thu, 29 Jan 2026 15:48:17 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR also targets the jmc9 branch, it would be nice to have this on the main branch as well

We are prepping up for 9.1.2 release as of now. After this, I will do the changes in master too.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/702#issuecomment-3818642020

From hirt at openjdk.org  Thu Jan 29 16:31:47 2026
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 29 Jan 2026 16:31:47 GMT
Subject: RFR: 8527: Add AGENTS.md file
Message-ID: <tglTMqv-FxxL44c7oGqyJkStZ1UZektEQv-5n74Bgn0=.94c2485a-f96a-4739-ab44-47ce305e4b26@github.com>

First basic AGENTS.md file for the JMC project.

-------------

Commit messages:
 - 8527: Add AGENTS.md file

Changes: https://git.openjdk.org/jmc/pull/704/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=704&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8527
  Stats: 142 lines in 1 file changed: 142 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/704.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/704/head:pull/704

PR: https://git.openjdk.org/jmc/pull/704

From aptmac at openjdk.org  Thu Jan 29 16:57:46 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 29 Jan 2026 16:57:46 GMT
Subject: RFR: 8527: Add AGENTS.md file
In-Reply-To: <tglTMqv-FxxL44c7oGqyJkStZ1UZektEQv-5n74Bgn0=.94c2485a-f96a-4739-ab44-47ce305e4b26@github.com>
References: <tglTMqv-FxxL44c7oGqyJkStZ1UZektEQv-5n74Bgn0=.94c2485a-f96a-4739-ab44-47ce305e4b26@github.com>
Message-ID: <FtoMigQ0yiO5zrXfBo9USGCENXwW4_9-gxZSSoSE2P8=.c4619c0c-daea-4fae-a62b-66f532fc4436@github.com>

On Thu, 29 Jan 2026 16:23:38 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> First basic AGENTS.md file for the JMC project.

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/704#pullrequestreview-3723920423

From schaturvedi at openjdk.org  Thu Jan 29 16:59:00 2026
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 29 Jan 2026 16:59:00 GMT
Subject: Integrated: 8526: Update third parties for 10.0.0
Message-ID: <VNXfE1Y7kkJHk-fkQdopsC495_spubrtutJH71ZDWYE=.35f96407-ecf3-49be-b50b-51a6305844c1@github.com>

Lz4 - 1.10.2
Angus mail - 2.0.5
Angus activation - 2.0.3
Jaf api - 2.1.4

-------------

Commit messages:
 - Update copyright year
 - 8526: Update third parties for 10.0.0

Changes: https://git.openjdk.org/jmc/pull/705/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=705&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8526
  Stats: 43 lines in 15 files changed: 0 ins; 0 del; 43 mod
  Patch: https://git.openjdk.org/jmc/pull/705.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/705/head:pull/705

PR: https://git.openjdk.org/jmc/pull/705

From aptmac at openjdk.org  Thu Jan 29 16:59:01 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 29 Jan 2026 16:59:01 GMT
Subject: Integrated: 8526: Update third parties for 10.0.0
In-Reply-To: <VNXfE1Y7kkJHk-fkQdopsC495_spubrtutJH71ZDWYE=.35f96407-ecf3-49be-b50b-51a6305844c1@github.com>
References: <VNXfE1Y7kkJHk-fkQdopsC495_spubrtutJH71ZDWYE=.35f96407-ecf3-49be-b50b-51a6305844c1@github.com>
Message-ID: <8W7Pdgw6KsWtfmLA22sIcDlzFj1OoyHpM3rq1P8asIY=.8f4eb7c4-942f-441d-9923-654d3a0a3ff0@github.com>

On Thu, 29 Jan 2026 16:39:27 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Lz4 - 1.10.2
> Angus mail - 2.0.5
> Angus activation - 2.0.3
> Jaf api - 2.1.4

Marked as reviewed by aptmac (Reviewer).

releng/platform-definitions/platform-definition-2025-03/platform-definition-2025-03.target line 3:

> 1: <?xml version="1.0" encoding="UTF-8" standalone="no"?>
> 2: <!--
> 3:    Copyright (c) 2024, 2026, Oracle and/or its affiliates. All rights reserved.

2025, 2026

releng/platform-definitions/platform-definition-2025-06/pom.xml line 3:

> 1: <?xml version="1.0" encoding="UTF-8"?>
> 2: <!--
> 3:    Copyright (c) 2024, 2026, Oracle and/or its affiliates. All rights reserved.

Should be 2025, 2026

-------------

PR Review: https://git.openjdk.org/jmc/pull/705#pullrequestreview-3723896852
PR Review Comment: https://git.openjdk.org/jmc/pull/705#discussion_r2742560780
PR Review Comment: https://git.openjdk.org/jmc/pull/705#discussion_r2742560101

From schaturvedi at openjdk.org  Thu Jan 29 16:59:02 2026
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 29 Jan 2026 16:59:02 GMT
Subject: Integrated: 8526: Update third parties for 10.0.0
In-Reply-To: <VNXfE1Y7kkJHk-fkQdopsC495_spubrtutJH71ZDWYE=.35f96407-ecf3-49be-b50b-51a6305844c1@github.com>
References: <VNXfE1Y7kkJHk-fkQdopsC495_spubrtutJH71ZDWYE=.35f96407-ecf3-49be-b50b-51a6305844c1@github.com>
Message-ID: <UJykFq7OkmdZY5inEcvJEvKd8Ho_H60HqNjproqEVao=.8ceddbcc-a187-4f49-9e8b-241e403c0fa7@github.com>

On Thu, 29 Jan 2026 16:39:27 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> Lz4 - 1.10.2
> Angus mail - 2.0.5
> Angus activation - 2.0.3
> Jaf api - 2.1.4

This pull request has now been integrated.

Changeset: 66c237db
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/66c237dba3965e5595cf01902ae92b4698684a3b
Stats:     43 lines in 15 files changed: 0 ins; 0 del; 43 mod

8526: Update third parties for 10.0.0

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/705

From hirt at openjdk.org  Thu Jan 29 17:19:13 2026
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 29 Jan 2026 17:19:13 GMT
Subject: Integrated: 8512: Fixing various minor typos and nits
In-Reply-To: <U-lMIRx2NYmNJ9MOhnUjdNIK3WmIal0lyFYzglRBORU=.7aaad8f5-5eaa-4ad9-95cb-f8428266861c@github.com>
References: <U-lMIRx2NYmNJ9MOhnUjdNIK3WmIal0lyFYzglRBORU=.7aaad8f5-5eaa-4ad9-95cb-f8428266861c@github.com>
Message-ID: <aQZb92NEd7dxhoYKXuEJlEzaw-tqeNTjWaGvz8kXPAo=.336d97cf-1f8f-404d-986b-400c8e7e870d@github.com>

On Fri, 23 Jan 2026 12:37:20 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Eclipse spelling error and some other minor nits.

This pull request has now been integrated.

Changeset: 643f9811
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/643f98113fef8917664fb7a813900ff0e3176c0a
Stats:     14 lines in 5 files changed: 0 ins; 1 del; 13 mod

8512: Fixing various minor typos and nits

Reviewed-by: aptmac, clanger

-------------

PR: https://git.openjdk.org/jmc/pull/700

From hirt at openjdk.org  Thu Jan 29 17:19:11 2026
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 29 Jan 2026 17:19:11 GMT
Subject: Integrated: 8527: Add AGENTS.md file
In-Reply-To: <tglTMqv-FxxL44c7oGqyJkStZ1UZektEQv-5n74Bgn0=.94c2485a-f96a-4739-ab44-47ce305e4b26@github.com>
References: <tglTMqv-FxxL44c7oGqyJkStZ1UZektEQv-5n74Bgn0=.94c2485a-f96a-4739-ab44-47ce305e4b26@github.com>
Message-ID: <N11MspixgBMimtIXSxI15griXdLoa_8iw0qai4MSUYk=.8db433d0-b5fc-452f-ae89-75170ac0889f@github.com>

On Thu, 29 Jan 2026 16:23:38 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> First basic AGENTS.md file for the JMC project.

This pull request has now been integrated.

Changeset: 8b1fbae1
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/8b1fbae10836f0cb41c4206094b24d74b6172117
Stats:     142 lines in 1 file changed: 142 ins; 0 del; 0 mod

8527: Add AGENTS.md file

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/704

From hirt at openjdk.org  Fri Jan 30 18:26:57 2026
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 30 Jan 2026 18:26:57 GMT
Subject: RFR: 8528: UI tests fail after platform upgrade
Message-ID: <yTIFxLwo-loIrnU7IVM-WZvKK9l1CTmgoVLYV4iT4Qc=.86e0a5ff-a215-4c1e-9c90-d171e36caeb5@github.com>

The uitests also caught a problem with the finalizer removal which is also fixed.

-------------

Commit messages:
 - 8528: Fix for uitests

Changes: https://git.openjdk.org/jmc/pull/706/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=706&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8528
  Stats: 23 lines in 3 files changed: 7 ins; 12 del; 4 mod
  Patch: https://git.openjdk.org/jmc/pull/706.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/706/head:pull/706

PR: https://git.openjdk.org/jmc/pull/706

From hirt at openjdk.org  Fri Jan 30 18:39:59 2026
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 30 Jan 2026 18:39:59 GMT
Subject: RFR: 8528: UI tests fail after platform upgrade [v2]
In-Reply-To: <yTIFxLwo-loIrnU7IVM-WZvKK9l1CTmgoVLYV4iT4Qc=.86e0a5ff-a215-4c1e-9c90-d171e36caeb5@github.com>
References: <yTIFxLwo-loIrnU7IVM-WZvKK9l1CTmgoVLYV4iT4Qc=.86e0a5ff-a215-4c1e-9c90-d171e36caeb5@github.com>
Message-ID: <aKwhcSfUPumT55qdDUaVbtwCb4w6N8kivxak-kgutSQ=.e873c877-4ace-4b57-b975-d186ad96df9c@github.com>

> The uitests also caught a problem with the finalizer removal which is also fixed.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Copyright fix

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/706/files
  - new: https://git.openjdk.org/jmc/pull/706/files/d1bc4843..5713efcc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=706&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=706&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/706.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/706/head:pull/706

PR: https://git.openjdk.org/jmc/pull/706

From hirt at openjdk.org  Fri Jan 30 19:42:08 2026
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 30 Jan 2026 19:42:08 GMT
Subject: RFR: 8490: Include numeric types without Persister in
 "Add Filter from Attribute" menu
In-Reply-To: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
References: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
Message-ID: <zWmlCbtXO_GbSsiNzrGlIl83g__wJsJKPERIFzawUF0=.66992028-3bfe-4eda-8f29-a21af33571da@github.com>

On Fri, 9 Jan 2026 07:04:09 GMT, youngledo <duke at openjdk.org> wrote:

> ### Problem
> 
>   Attributes with numeric ContentTypes that don't have a Persister (such as primitive types: byte, short, int, long, float, double, char) are
>   excluded from the "Add Filter from Attribute" context menu in the Event Browser's filter editor.
> 
> #### Steps to reproduce:
>   1. Open a JFR file containing events with primitive numeric fields (e.g., Spring Framework's FlightRecorderStartupEvent with long eventId and
>   long parentId)
>   2. In Event Browser, right-click on a column ? Select "Show Filter"
>   3. Right-click on the filter area ? Select "Add Filter from Attribute"
>   4. Expected: All filterable attributes should appear in the menu
>   5. Actual: Primitive numeric type attributes are missing from the menu
> 
> <img width="2420" height="1362" alt="image" src="https://github.com/user-attachments/assets/70bcb795-7a7b-42f0-a83e-e34cb8e50361" />
> 
> #### Root Cause
> 
>   The getPersistableAttributes() method in DataPageToolkit.java (line 1006-1007) filters attributes based on whether their ContentType has a
>   Persister:
> 
>   ```java
>   .filter(a -> a.equals(JfrAttributes.EVENT_TYPE) || (a.getContentType() instanceof RangeContentType)
>       || (a.getContentType().getPersister() != null))
>   ```
> 
>   However, primitive numeric types use these ContentTypes which don't have a Persister:
>   - UnitLookup.RAW_NUMBER - used by all primitive numeric types (byte, short, int, long, float, double, char)
>   - UnitLookup.RAW_LONG - used by some custom Long attributes
>   - UnitLookup.COUNT, UnitLookup.INDEX, UnitLookup.IDENTIFIER - legacy numeric types
> 
>   These types return null from getPersister() (see ContentType.java:99-101), causing them to be filtered out.
> 
> ### Why this is incorrect:
> 
>   Even though these types cannot be persisted to strings, they fully support filtering via ItemFilters.equals(). Excluding them from the filter
>   menu is inconsistent with their actual capabilities.
> 
> ### Solution
> 
>   Add a helper method isFilterableNumericType() to identify numeric ContentTypes that support filtering even without a Persister, and include them
>    in the filter:
> 
> private static boolean isFilterableNumericType(IAttribute<?> attribute) {
>       org.openjdk.jmc.common.unit.ContentType<?> ct = attribute.getContentType();
>       return ct.equals(UnitLookup.RAW_NUMBER) || ct.equals(UnitLookup.RAW_LONG)|| ct.equals(UnitLookup.COUNT) || ct.equals(UnitLookup.INDEX)
>               || ct.equals(UnitLookup.IDENTIFIER);
>   }
> 
> 
> Update the filter condition to include these types:
> 
>   .filter(a -> a.equals(...

The current PR will allow these attributes to appear in the menu, but users will likely hit errors when trying to use or save filters on them. I'd suggest either:

1. (Preferred) Add proper LeafContentType persisters to the numeric types in UnitLookup
2. (Minimal) Add null-safety handling in the filter persistence code alongside this change

Happy to discuss further or help with implementation!

-------------

PR Comment: https://git.openjdk.org/jmc/pull/699#issuecomment-3825406928

From aptmac at openjdk.org  Fri Jan 30 19:57:19 2026
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 30 Jan 2026 19:57:19 GMT
Subject: RFR: 8528: UI tests fail after platform upgrade [v2]
In-Reply-To: <aKwhcSfUPumT55qdDUaVbtwCb4w6N8kivxak-kgutSQ=.e873c877-4ace-4b57-b975-d186ad96df9c@github.com>
References: <yTIFxLwo-loIrnU7IVM-WZvKK9l1CTmgoVLYV4iT4Qc=.86e0a5ff-a215-4c1e-9c90-d171e36caeb5@github.com>
 <aKwhcSfUPumT55qdDUaVbtwCb4w6N8kivxak-kgutSQ=.e873c877-4ace-4b57-b975-d186ad96df9c@github.com>
Message-ID: <teEz9Ml122PF61FFrYGHimvNfHS1Mb7r5n6rbOChgKA=.43fde578-1fe2-4a2f-a3e3-3894880a759e@github.com>

On Fri, 30 Jan 2026 18:39:59 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> The uitests also caught a problem with the finalizer removal which is also fixed.
>
> Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Copyright fix

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/706#pullrequestreview-3730136308

From duke at openjdk.org  Sat Jan 31 10:03:21 2026
From: duke at openjdk.org (youngledo)
Date: Sat, 31 Jan 2026 10:03:21 GMT
Subject: RFR: 8490: Include numeric types without Persister in
 "Add Filter from Attribute" menu
In-Reply-To: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
References: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
Message-ID: <okLSv6MZBk9yDbfP6rKfAiENiUsVBco_ntkF4wKc2T0=.1080805c-35b3-4918-bdaa-87668321a87b@github.com>

On Fri, 9 Jan 2026 07:04:09 GMT, youngledo <duke at openjdk.org> wrote:

> ### Problem
> 
>   Attributes with numeric ContentTypes that don't have a Persister (such as primitive types: byte, short, int, long, float, double, char) are
>   excluded from the "Add Filter from Attribute" context menu in the Event Browser's filter editor.
> 
> #### Steps to reproduce:
>   1. Open a JFR file containing events with primitive numeric fields (e.g., Spring Framework's FlightRecorderStartupEvent with long eventId and
>   long parentId)
>   2. In Event Browser, right-click on a column ? Select "Show Filter"
>   3. Right-click on the filter area ? Select "Add Filter from Attribute"
>   4. Expected: All filterable attributes should appear in the menu
>   5. Actual: Primitive numeric type attributes are missing from the menu
> 
> <img width="2420" height="1362" alt="image" src="https://github.com/user-attachments/assets/70bcb795-7a7b-42f0-a83e-e34cb8e50361" />
> 
> #### Root Cause
> 
>   The getPersistableAttributes() method in DataPageToolkit.java (line 1006-1007) filters attributes based on whether their ContentType has a
>   Persister:
> 
>   ```java
>   .filter(a -> a.equals(JfrAttributes.EVENT_TYPE) || (a.getContentType() instanceof RangeContentType)
>       || (a.getContentType().getPersister() != null))
>   ```
> 
>   However, primitive numeric types use these ContentTypes which don't have a Persister:
>   - UnitLookup.RAW_NUMBER - used by all primitive numeric types (byte, short, int, long, float, double, char)
>   - UnitLookup.RAW_LONG - used by some custom Long attributes
>   - UnitLookup.COUNT, UnitLookup.INDEX, UnitLookup.IDENTIFIER - legacy numeric types
> 
>   These types return null from getPersister() (see ContentType.java:99-101), causing them to be filtered out.
> 
> ### Why this is incorrect:
> 
>   Even though these types cannot be persisted to strings, they fully support filtering via ItemFilters.equals(). Excluding them from the filter
>   menu is inconsistent with their actual capabilities.
> 
> ### Solution
> 
>   Add a helper method isFilterableNumericType() to identify numeric ContentTypes that support filtering even without a Persister, and include them
>    in the filter:
> 
> private static boolean isFilterableNumericType(IAttribute<?> attribute) {
>       org.openjdk.jmc.common.unit.ContentType<?> ct = attribute.getContentType();
>       return ct.equals(UnitLookup.RAW_NUMBER) || ct.equals(UnitLookup.RAW_LONG)|| ct.equals(UnitLookup.COUNT) || ct.equals(UnitLookup.INDEX)
>               || ct.equals(UnitLookup.IDENTIFIER);
>   }
> 
> 
> Update the filter condition to include these types:
> 
>   .filter(a -> a.equals(...

Welcome to vote. If there are no votes, I will implement according to the first suggestion.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/699#issuecomment-3828058703

From duke at openjdk.org  Sat Jan 31 14:24:08 2026
From: duke at openjdk.org (youngledo)
Date: Sat, 31 Jan 2026 14:24:08 GMT
Subject: RFR: 8490: Include numeric types without Persister in
 "Add Filter from Attribute" menu [v2]
In-Reply-To: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
References: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
Message-ID: <fEEKN63KtnHDcdiTvlLLn4T0yA4fO96U8I2hUZWVOnc=.dca2bdea-7c87-42ee-9006-caa6d2b257bc@github.com>

> ### Problem
> 
>   Attributes with numeric ContentTypes that don't have a Persister (such as primitive types: byte, short, int, long, float, double, char) are
>   excluded from the "Add Filter from Attribute" context menu in the Event Browser's filter editor.
> 
> #### Steps to reproduce:
>   1. Open a JFR file containing events with primitive numeric fields (e.g., Spring Framework's FlightRecorderStartupEvent with long eventId and
>   long parentId)
>   2. In Event Browser, right-click on a column ? Select "Show Filter"
>   3. Right-click on the filter area ? Select "Add Filter from Attribute"
>   4. Expected: All filterable attributes should appear in the menu
>   5. Actual: Primitive numeric type attributes are missing from the menu
> 
> <img width="2420" height="1362" alt="image" src="https://github.com/user-attachments/assets/70bcb795-7a7b-42f0-a83e-e34cb8e50361" />
> 
> #### Root Cause
> 
>   The getPersistableAttributes() method in DataPageToolkit.java (line 1006-1007) filters attributes based on whether their ContentType has a
>   Persister:
> 
>   ```java
>   .filter(a -> a.equals(JfrAttributes.EVENT_TYPE) || (a.getContentType() instanceof RangeContentType)
>       || (a.getContentType().getPersister() != null))
>   ```
> 
>   However, primitive numeric types use these ContentTypes which don't have a Persister:
>   - UnitLookup.RAW_NUMBER - used by all primitive numeric types (byte, short, int, long, float, double, char)
>   - UnitLookup.RAW_LONG - used by some custom Long attributes
>   - UnitLookup.COUNT, UnitLookup.INDEX, UnitLookup.IDENTIFIER - legacy numeric types
> 
>   These types return null from getPersister() (see ContentType.java:99-101), causing them to be filtered out.
> 
> ### Why this is incorrect:
> 
>   Even though these types cannot be persisted to strings, they fully support filtering via ItemFilters.equals(). Excluding them from the filter
>   menu is inconsistent with their actual capabilities.
> 
> ### Solution
> 
>   Add a helper method isFilterableNumericType() to identify numeric ContentTypes that support filtering even without a Persister, and include them
>    in the filter:
> 
> private static boolean isFilterableNumericType(IAttribute<?> attribute) {
>       org.openjdk.jmc.common.unit.ContentType<?> ct = attribute.getContentType();
>       return ct.equals(UnitLookup.RAW_NUMBER) || ct.equals(UnitLookup.RAW_LONG)|| ct.equals(UnitLookup.COUNT) || ct.equals(UnitLookup.INDEX)
>               || ct.equals(UnitLookup.IDENTIFIER);
>   }
> 
> 
> Update the filter condition to include these types:
> 
>   .filter(a -> a.equals(...

youngledo has updated the pull request incrementally with five additional commits since the last revision:

 - Fix: Add proper error handling for empty input in numeric filters
   
   Modified both UnitLookup and CommonCellEditors to properly handle empty or invalid
   input when editing numeric type filters, preventing "Unhandled event loop exception" errors.
   
   Changes:
   1. UnitLookup.java:
      - Added try-catch blocks to parsePersisted() and parseInteractive() methods
      - Catch NumberFormatException and throw IllegalArgumentException with clear message
      - Applied to RAW_NUMBER, RAW_LONG, COUNT, INDEX, and IDENTIFIER types
   
   2. CommonCellEditors.java:
      - Added catch block for IllegalArgumentException and NumberFormatException
      - Displays error message in UI when user enters invalid value
      - Prevents unhandled exception from crashing the UI
   
   This ensures a user-friendly experience when editing numeric filters, especially
   when clearing input fields.
   
   Co-Authored-By: Claude Sonnet 4.5 <noreply at anthropic.com>
 - Fix: Ensure numeric type compatibility for filter comparisons
   
   Changed parseNumber() to always return Long (for integers) or Double (for decimals)
   instead of Integer/Long/Double hierarchy to ensure type compatibility when
   comparing filter values.
   
   Problem:
   - Previously parseNumber("100") returned Integer(100)
   - If actual data was Long(100L), comparison would fail because
     Integer(100).equals(Long(100L)) returns false
   - This caused filters to not match any data even when values existed
   
   Solution:
   - parseNumber() now returns Long for all integer values
   - Returns Double only for decimal values
   - This ensures Long.equals(Long) comparisons work correctly
   - All RAW_NUMBER, COUNT, INDEX, IDENTIFIER types now use consistent types
   
   Co-Authored-By: Claude Sonnet 4.5 <noreply at anthropic.com>
 - Fix: Add null/empty string checks to numeric type parsers
   
   This commit adds validation for empty and blank strings in the parseNumber()
   method and RAW_LONG persister methods to prevent NumberFormatException
   when users clear input fields in the filter editor.
   
   Changes:
   - parseNumber(): Check for null/empty string before parsing
   - createRawLong() parsePersisted(): Check for empty string before parsing
   - createRawLong() parseInteractive(): Check for empty string before parsing
   - Updated javadoc to document the NumberFormatException for empty strings
   
   This fixes the issue where editing a numeric filter value and clearing
   the input field would cause an unhandled NumberFormatException with
   the message "empty String" instead of a more user-friendly error.
   
   Co-Authored-By: Claude Sonnet 4.5 <noreply at anthropic.com>
 - Remove .classpath files from version control
 - Add proper LeafContentType persisters to numeric types in UnitLookup
   
   This commit adds IPersister implementation to the following numeric types:
   - RAW_NUMBER
   - RAW_LONG
   - COUNT
   - INDEX
   - IDENTIFIER
   
   These types previously had no Persister, which would cause errors when users
   tried to edit or save filters on them. By implementing the IPersister interface
   via LeafContentType, these types can now be properly persisted and restored.
   
   Changes:
   - Modified createRawNumber() to return a LeafContentType with full persister support
   - Modified createRawLong() to return a LeafContentType with full persister support
   - Modified createCount() to return a LeafContentType with full persister support
   - Modified createIdentifier() to return a LeafContentType with full persister support
   - Modified createIndex() to return a LeafContentType with full persister support
   - Added parseNumber() helper method to parse string representations of numbers
   
   The persister implementation supports:
   - persistableString(): converts Number values to strings for storage
   - parsePersisted(): parses strings back to Number objects
   - interactiveFormat(): user-friendly string representation
   - parseInteractive(): parses user input strings
   
   This fix resolves the issue where attributes with these numeric content types
   would appear in the "Add Filter from Attribute" menu but fail when users
   attempted to use or save filters on them.
   
   Co-Authored-By: Claude Sonnet 4.5 <noreply at anthropic.com>

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/699/files
  - new: https://git.openjdk.org/jmc/pull/699/files/a6064ca8..ddba4152

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=699&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=699&range=00-01

  Stats: 3576 lines in 134 files changed: 281 ins; 3290 del; 5 mod
  Patch: https://git.openjdk.org/jmc/pull/699.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/699/head:pull/699

PR: https://git.openjdk.org/jmc/pull/699

From duke at openjdk.org  Sat Jan 31 14:30:03 2026
From: duke at openjdk.org (youngledo)
Date: Sat, 31 Jan 2026 14:30:03 GMT
Subject: RFR: 8490: Include numeric types without Persister in
 "Add Filter from Attribute" menu [v3]
In-Reply-To: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
References: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
Message-ID: <OGs0TNovPXjfWRxiZSLqPyNqgkuFkBY0ZDhkgV96zwA=.5bc002fb-c5d5-4bd8-9efc-b8da5d615092@github.com>

> ### Problem
> 
>   Attributes with numeric ContentTypes that don't have a Persister (such as primitive types: byte, short, int, long, float, double, char) are
>   excluded from the "Add Filter from Attribute" context menu in the Event Browser's filter editor.
> 
> #### Steps to reproduce:
>   1. Open a JFR file containing events with primitive numeric fields (e.g., Spring Framework's FlightRecorderStartupEvent with long eventId and
>   long parentId)
>   2. In Event Browser, right-click on a column ? Select "Show Filter"
>   3. Right-click on the filter area ? Select "Add Filter from Attribute"
>   4. Expected: All filterable attributes should appear in the menu
>   5. Actual: Primitive numeric type attributes are missing from the menu
> 
> <img width="2420" height="1362" alt="image" src="https://github.com/user-attachments/assets/70bcb795-7a7b-42f0-a83e-e34cb8e50361" />
> 
> #### Root Cause
> 
>   The getPersistableAttributes() method in DataPageToolkit.java (line 1006-1007) filters attributes based on whether their ContentType has a
>   Persister:
> 
>   ```java
>   .filter(a -> a.equals(JfrAttributes.EVENT_TYPE) || (a.getContentType() instanceof RangeContentType)
>       || (a.getContentType().getPersister() != null))
>   ```
> 
>   However, primitive numeric types use these ContentTypes which don't have a Persister:
>   - UnitLookup.RAW_NUMBER - used by all primitive numeric types (byte, short, int, long, float, double, char)
>   - UnitLookup.RAW_LONG - used by some custom Long attributes
>   - UnitLookup.COUNT, UnitLookup.INDEX, UnitLookup.IDENTIFIER - legacy numeric types
> 
>   These types return null from getPersister() (see ContentType.java:99-101), causing them to be filtered out.
> 
> ### Why this is incorrect:
> 
>   Even though these types cannot be persisted to strings, they fully support filtering via ItemFilters.equals(). Excluding them from the filter
>   menu is inconsistent with their actual capabilities.
> 
> ### Solution
> 
>   Add a helper method isFilterableNumericType() to identify numeric ContentTypes that support filtering even without a Persister, and include them
>    in the filter:
> 
> private static boolean isFilterableNumericType(IAttribute<?> attribute) {
>       org.openjdk.jmc.common.unit.ContentType<?> ct = attribute.getContentType();
>       return ct.equals(UnitLookup.RAW_NUMBER) || ct.equals(UnitLookup.RAW_LONG)|| ct.equals(UnitLookup.COUNT) || ct.equals(UnitLookup.INDEX)
>               || ct.equals(UnitLookup.IDENTIFIER);
>   }
> 
> 
> Update the filter condition to include these types:
> 
>   .filter(a -> a.equals(...

youngledo has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains five new commits since the last revision:

 - Fix: Add proper error handling for empty input in numeric filters
   
   Modified both UnitLookup and CommonCellEditors to properly handle empty or invalid
   input when editing numeric type filters, preventing "Unhandled event loop exception" errors.
   
   Changes:
   1. UnitLookup.java:
      - Added try-catch blocks to parsePersisted() and parseInteractive() methods
      - Catch NumberFormatException and throw IllegalArgumentException with clear message
      - Applied to RAW_NUMBER, RAW_LONG, COUNT, INDEX, and IDENTIFIER types
   
   2. CommonCellEditors.java:
      - Added catch block for IllegalArgumentException and NumberFormatException
      - Displays error message in UI when user enters invalid value
      - Prevents unhandled exception from crashing the UI
   
   This ensures a user-friendly experience when editing numeric filters, especially
   when clearing input fields.
   
 - Fix: Ensure numeric type compatibility for filter comparisons
   
   Changed parseNumber() to always return Long (for integers) or Double (for decimals)
   instead of Integer/Long/Double hierarchy to ensure type compatibility when
   comparing filter values.
   
   Problem:
   - Previously parseNumber("100") returned Integer(100)
   - If actual data was Long(100L), comparison would fail because
     Integer(100).equals(Long(100L)) returns false
   - This caused filters to not match any data even when values existed
   
   Solution:
   - parseNumber() now returns Long for all integer values
   - Returns Double only for decimal values
   - This ensures Long.equals(Long) comparisons work correctly
   - All RAW_NUMBER, COUNT, INDEX, IDENTIFIER types now use consistent types
   
 - Fix: Add null/empty string checks to numeric type parsers
   
   This commit adds validation for empty and blank strings in the parseNumber()
   method and RAW_LONG persister methods to prevent NumberFormatException
   when users clear input fields in the filter editor.
   
   Changes:
   - parseNumber(): Check for null/empty string before parsing
   - createRawLong() parsePersisted(): Check for empty string before parsing
   - createRawLong() parseInteractive(): Check for empty string before parsing
   - Updated javadoc to document the NumberFormatException for empty strings
   
   This fixes the issue where editing a numeric filter value and clearing
   the input field would cause an unhandled NumberFormatException with
   the message "empty String" instead of a more user-friendly error.
   
 - Remove .classpath files from version control
 - Add proper LeafContentType persisters to numeric types in UnitLookup
   
   This commit adds IPersister implementation to the following numeric types:
   - RAW_NUMBER
   - RAW_LONG
   - COUNT
   - INDEX
   - IDENTIFIER
   
   These types previously had no Persister, which would cause errors when users
   tried to edit or save filters on them. By implementing the IPersister interface
   via LeafContentType, these types can now be properly persisted and restored.
   
   Changes:
   - Modified createRawNumber() to return a LeafContentType with full persister support
   - Modified createRawLong() to return a LeafContentType with full persister support
   - Modified createCount() to return a LeafContentType with full persister support
   - Modified createIdentifier() to return a LeafContentType with full persister support
   - Modified createIndex() to return a LeafContentType with full persister support
   - Added parseNumber() helper method to parse string representations of numbers
   
   The persister implementation supports:
   - persistableString(): converts Number values to strings for storage
   - parsePersisted(): parses strings back to Number objects
   - interactiveFormat(): user-friendly string representation
   - parseInteractive(): parses user input strings
   
   This fix resolves the issue where attributes with these numeric content types
   would appear in the "Add Filter from Attribute" menu but fail when users
   attempted to use or save filters on them.

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/699/files
  - new: https://git.openjdk.org/jmc/pull/699/files/ddba4152..1c1601c3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=699&range=02
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=699&range=01-02

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/699.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/699/head:pull/699

PR: https://git.openjdk.org/jmc/pull/699

From duke at openjdk.org  Sat Jan 31 14:43:00 2026
From: duke at openjdk.org (youngledo)
Date: Sat, 31 Jan 2026 14:43:00 GMT
Subject: RFR: 8490: Include numeric types without Persister in
 "Add Filter from Attribute" menu [v4]
In-Reply-To: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
References: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
Message-ID: <MRDXjm3CNcvQUQdLs2U8-O4HjNpt8Jb0fgZnxOLI2vw=.f1bd52a5-c36f-4c8c-bcef-a7efb21e95e9@github.com>

> ### Problem
> 
>   Attributes with numeric ContentTypes that don't have a Persister (such as primitive types: byte, short, int, long, float, double, char) are
>   excluded from the "Add Filter from Attribute" context menu in the Event Browser's filter editor.
> 
> #### Steps to reproduce:
>   1. Open a JFR file containing events with primitive numeric fields (e.g., Spring Framework's FlightRecorderStartupEvent with long eventId and
>   long parentId)
>   2. In Event Browser, right-click on a column ? Select "Show Filter"
>   3. Right-click on the filter area ? Select "Add Filter from Attribute"
>   4. Expected: All filterable attributes should appear in the menu
>   5. Actual: Primitive numeric type attributes are missing from the menu
> 
> <img width="2420" height="1362" alt="image" src="https://github.com/user-attachments/assets/70bcb795-7a7b-42f0-a83e-e34cb8e50361" />
> 
> #### Root Cause
> 
>   The getPersistableAttributes() method in DataPageToolkit.java (line 1006-1007) filters attributes based on whether their ContentType has a
>   Persister:
> 
>   ```java
>   .filter(a -> a.equals(JfrAttributes.EVENT_TYPE) || (a.getContentType() instanceof RangeContentType)
>       || (a.getContentType().getPersister() != null))
>   ```
> 
>   However, primitive numeric types use these ContentTypes which don't have a Persister:
>   - UnitLookup.RAW_NUMBER - used by all primitive numeric types (byte, short, int, long, float, double, char)
>   - UnitLookup.RAW_LONG - used by some custom Long attributes
>   - UnitLookup.COUNT, UnitLookup.INDEX, UnitLookup.IDENTIFIER - legacy numeric types
> 
>   These types return null from getPersister() (see ContentType.java:99-101), causing them to be filtered out.
> 
> ### Why this is incorrect:
> 
>   Even though these types cannot be persisted to strings, they fully support filtering via ItemFilters.equals(). Excluding them from the filter
>   menu is inconsistent with their actual capabilities.
> 
> ### Solution
> 
>   Add a helper method isFilterableNumericType() to identify numeric ContentTypes that support filtering even without a Persister, and include them
>    in the filter:
> 
> private static boolean isFilterableNumericType(IAttribute<?> attribute) {
>       org.openjdk.jmc.common.unit.ContentType<?> ct = attribute.getContentType();
>       return ct.equals(UnitLookup.RAW_NUMBER) || ct.equals(UnitLookup.RAW_LONG)|| ct.equals(UnitLookup.COUNT) || ct.equals(UnitLookup.INDEX)
>               || ct.equals(UnitLookup.IDENTIFIER);
>   }
> 
> 
> Update the filter condition to include these types:
> 
>   .filter(a -> a.equals(...

youngledo has updated the pull request incrementally with five additional commits since the last revision:

 - 8527: Add AGENTS.md file
   
   Reviewed-by: aptmac
 - 8512: Fixing various minor typos and nits
   
   Reviewed-by: aptmac, clanger
 - 8526: Update third parties for 10.0.0
   
   Reviewed-by: aptmac
 - 8479: Update jolokia third party for JMC 10.0.0
   
   Reviewed-by: schaturvedi
 - 8489: Inaccurate Chinese translations on TLAB page
   
   Reviewed-by: aptmac

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/699/files
  - new: https://git.openjdk.org/jmc/pull/699/files/1c1601c3..3ba082fa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=699&range=03
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=699&range=02-03

  Stats: 234 lines in 29 files changed: 142 ins; 1 del; 91 mod
  Patch: https://git.openjdk.org/jmc/pull/699.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/699/head:pull/699

PR: https://git.openjdk.org/jmc/pull/699

From duke at openjdk.org  Sat Jan 31 14:55:49 2026
From: duke at openjdk.org (youngledo)
Date: Sat, 31 Jan 2026 14:55:49 GMT
Subject: RFR: 8490: Include numeric types without Persister in
 "Add Filter from Attribute" menu [v5]
In-Reply-To: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
References: <KvWGp_qdylhVNgyGRtbyGsVU8CgukBd2jZypNuRoXAQ=.757886d0-d5fc-4552-9ebd-a46f5ea6a90d@github.com>
Message-ID: <WQnyGWty6e6H8VtA_WUPOVQbmYoSq0_AyJxgxNx0W7k=.f54386e9-2f53-4db4-8ad7-d8eef1b7b1f4@github.com>

> ### Problem
> 
>   Attributes with numeric ContentTypes that don't have a Persister (such as primitive types: byte, short, int, long, float, double, char) are
>   excluded from the "Add Filter from Attribute" context menu in the Event Browser's filter editor.
> 
> #### Steps to reproduce:
>   1. Open a JFR file containing events with primitive numeric fields (e.g., Spring Framework's FlightRecorderStartupEvent with long eventId and
>   long parentId)
>   2. In Event Browser, right-click on a column ? Select "Show Filter"
>   3. Right-click on the filter area ? Select "Add Filter from Attribute"
>   4. Expected: All filterable attributes should appear in the menu
>   5. Actual: Primitive numeric type attributes are missing from the menu
> 
> <img width="2420" height="1362" alt="image" src="https://github.com/user-attachments/assets/70bcb795-7a7b-42f0-a83e-e34cb8e50361" />
> 
> #### Root Cause
> 
>   The getPersistableAttributes() method in DataPageToolkit.java (line 1006-1007) filters attributes based on whether their ContentType has a
>   Persister:
> 
>   ```java
>   .filter(a -> a.equals(JfrAttributes.EVENT_TYPE) || (a.getContentType() instanceof RangeContentType)
>       || (a.getContentType().getPersister() != null))
>   ```
> 
>   However, primitive numeric types use these ContentTypes which don't have a Persister:
>   - UnitLookup.RAW_NUMBER - used by all primitive numeric types (byte, short, int, long, float, double, char)
>   - UnitLookup.RAW_LONG - used by some custom Long attributes
>   - UnitLookup.COUNT, UnitLookup.INDEX, UnitLookup.IDENTIFIER - legacy numeric types
> 
>   These types return null from getPersister() (see ContentType.java:99-101), causing them to be filtered out.
> 
> ### Why this is incorrect:
> 
>   Even though these types cannot be persisted to strings, they fully support filtering via ItemFilters.equals(). Excluding them from the filter
>   menu is inconsistent with their actual capabilities.
> 
> ### Solution
> 
>   Add a helper method isFilterableNumericType() to identify numeric ContentTypes that support filtering even without a Persister, and include them
>    in the filter:
> 
> private static boolean isFilterableNumericType(IAttribute<?> attribute) {
>       org.openjdk.jmc.common.unit.ContentType<?> ct = attribute.getContentType();
>       return ct.equals(UnitLookup.RAW_NUMBER) || ct.equals(UnitLookup.RAW_LONG)|| ct.equals(UnitLookup.COUNT) || ct.equals(UnitLookup.INDEX)
>               || ct.equals(UnitLookup.IDENTIFIER);
>   }
> 
> 
> Update the filter condition to include these types:
> 
>   .filter(a -> a.equals(...

youngledo has updated the pull request incrementally with two additional commits since the last revision:

 - Update copyright year to 2026
 - Remove .claude/settings.local.json from version control
   
   This file should not be tracked as it contains local settings.
   Added .claude/ to .gitignore to prevent future commits.
   
   Co-Authored-By: Claude Sonnet 4.5 <noreply at anthropic.com>

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/699/files
  - new: https://git.openjdk.org/jmc/pull/699/files/3ba082fa..271713e9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=699&range=04
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=699&range=03-04

  Stats: 49 lines in 4 files changed: 3 ins; 44 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/699.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/699/head:pull/699

PR: https://git.openjdk.org/jmc/pull/699