RFR: Deprecate -sc, -tc, -otss options
Sergey Kuksenko
sergey.kuksenko at oracle.com
Wed Aug 21 11:35:19 PDT 2013
Agreed.
I used these options some time ago and realized that they are not
convenient for main purpose - scalability measurement. I switched to
customs scripts long time ago. And all code around is really awful.
On 08/21/2013 09:41 PM, Aleksey Shipilev wrote:
> Hi,
>
> This is the heads up / review request for pending code sweep work.
>
> This time, we clean up JMH runners. The runner code was over-patched
> over the years, and now looks like a fur ball of scaling, thread count,
> and thread sub-statistics code.
>
> We don't see the seasoned users of these options. Also, in the wake of
> Java API for JMH which will allow to access different benchmark modes
> via the usual API, these options become the burden we don't see a clear
> value to support.
>
> Please speak up if you think otherwise.
>
> Here is the changeset:
> http://cr.openjdk.java.net/~shade/jmh/deprecate-sc-tc-otss-1.changeset
>
> $ diffstat jmh/deprecate-sc-tc-otss-1.changeset
>> a/jmh-core-it/src/test/java/org/openjdk/jmh/it/bulkwarmup/WarmupMode7_Test.java | 105 ---
>> a/jmh-core-it/src/test/java/org/openjdk/jmh/it/bulkwarmup/WarmupMode8_Test.java | 105 ---
>> a/jmh-core/src/main/java/org/openjdk/jmh/runner/parameters/ThreadIterationParams.java | 65 --
>> b/jmh-core/src/main/java/org/openjdk/jmh/output/format/IterationType.java | 30 +
>> jmh-core/src/main/java/org/openjdk/jmh/output/format/CsvFormat.java | 22
>> jmh-core/src/main/java/org/openjdk/jmh/output/format/OutputFormat.java | 33 -
>> jmh-core/src/main/java/org/openjdk/jmh/output/format/PrettyPrintFormat.java | 95 +--
>> jmh-core/src/main/java/org/openjdk/jmh/output/format/SilentFormat.java | 19
>> jmh-core/src/main/java/org/openjdk/jmh/output/format/TextReportFormat.java | 8
>> jmh-core/src/main/java/org/openjdk/jmh/runner/BaseMicroBenchmarkHandler.java | 2
>> jmh-core/src/main/java/org/openjdk/jmh/runner/BaseRunner.java | 288 ++++------
>> jmh-core/src/main/java/org/openjdk/jmh/runner/ForkedRunner.java | 12
>> jmh-core/src/main/java/org/openjdk/jmh/runner/Runner.java | 175 ++----
>> jmh-core/src/main/java/org/openjdk/jmh/runner/options/BaseOptions.java | 49 -
>> jmh-core/src/main/java/org/openjdk/jmh/runner/parameters/IterationParams.java | 20
>> jmh-core/src/main/java/org/openjdk/jmh/runner/parameters/MicroBenchmarkParameters.java | 19
>> jmh-core/src/main/java/org/openjdk/jmh/runner/parameters/MicroBenchmarkParametersFactory.java | 281 +--------
>> jmh-core/src/test/java/org/openjdk/jmh/runner/options/TestOptions.java | 84 --
>> 18 files changed, 319 insertions(+), 1093 deletions(-)
>
> Thanks,
> Aleksey.
>
--
Best regards,
Sergey Kuksenko
More information about the jmh-dev
mailing list