Exception in Runner when more than two params declared
Robert Wicke
rwicke at gmail.com
Mon Apr 28 20:51:52 UTC 2014
Hi Aleksey,
Excellent! Thanks for the quick turnaround.
Sorry, I wasn’t aware of the OCA requirement. I’ll make sure that’s in place before I submit any other patches.
— Rob
On 28 Apr 2014, at 21:39, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> Hi Robert,
>
> On 04/29/2014 12:06 AM, Robert Wicke wrote:
>> Using jmh 0.6 I ran into an issue in Runner when trying to execute a
>> benchmark class that annotates more than two fields with @Param. I
>> get an exception like the following:
>
> Thanks for the bug report! Reproduced with three int @Params. I thought
> we got rid of those...
>
>> The problem is in the explodeAllParams method in Runner. The
>> following one-liner fixes it:
>
> Not saying your fix is wrong, I think that code deserves a bit of
> rewriting. Fixed:
> http://hg.openjdk.java.net/code-tools/jmh/rev/bbcfceb0091c
>
> We plan promote it with 0.6.1 this week; you can use bleeding edge
> meanwhile.
>
> Thanks again,
> -Aleksey.
>
> P.S. Please be advised that if you want us to include your code in
> OpenJDK, we need your signed OCA: http://openjdk.java.net/contribute/.
> It does not apply now because we did not include any of your code, but
> please submit OCA if you (hopefully) plan to contribute something else.
More information about the jmh-dev
mailing list