hg: code-tools/jmh: utils: cleanup with FileUtils.safelyClose.

Bernd Eckenfels ecki at zusammenkunft.net
Tue Jul 1 20:14:50 UTC 2014


Hello,

I would propose to call that method unsafelyClose() ;)

Seriously, swallowing IOExceptions on output streams make me itch.
Might not be a problem for the cases here. And the flush looks
redundant to me.

Gruss
Bernd


Am Tue, 01 Jul 2014 16:57:40 +0000
schrieb aleksey.shipilev at oracle.com:

> Changeset: f8da27da18fd
> Author:    shade
> Date:      2014-07-01 20:55 +0400
> URL:       http://hg.openjdk.java.net/code-tools/jmh/rev/f8da27da18fd
> 
> utils: cleanup with FileUtils.safelyClose.
> 
> !
> jmh-core/src/main/java/org/openjdk/jmh/profile/LinuxPerfAsmProfiler.java !
> jmh-core/src/main/java/org/openjdk/jmh/runner/link/BinaryLinkClient.java !
> jmh-core/src/main/java/org/openjdk/jmh/util/FileUtils.java !
> jmh-generator-asm/src/main/java/org/openjdk/jmh/generators/asm/ASMGeneratorSource.java
> 



More information about the jmh-dev mailing list