Overriding benchmark method metadata does not work

Aggelos Biboudis biboudis at gmail.com
Wed Mar 18 17:51:04 UTC 2015


Hi all,

Yeap. It is definitely related to 7901009. My patch is partially complete (
http://cgi.di.uoa.gr/~biboudis/cr/jmh/CODETOOLS-7901009/)

I wanted to check some corner cases. I will finalize it asap.

Cheers,
Aggelos.

On Tue, Mar 17, 2015 at 10:37 PM, Aleksey Shipilev <
aleksey.shipilev at oracle.com> wrote:

> Hi Josef,
>
> On 17.03.2015 11:40, Jozef Hartinger wrote:
> > but then I get:
> > "Benchmark1.java:[33,20] Internal error: multiple methods per @Group,
> > but not all methods have @Group"
>
> I think this is similar to:
>  https://bugs.openjdk.java.net/browse/CODETOOLS-7901009
>
> Aggelos is experimenting with the fixes for that.
>
> > I think that if a method is overriden, the metadata present on the
> > overriding method should override the original metadata. WDYT?
>
> So, the metadata on overriding methods is probably get FUBARed because
> of the issue above. The workaround for your case would be to put the
> metadata on the class level. In that case, the metadata on the subclass
> will take precedence over the superclass metadata.
>
> Thanks,
> -Aleksey
>
>
>


More information about the jmh-dev mailing list