Possible FileHandle leak in BenchmarkGenerator
Aleksey Shipilev
aleksey.shipilev at oracle.com
Tue May 3 16:54:05 UTC 2016
On 05/03/2016 04:26 PM, Alex Blewitt wrote:
> If you're making changes to the FileUtils you might want to add a
> close safe method for Closeable - there's a leak of a URLClassloader
> in ClassUtils::loadClass - but that's a separate issue and unrelated
> to the benchmark list. Of course since both reader and writer are
> Closesables you might get away with one method (or two to preserve
> backward compatibility with the prior version)
Right. We should have done generic versions for Closeable/Flushable from
day one. This is our internal API, we don't care about compatibility. Fixed:
http://hg.openjdk.java.net/code-tools/jmh/rev/ccd7a1d6f9d0
-Aleksey
More information about the jmh-dev
mailing list