Problematic use of setAccessible

[Claes Redestad]

On 2016-09-15 13:37, Aleksey Shipilev wrote:
> On 09/15/2016 11:35 AM, Claes Redestad wrote:
>> On 2016-09-15 07:53, Aleksey Shipilev wrote:
>>> On 09/14/2016 10:52 PM, Claes Redestad wrote:
>>>> Better yet: adding something to that effect to the manifest is supported
>>>> and might be a transparent and backwards-compatible solution, e.g., in
>>>> the pom.xml:
>>> This is worse: people run JMH workloads via Java API and their own
>>> builders, bypassing the uberjars with our custom manifests.
>> Sure, but there'd still be a documented way around it. Maybe we should
>> catch InaccessibleObjectException[1], print a warning/pointer to
>> workarounds, then move on with Charset.defaultCharset()?
> I think we can plug the leak that way for a time being:
>    http://cr.openjdk.java.net/~shade/jmh/jigsaw-charsets-plug-1.patch
>
> Unfortunately, can't test jake now (slow internet connection), can you
> try it?

Looks good to me, perfasm arrows and everything.

Thanks!

/Claes

>
> Thanks,
> -Aleksey
>