DTrace asm profiler for Mac OS X

[Henri Tremblay]

I confirm. It works perfectly. This is awesome!

So, the only thing that I could complain about is the error message:

ERROR: No address lines detected in assembly capture, make sure your JDK is
PrintAssembly-enabled:
    https://wiki.openjdk.java.net/display/HotSpot/PrintAssembly

It's on the wiki but the way it's phrased, I was thinking +PrintAssembly.
And nothing else. I will suggest this:

ERROR: No address lines detected in assembly capture. Make sure your JDK is
properly configured to print assembly. For details, see the link below
    https://wiki.openjdk.java.net/display/HotSpot/PrintAssembly

On 22 January 2018 at 13:43, Henri Tremblay <henri.tremblay at gmail.com>
wrote:

> I'm on it. I think I've lost my hsdis configuration and haven't noticed.
> So I'm quite confident it should work after that. And yes, you can then
> improve the error message
>
> On 22 January 2018 at 12:08, Aleksey Shipilev <shade at redhat.com> wrote:
>
>> On 01/20/2018 08:52 PM, Vsevolod Tolstopyatov wrote:
>> >>Vsevolod, can you please post the recent version of the patch inline
>> here?
>> >
>> > Here it is. Note that I've changed one line: "String[] splits =
>> line.split(" ");" -> "String[]
>> > splits = line.split(" ", 5);" to properly handle native symbols
>> (especially ones from libjvm.dylib).
>> > Retested again on JMH samples + VM-heavy benchmarks (String#intern,
>> exceptions)
>>
>> Pushed:
>>   https://bugs.openjdk.java.net/browse/CODETOOLS-7902097
>>
>> Once you and Henry figure out what is wrong with his environment, please
>> do a follow-up patch that
>> would provide a helpful failure message or such?
>>
>> Thanks,
>> -Aleksey
>>
>>
>