Patch: do not report percentiles that are just the maximum
Erich Schubert
erich at debian.org
Wed Sep 26 15:42:45 UTC 2018
Hi,
Quick follow up to my previous email today (numeric resolution of aux
counters): I probably was wrong - the counters may simply have tailing
0s, so the precision should be fine within double precision bounds (good
enough for me).
> This makes sense. Let me see if that works.
>
> Contribution wrinkle: OpenJDK patch acceptance rules need your OCA, as per
> http://openjdk.java.net/contribute. Once you appear on this list:
> https://www.oracle.com/technetwork/community/oca-486395.html -- we can accept the patch as is.
Sorry, I can't sign this general waiver. I cannot trust Oracle - they've
ruined too many projects already (OpenOffice, OpenSolaris, MySQL, ...).
But the actual changes are trivial enough to not require a contributors
agreement.
public double getMaxPercentile() { return 100 - 100. / (count + 1); }
clearly is a trivial contribution, and does not need an CA. And you may
want to refactor the redundancies in the percentile loops anyway, and
probably want to refresh the unit tests yourself anyway.
If there is only a single sample (e.g. in single shot mode), it may also
be desirable to omit the entire percentiles section.
Regards,
Erich
More information about the jmh-dev
mailing list