[patch] JFR profiler

Jason Zaugg jzaugg at gmail.com
Thu Aug 13 02:30:45 UTC 2020


On Mon, 10 Aug 2020 at 19:40, Aleksey Shipilev <shade at redhat.com> wrote:
>
> On 8/6/20 5:47 AM, Jason Zaugg wrote:
> > I'd like to contribute a profiler that collects Java Flight Recorder profiles.
>
> Thank you!
>
> I did a few polishings here:
>   https://cr.openjdk.java.net/~shade/jmh/jfr-profiler-polish.patch
>
> If those polishings look good for you, I can push the whole thing. I also verified it works with
> OpenJDK 8u that recently got JFR (and which does not require -XX:+UnlockCommercialFeatures).
>
> One substantial change is dropping -XX:+IgnoreUnrecognizedVMOptions. I believe profiler should just
> fail hard if target VM does not accept -XX:+FlightRecorder. Or maybe I am missing something?

Those changes look good, thanks.

I was reluctant to get into the business of parsing JVM version
strings but the end result is cleaner.

-jason


More information about the jmh-dev mailing list