RFR: 7902808: Batch size tests still fail due to numerical and timing issues [v2]

Aleksey Shipilev shade at openjdk.java.net
Tue Dec 8 17:43:34 UTC 2020


> Current batch size tests are still flaky, experiencing intermittent failures in GH actions. It seems to be caused by individual timing measurements per @Benchmark. If test are stalled outside of that measurement, the sum of individual measurements can be much lower than the actual wall clock time.
> 
> But what's significantly worse, the operation handling *divides* real operation count by batch size, which is subject to gross rounding errors, as the division happens in long domain. Changing that to double should be enough to regain the accuracy.

Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:

  Reduce API changes

-------------

Changes:
  - all: https://git.openjdk.java.net/jmh/pull/13/files
  - new: https://git.openjdk.java.net/jmh/pull/13/files/28d02a82..685670ea

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jmh&pr=13&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jmh&pr=13&range=00-01

  Stats: 26 lines in 9 files changed: 0 ins; 0 del; 26 mod
  Patch: https://git.openjdk.java.net/jmh/pull/13.diff
  Fetch: git fetch https://git.openjdk.java.net/jmh pull/13/head:pull/13

PR: https://git.openjdk.java.net/jmh/pull/13


More information about the jmh-dev mailing list