RFR: CODETOOLS-7902799: perfasm still handles event modifiers incorrectly [v2]
Volker Simonis
simonis at openjdk.java.net
Thu Nov 26 10:32:18 UTC 2020
On Wed, 25 Nov 2020 19:22:09 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Added back test for tag parsing
>
> jmh-core/src/test/java/org/openjdk/jmh/profile/PerfParseTest.java line 65:
>
>> 63: }
>> 64:
>> 65: @Test
>
> Please don't remove this test. It should verify that it parses the proper event names, now with event modifiers. This would verify that `:` are parsed/stripped correctly.
Sure, I've added the test back.
-------------
PR: https://git.openjdk.java.net/jmh/pull/9
More information about the jmh-dev
mailing list