RFR: Runner: if -Djmh.ignoreLock=true then skip jmh.lock creation [v2]
Aleksey Shipilev
shade at openjdk.java.net
Wed Oct 21 08:51:55 UTC 2020
On Wed, 21 Oct 2020 08:47:28 GMT, Sergey Ponomarev <github.com+415502+stokito at openjdk.org> wrote:
>> When -Djmh.ignoreLock=true JMH anyway will try to create the jmh.lock file and if it fails it will write a warning for an user.
>> This may be not a best way for several reasons:
>> 1. If user specified ignoreLock then he already knows what she or he doing.
>> 2. If the Benchmark is started from IDE i.e idea-jmh-plugin and the ignoreLock was added automatically then users may be confused by this warning
>> 3. It makes execution slightly longer when we anyway trying to create the jmh.lock file
>> 4. This simplifies logic
>
> Sergey Ponomarev has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>
> Runner: if -Djmh.ignoreLock=true then skip jmh.lock creation
>
> Signed-off-by: Sergey Ponomarev <stokito at gmail.com>
Marked as reviewed by shade (Committer).
-------------
PR: https://git.openjdk.java.net/jmh/pull/6
More information about the jmh-dev
mailing list