Integrated: Runner: if -Djmh.ignoreLock=true then skip jmh.lock creation

Sergey Ponomarev github.com+415502+stokito at openjdk.java.net
Wed Oct 21 09:11:57 UTC 2020


On Wed, 21 Oct 2020 08:12:42 GMT, Sergey Ponomarev <github.com+415502+stokito at openjdk.org> wrote:

> When -Djmh.ignoreLock=true JMH anyway will try to create the jmh.lock file and if it fails it will write a warning for an user.
> This may be not a best way for several reasons:
> 1. If user specified ignoreLock then he already knows what she or he doing.
> 2. If the Benchmark is started from IDE i.e idea-jmh-plugin and the ignoreLock was added automatically then users may be confused by this warning
> 3. It makes execution slightly longer when we anyway trying to create the jmh.lock file
> 4. This simplifies logic

This pull request has now been integrated.

Changeset: 57bb8c87
Author:    Sergey Ponomarev <stokito at gmail.com>
Committer: Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jmh/commit/57bb8c87
Stats:     17 lines in 1 file changed: 4 ins; 11 del; 2 mod

Runner: if -Djmh.ignoreLock=true then skip jmh.lock creation

Reviewed-by: shade

-------------

PR: https://git.openjdk.java.net/jmh/pull/6


More information about the jmh-dev mailing list