RFR: 7903067: JMH: Improve English grammar in error messages [v3]

Aarre Laakso duke at openjdk.java.net
Thu Dec 2 22:48:02 UTC 2021


On Thu, 2 Dec 2021 22:23:29 GMT, Richard Startin <duke at openjdk.java.net> wrote:

>> jmh-core/src/main/java/org/openjdk/jmh/generators/core/BenchmarkGenerator.java line 321:
>> 
>>> 319:                 throw new GenerationException("@" + Threads.class.getSimpleName() + " annotation is placed within " +
>>> 320:                         "the benchmark method with @" + Group.class.getSimpleName() + " annotation. " +
>>> 321:                         "This has ambiguous behavioral effect and is prohibited. " +
>> 
>> I would change this to "this is prohibited because it is ambiguous."
>
> the correct article on line 320 would be "**a** benchmark method with @"

Thank you. I made these changes.

-------------

PR: https://git.openjdk.java.net/jmh/pull/56


More information about the jmh-dev mailing list