RFR: CODETOOLS-7902825: Generated BenchmarkList file should be sorted for reproducibility [v2]
Claes Redestad
redestad at openjdk.java.net
Thu Feb 18 11:23:45 UTC 2021
On Thu, 18 Feb 2021 10:58:13 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> As stated in the RFE, JMH should sort BenchmarkListEntries before writing them out. It is cleaner to do in `BenchmarkList` itself, as it allows unit testing.
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'master' into CODETOOLS-7902825-sort-list
> - reversed -> mixed
> - Initial revision
Thanks for picking this up! Changes looks good to me.
-------------
Marked as reviewed by redestad (no project role).
PR: https://git.openjdk.java.net/jmh/pull/19
More information about the jmh-dev
mailing list