RFR: CODETOOLS-7902829: JMH Statistics implementations do not follow Comparable spec [v2]
Aleksey Shipilev
shade at openjdk.java.net
Thu Feb 18 12:21:05 UTC 2021
> `Comparable.compareTo` spec says: "Returns a negative integer, zero, or a positive integer as this object is less than, equal to, or greater than the specified object."
>
> Unfortunately, that is not followed by JMH Statistics, because they get the order wrong. The tests that are supposed to catch this are also wrong.
Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Merge branch 'master' into CODETOOLS-7902829-statistics-compareTo
- CODETOOLS-7902829: JMH Statistics implementations do not follow Comparable spec
-------------
Changes:
- all: https://git.openjdk.java.net/jmh/pull/21/files
- new: https://git.openjdk.java.net/jmh/pull/21/files/4da65326..ca239b19
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jmh&pr=21&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jmh&pr=21&range=00-01
Stats: 111 lines in 3 files changed: 105 ins; 1 del; 5 mod
Patch: https://git.openjdk.java.net/jmh/pull/21.diff
Fetch: git fetch https://git.openjdk.java.net/jmh pull/21/head:pull/21
PR: https://git.openjdk.java.net/jmh/pull/21
More information about the jmh-dev
mailing list