RFR: CODETOOLS-7902825: Generated BenchmarkList file should be sorted for reproducibility [v2]

Claes Redestad redestad at openjdk.java.net
Thu Feb 18 12:25:44 UTC 2021


On Thu, 18 Feb 2021 11:57:27 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Did you need a formal Reviewer pre-skara? If not it seems like a bug that you couldn't /integrate here.
>
>> Did you need a formal Reviewer pre-skara? If not it seems like a bug that you couldn't /integrate here.
> 
> Yeah, Skara wants the formal Committer in Code Tools project, see `.jcheck/conf`. But, since you are not a formal Committer in Code Tools, your review does not count. And my own review does not count for my own PRs. If this was your PR, you would have been able to `/integrate` with my review.

Yeah, at least I don't need a formal role to create a PR. Still, I do think we'd all be better off if the Code Tools project was formally subsumed into the main JDK project, at least w.r.t. roles (keep the separate JBS project and distinct repositories..)

-------------

PR: https://git.openjdk.java.net/jmh/pull/19


More information about the jmh-dev mailing list