Integrated: CODETOOLS-7902853: JMH: Fix lint and deprecation warnings

[Niels Basjes]

On Mon, 15 Mar 2021 10:57:08 GMT, Niels Basjes <github.com+240096+nielsbasjes at openjdk.org> wrote:

> In my projects I always use -Werror as the compiler flag as one of the means to get a high standard for code quality.
> In this project https://github.com/nielsbasjes/yauaa I have a module that does the benchmarks.
> When I update the JMH from 1.26 to 1.28 my build fails with 
> [WARNING] COMPILATION WARNING : 
> [INFO] -------------------------------------------------------------
> [WARNING] /home/nbasjes/workspace/Prive/yauaa_/benchmarks/target/generated-sources/annotations/nl/basjes/parse/useragent/benchmarks/jmh_generated/AnalyzerBenchmarks_android6Chrome46_jmhTest.java:[324,67] redundant cast to long
> [WARNING] /home/nbasjes/workspace/Prive/yauaa_/benchmarks/target/generated-sources/annotations/nl/basjes/parse/useragent/benchmarks/jmh_generated/AnalyzerBenchmarks_android6Chrome46_jmhTest.java:[324,83] redundant cast to long
> [WARNING] /home/nbasjes/workspace/Prive/yauaa_/benchmarks/target/generated-sources/annotations/nl/basjes/parse/useragent/benchmarks/jmh_generated/AnalyzerBenchmarks_androidPhone_jmhTest.java:[324,67] redundant cast to long
> [WARNING] /home/nbasjes/workspace/Prive/yauaa_/benchmarks/target/generated-sources/annotations/nl/basjes/parse/useragent/benchmarks/jmh_generated/AnalyzerBenchmarks_androidPhone_jmhTest.java:[324,83] redundant cast to long
> and at the end it fails
> [ERROR] COMPILATION ERROR : 
> [INFO] -------------------------------------------------------------
> [ERROR] /home/nbasjes/workspace/Prive/yauaa_/benchmarks/target/generated-sources/annotations/nl/basjes/parse/useragent/benchmarks/jmh_generated/AnalyzerBenchmarks_android6Chrome46_jmhTest.java: warnings found and -Werror specified
> [INFO] 1 error
> 
> Turns out this problem is caused by a change in code generated by JMH.
> 
> This pull request fixes this problem.

This pull request has now been integrated.

Changeset: 73a33e75
Author:    Niels Basjes <niels at basjes.nl>
Committer: Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jmh/commit/73a33e75
Stats:     272 lines in 109 files changed: 50 ins; 0 del; 222 mod

7902853: JMH: Fix lint and deprecation warnings

Co-authored-by: Aleksey Shipilev <shade at openjdk.org>
Reviewed-by: shade

-------------

PR: https://git.openjdk.java.net/jmh/pull/31