RFR: CODETOOLS-7902928: Improve support for async-profiler 2.x [v2]

Jason Zaugg jzaugg at openjdk.java.net
Mon May 10 21:50:05 UTC 2021


On Mon, 10 May 2021 09:40:50 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Jason Zaugg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixup: remove incorrect/unneeded 'reset' argument
>
> jmh-core/src/main/java/org/openjdk/jmh/profile/AsyncProfiler.java line 341:
> 
>> 339:                         }
>> 340:                     } catch (IOException e) {
>> 341:                         e.printStackTrace();
> 
> Throw `new ProfilerException(e)` here?

Agreed its better not to swallow. It needs to be an unchecked exception though as this is called from `afterIteration`; I'll wrap in a `RuntimeException`.

-------------

PR: https://git.openjdk.java.net/jmh/pull/37


More information about the jmh-dev mailing list