RFR: CODETOOLS-7902928: Improve support for async-profiler 2.x [v3]

Aleksey Shipilev shade at openjdk.java.net
Tue May 11 13:01:07 UTC 2021


On Tue, 11 May 2021 05:48:26 GMT, Jason Zaugg <jzaugg at openjdk.org> wrote:

>> Allow multiple events to be captured simultaneously in this version,
>> provided that JFR is chosen as output format.
>> 
>> Delegate output file writing to the async-profiler. This is required
>> in 2.x for the JFR output but is supported in both versions. The file
>> path must be provided when starting the profiler with JFR output, so
>> we need to create the per-trial output directory in the first
>> `beforeIteration`.
>> 
>> Avoid the character '%' in the generated directory name as this
>> is interpreted by async-profiler as part %p or %t placeholder.
>
> Jason Zaugg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add cpu,alloc options for use as secondary events

...or maybe not. Please apply the fixes from the review above, and let me look at it again. The multi-option variant was significantly cleaner.

-------------

PR: https://git.openjdk.java.net/jmh/pull/37


More information about the jmh-dev mailing list