RFR: 7903319: The methods 'getAllMethods' and 'getMethods' in class 'BenchmarkGeneratorUtils' have the same feature

Guoxiong Li gli at openjdk.org
Tue Sep 20 15:13:20 UTC 2022


On Tue, 20 Sep 2022 13:36:04 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Hi all,
>> 
>> Currently, the methods `getAllMethods` and `getMethods` in class 'BenchmarkGeneratorUtils' have the same feature. This patch removes `getMethods` and keeps `getAllMethods`  because `getAllMethods` is consistent with `getAllFields`.
>> 
>> Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Looks fine, thanks!

@shipilev Thanks for the review. Could I get your help to sponsor this patch?

-------------

PR: https://git.openjdk.org/jmh/pull/78


More information about the jmh-dev mailing list