RFR: 7903440: JMH: Add automatic module names
Hendrik Ebbers
duke at openjdk.org
Wed Apr 5 10:03:24 UTC 2023
On Mon, 20 Feb 2023 18:05:22 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> `maven-jar-plugin` is used to add "Automatic-Module-Name" to `MANIFEST.MF` at buildtime. This is the minimum that is needed if you want to use the lib on the module path in a project.
>
> I am actually on the fence with this change. Module names are the part of external API, so picking the correct name is important, as it is supposed to remain stable. This is probably okay for JMH, as we seldom change the API to begin with.
>
> I assume you wanted to capture the package names as module names? If so, why `org.openjdk.jmh.core` then? There is no package name like that. Can it be `org.openjdk.jmh`, or does it introduce split packages problem downstream?
@shipilev updated
-------------
PR Comment: https://git.openjdk.org/jmh/pull/90#issuecomment-1497227308
More information about the jmh-dev
mailing list