RFR: 7903448: JMH: Override the use of compiler hints using a system property [v3]

Aleksey Shipilev shade at openjdk.org
Mon Apr 24 08:39:17 UTC 2023


On Fri, 21 Apr 2023 17:33:58 GMT, Gilles Duboscq <gdub at openjdk.org> wrote:

>> Using `-Djmh.compilerhints.mode=true` will force the use of compiler hints. `-Djmh.compilerhints.mode=false` will prevent the use of compiler hints. When the system property is not set, the current beahviour based on vm name and version will be used by default.
>> 
>> This is especially useful when working with uncommon / rare JVMs or when adding compiler hints support to a new JVM.
>> 
>> I considered auto-detecting support for compiler hints but that didn't fit very well in the current code and required much more intrusive changes.
>
> Gilles Duboscq has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Split CompilerHintsSelect.AUTO into AUTO_ON/AUTO_OFF
>   
>   Only print compiler hints status when it is forced

This version looks good!

There are some flukes in GHA testing, but they all seem to be environmental.

-------------

Marked as reviewed by shade (Committer).

PR Review: https://git.openjdk.org/jmh/pull/96#pullrequestreview-1397456837


More information about the jmh-dev mailing list