From duke at openjdk.org  Wed Feb 15 14:12:53 2023
From: duke at openjdk.org (Hendrik Ebbers)
Date: Wed, 15 Feb 2023 14:12:53 GMT
Subject: RFR: automatic module names added (added to MANIFEST at buildtime)
In-Reply-To: <Nb_orv6qjcyvQ6QFR4u2Z168SI-QmavNie9Xgyihqpc=.e8a9a3d2-5ef4-4a72-909c-d22e83e7f9ec@github.com>
References: <Nb_orv6qjcyvQ6QFR4u2Z168SI-QmavNie9Xgyihqpc=.e8a9a3d2-5ef4-4a72-909c-d22e83e7f9ec@github.com>
Message-ID: <AgUiA0G8he8W0gNUSuHjoR5Yy-AsRLVtL0VbF_dHlSU=.fcc32394-62c3-428d-a38c-15fc57a93a27@github.com>

On Wed, 7 Dec 2022 16:43:17 GMT, Hendrik Ebbers <duke at openjdk.org> wrote:

> `maven-jar-plugin` is used to add "Automatic-Module-Name" to `MANIFEST.MF` at buildtime. This is the minimum that is needed if you want to use the lib on the module path in a project.

@shipilev ping :)

-------------

PR: https://git.openjdk.org/jmh/pull/90

From duke at openjdk.org  Mon Feb 20 17:26:31 2023
From: duke at openjdk.org (Seeta Ramayya)
Date: Mon, 20 Feb 2023 17:26:31 GMT
Subject: RFR: Changed help text writing system.out instead of system.error
Message-ID: <V6e_JnwZpNzhiCV74X1sAH6iVQYx-R61HZ1ohQxGl1c=.04e57a51-10a5-4fc7-abed-b53f866f9f36@github.com>

I do not know the reason for using `System.err` for `help or -h`. I was expecting it to be in standard out not in error. 

Either of the things needs to be happen: 

- If it has to be `System.error` (for some reason) then it should be mentioned in `ReadMe.md` so that people like me does not get confused.
- If it is `System.out` then PR needs to be merged :)  

Change is just `3` characters so I did not report any issue before creating PR.

-------------

Commit messages:
 - Help text is not error message

Changes: https://git.openjdk.org/jmh/pull/95/files
 Webrev: https://webrevs.openjdk.org/?repo=jmh&pr=95&range=00
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmh/pull/95.diff
  Fetch: git fetch https://git.openjdk.org/jmh pull/95/head:pull/95

PR: https://git.openjdk.org/jmh/pull/95

From shade at openjdk.org  Mon Feb 20 17:49:53 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Mon, 20 Feb 2023 17:49:53 GMT
Subject: RFR: 7903439: JMH: Print help to stdout instead of stderr
In-Reply-To: <V6e_JnwZpNzhiCV74X1sAH6iVQYx-R61HZ1ohQxGl1c=.04e57a51-10a5-4fc7-abed-b53f866f9f36@github.com>
References: <V6e_JnwZpNzhiCV74X1sAH6iVQYx-R61HZ1ohQxGl1c=.04e57a51-10a5-4fc7-abed-b53f866f9f36@github.com>
Message-ID: <0NvDQqXJzVdmSULhKRW1sdWtKZNJgtXYtADJAomQ3MM=.addbe456-d3ca-4f48-8fc1-7b28c10b7d10@github.com>

On Fri, 17 Feb 2023 09:37:54 GMT, Seeta Ramayya <duke at openjdk.org> wrote:

> I do not know the reason for using `System.err` for `help or -h`. I was expecting it to be in standard out not in error. 
> 
> Either of the things needs to be happen: 
> 
> - If it has to be `System.error` (for some reason) then it should be mentioned in `ReadMe.md` so that people like me does not get confused.
> - If it is `System.out` then PR needs to be merged :)  
> 
> Change is just `3` characters so I did not report any issue before creating PR.

I agree. This looks fine.

For testing, please go to https://github.com/Seetaramayya/jmh/actions and enable the testing workflow.

-------------

Marked as reviewed by shade (Committer).

PR: https://git.openjdk.org/jmh/pull/95

From shade at openjdk.org  Mon Feb 20 17:59:51 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Mon, 20 Feb 2023 17:59:51 GMT
Subject: RFR: 7903440: JMH: Add automatic module names
In-Reply-To: <Nb_orv6qjcyvQ6QFR4u2Z168SI-QmavNie9Xgyihqpc=.e8a9a3d2-5ef4-4a72-909c-d22e83e7f9ec@github.com>
References: <Nb_orv6qjcyvQ6QFR4u2Z168SI-QmavNie9Xgyihqpc=.e8a9a3d2-5ef4-4a72-909c-d22e83e7f9ec@github.com>
Message-ID: <q9G-45NUsOXpVq7OaZQYa5slrp3iMpc4QpNJY77X7sg=.a8b63916-b663-465e-8b90-2c97df9b0ab3@github.com>

On Wed, 7 Dec 2022 16:43:17 GMT, Hendrik Ebbers <duke at openjdk.org> wrote:

> `maven-jar-plugin` is used to add "Automatic-Module-Name" to `MANIFEST.MF` at buildtime. This is the minimum that is needed if you want to use the lib on the module path in a project.

Please go to https://github.com/hendrikebbers/jmh/actions -- and enable the testing workflows there? You would probably want to merge from the current master to get all the fixes in.

-------------

PR: https://git.openjdk.org/jmh/pull/90

From shade at openjdk.org  Mon Feb 20 18:07:56 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Mon, 20 Feb 2023 18:07:56 GMT
Subject: RFR: 7903440: JMH: Add automatic module names
In-Reply-To: <Nb_orv6qjcyvQ6QFR4u2Z168SI-QmavNie9Xgyihqpc=.e8a9a3d2-5ef4-4a72-909c-d22e83e7f9ec@github.com>
References: <Nb_orv6qjcyvQ6QFR4u2Z168SI-QmavNie9Xgyihqpc=.e8a9a3d2-5ef4-4a72-909c-d22e83e7f9ec@github.com>
Message-ID: <e8pQi6XBqUryQ5xfZhprWmrpklZ15fUAbaEi19WagD8=.bfd79446-5719-49da-8764-66d9758a393d@github.com>

On Wed, 7 Dec 2022 16:43:17 GMT, Hendrik Ebbers <duke at openjdk.org> wrote:

> `maven-jar-plugin` is used to add "Automatic-Module-Name" to `MANIFEST.MF` at buildtime. This is the minimum that is needed if you want to use the lib on the module path in a project.

I am actually on the fence with this change. Module names are the part of external API, so picking the correct name is important, as it is supposed to remain stable. This is probably okay for JMH, as we seldom change the API to begin with.

I assume you wanted to capture the package names as module names? If so, why `org.openjdk.jmh.core` then? There is no package name like that. Can it be `org.openjdk.jmh`, or does it introduce split packages problem downstream?

-------------

PR: https://git.openjdk.org/jmh/pull/90

From duke at openjdk.org  Mon Feb 20 21:25:20 2023
From: duke at openjdk.org (Seeta Ramayya)
Date: Mon, 20 Feb 2023 21:25:20 GMT
Subject: RFR: 7903439: JMH: Print help to stdout instead of stderr [v2]
In-Reply-To: <V6e_JnwZpNzhiCV74X1sAH6iVQYx-R61HZ1ohQxGl1c=.04e57a51-10a5-4fc7-abed-b53f866f9f36@github.com>
References: <V6e_JnwZpNzhiCV74X1sAH6iVQYx-R61HZ1ohQxGl1c=.04e57a51-10a5-4fc7-abed-b53f866f9f36@github.com>
Message-ID: <XJendY5IO0Kx8-LuYBOcrAirwDirFKV3DpP3_QgSm1g=.330429cb-92f0-4ea5-ae01-807dd891c6cc@github.com>

> I do not know the reason for using `System.err` for `help or -h`. I was expecting it to be in standard out not in error. 
> 
> Either of the things needs to be happen: 
> 
> - If it has to be `System.error` (for some reason) then it should be mentioned in `ReadMe.md` so that people like me does not get confused.
> - If it is `System.out` then PR needs to be merged :)  
> 
> Change is just `3` characters so I did not report any issue before creating PR.

Seeta Ramayya has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Help text is not error message

-------------

Changes:
  - all: https://git.openjdk.org/jmh/pull/95/files
  - new: https://git.openjdk.org/jmh/pull/95/files/253b7704..54d1c0ce

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmh&pr=95&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmh&pr=95&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmh/pull/95.diff
  Fetch: git fetch https://git.openjdk.org/jmh pull/95/head:pull/95

PR: https://git.openjdk.org/jmh/pull/95

From duke at openjdk.org  Tue Feb 21 07:14:53 2023
From: duke at openjdk.org (Sherzod Mamadaliev)
Date: Tue, 21 Feb 2023 07:14:53 GMT
Subject: RFR: 7903439: JMH: Print help to stdout instead of stderr [v2]
In-Reply-To: <XJendY5IO0Kx8-LuYBOcrAirwDirFKV3DpP3_QgSm1g=.330429cb-92f0-4ea5-ae01-807dd891c6cc@github.com>
References: <V6e_JnwZpNzhiCV74X1sAH6iVQYx-R61HZ1ohQxGl1c=.04e57a51-10a5-4fc7-abed-b53f866f9f36@github.com>
 <XJendY5IO0Kx8-LuYBOcrAirwDirFKV3DpP3_QgSm1g=.330429cb-92f0-4ea5-ae01-807dd891c6cc@github.com>
Message-ID: <CByAVFSZUaTkYTauOpyCHbIaVS_RRfIRDn0W1Tq5Skg=.5eae612e-1f5f-4882-96f3-cdcbc4c902a8@github.com>

On Mon, 20 Feb 2023 21:25:20 GMT, Seeta Ramayya <duke at openjdk.org> wrote:

>> I do not know the reason for using `System.err` for `help or -h`. I was expecting it to be in standard out not in error. 
>> 
>> Either of the things needs to be happen: 
>> 
>> - If it has to be `System.error` (for some reason) then it should be mentioned in `ReadMe.md` so that people like me does not get confused.
>> - If it is `System.out` then PR needs to be merged :)  
>> 
>> Change is just `3` characters so I did not report any issue before creating PR.
>
> Seeta Ramayya has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Help text is not error message

Marked as reviewed by mamadaliev at github.com (no known OpenJDK username).

-------------

PR: https://git.openjdk.org/jmh/pull/95

From shade at openjdk.org  Tue Feb 21 09:25:57 2023
From: shade at openjdk.org (Aleksey Shipilev)
Date: Tue, 21 Feb 2023 09:25:57 GMT
Subject: RFR: 7903439: JMH: Print help to stdout instead of stderr [v2]
In-Reply-To: <XJendY5IO0Kx8-LuYBOcrAirwDirFKV3DpP3_QgSm1g=.330429cb-92f0-4ea5-ae01-807dd891c6cc@github.com>
References: <V6e_JnwZpNzhiCV74X1sAH6iVQYx-R61HZ1ohQxGl1c=.04e57a51-10a5-4fc7-abed-b53f866f9f36@github.com>
 <XJendY5IO0Kx8-LuYBOcrAirwDirFKV3DpP3_QgSm1g=.330429cb-92f0-4ea5-ae01-807dd891c6cc@github.com>
Message-ID: <_Pa-6Zu5itZs1dxqWmKKdXbP6kvyUPDOp7Ufn-yf-ec=.0be34b83-68c3-4320-b43a-c2b87cc8246f@github.com>

On Mon, 20 Feb 2023 21:25:20 GMT, Seeta Ramayya <duke at openjdk.org> wrote:

>> I do not know the reason for using `System.err` for `help or -h`. I was expecting it to be in standard out not in error. 
>> 
>> Either of the things needs to be happen: 
>> 
>> - If it has to be `System.error` (for some reason) then it should be mentioned in `ReadMe.md` so that people like me does not get confused.
>> - If it is `System.out` then PR needs to be merged :)  
>> 
>> Change is just `3` characters so I did not report any issue before creating PR.
>
> Seeta Ramayya has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Help text is not error message

Looks fine, @Seetaramayya, you need to say `/integrate`.

-------------

PR: https://git.openjdk.org/jmh/pull/95

From duke at openjdk.org  Tue Feb 21 09:41:01 2023
From: duke at openjdk.org (Seeta Ramayya)
Date: Tue, 21 Feb 2023 09:41:01 GMT
Subject: Integrated: 7903439: JMH: Print help to stdout instead of stderr
In-Reply-To: <V6e_JnwZpNzhiCV74X1sAH6iVQYx-R61HZ1ohQxGl1c=.04e57a51-10a5-4fc7-abed-b53f866f9f36@github.com>
References: <V6e_JnwZpNzhiCV74X1sAH6iVQYx-R61HZ1ohQxGl1c=.04e57a51-10a5-4fc7-abed-b53f866f9f36@github.com>
Message-ID: <PMUlRYTmmSwMAATMjARC_u56C4kwaHCHfE_2kQXUz_U=.27ffc057-d5dc-4547-9f7b-9f22f68820ed@github.com>

On Fri, 17 Feb 2023 09:37:54 GMT, Seeta Ramayya <duke at openjdk.org> wrote:

> I do not know the reason for using `System.err` for `help or -h`. I was expecting it to be in standard out not in error. 
> 
> Either of the things needs to be happen: 
> 
> - If it has to be `System.error` (for some reason) then it should be mentioned in `ReadMe.md` so that people like me does not get confused.
> - If it is `System.out` then PR needs to be merged :)  
> 
> Change is just `3` characters so I did not report any issue before creating PR.

This pull request has now been integrated.

Changeset: 2f21ef20
Author:    Seetaramayya <3521036+Seetaramayya at users.noreply.github.com>
Committer: Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jmh/commit/2f21ef20d08a01edec2384b9764078151346d446
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

7903439: JMH: Print help to stdout instead of stderr

Reviewed-by: shade

-------------

PR: https://git.openjdk.org/jmh/pull/95

From duke at openjdk.org  Thu Feb 23 16:01:58 2023
From: duke at openjdk.org (Hendrik Ebbers)
Date: Thu, 23 Feb 2023 16:01:58 GMT
Subject: RFR: 7903440: JMH: Add automatic module names
In-Reply-To: <e8pQi6XBqUryQ5xfZhprWmrpklZ15fUAbaEi19WagD8=.bfd79446-5719-49da-8764-66d9758a393d@github.com>
References: <Nb_orv6qjcyvQ6QFR4u2Z168SI-QmavNie9Xgyihqpc=.e8a9a3d2-5ef4-4a72-909c-d22e83e7f9ec@github.com>
 <e8pQi6XBqUryQ5xfZhprWmrpklZ15fUAbaEi19WagD8=.bfd79446-5719-49da-8764-66d9758a393d@github.com>
Message-ID: <M-QWyfkAFjsS7rCe8FNsxnTGOsOepJngytX9ru41tjE=.0a972ea8-67f7-48fe-859d-9b2fcd9b9803@github.com>

On Mon, 20 Feb 2023 18:05:22 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> `maven-jar-plugin` is used to add "Automatic-Module-Name" to `MANIFEST.MF` at buildtime. This is the minimum that is needed if you want to use the lib on the module path in a project.
>
> I am actually on the fence with this change. Module names are the part of external API, so picking the correct name is important, as it is supposed to remain stable. This is probably okay for JMH, as we seldom change the API to begin with.
> 
> I assume you wanted to capture the package names as module names? If so, why `org.openjdk.jmh.core` then? There is no package name like that. Can it be `org.openjdk.jmh`, or does it introduce split packages problem downstream?

@shipilev totally fine with the name change. Will do it and ping you once all checks are green

-------------

PR: https://git.openjdk.org/jmh/pull/90