RFR: CODETOOLS-7903471: JMH: Add test for virtual threads executor [v6]
Sergey Kuksenko
skuksenko at openjdk.org
Thu Jun 1 02:20:30 UTC 2023
On Wed, 31 May 2023 23:10:14 GMT, Sergey Kuksenko <skuksenko at openjdk.org> wrote:
>> Add test for virtual thread executor
>
> Sergey Kuksenko has updated the pull request incrementally with one additional commit since the last revision:
>
> FJP_COMMON issue
Q.E.D.
Benchmarks execution requires many synchronization points between benchmark threads (Not even counting the new synch point I added to solve the "orphaned" worker data issue). Benchmark executor should provide N (a.k.a. -t N) distinct threads; otherwise, a deadlock will happen.
All existing executors provide this except FJP_COMMON.
Now I see two options:
- Completely remove FJP_COMMON
- Preserve FJP_COMMON for the user's risk, but don't create tests covering FJP_COMMON.
-------------
PR Comment: https://git.openjdk.org/jmh/pull/103#issuecomment-1571224646
More information about the jmh-dev
mailing list