RFR: 7903479: JMH: Add .editorconfig so IDEs would pick up the common settings automatically: indent, trim whitespace [v2]
Aleksey Shipilev
shade at openjdk.org
Tue Jun 20 08:55:29 UTC 2023
On Wed, 31 May 2023 08:04:55 GMT, Vladimir Sitnikov <vsitnikov at openjdk.org> wrote:
>> See https://bugs.openjdk.org/browse/CODETOOLS-7903479
>>
>> I tried re-format random files from JMH, and they either kept intact, or the changes were minimal.
>
> Vladimir Sitnikov has updated the pull request incrementally with one additional commit since the last revision:
>
> trigger Actions CI
How ubiquitous it is to provide .editorconfig? Is this what projects do these days as the matter of course?
It feels that providing a formatter style without an agreement on code style and the automatic plugin that enforces the formatting would trigger more work for contributors that _do use .editorconfig_ style, while fixing up the code from contributors that don't. I think status quo is already stable, as we accept reasonably formatted patches from occasional contributions. Enforcing the formatting seems to gain little here.
Maybe I am missing a point here? So, I am willing to let this PR stay open to explore the automatic enforcement, but make no promises about whether it could/should be integrated.
-------------
PR Comment: https://git.openjdk.org/jmh/pull/105#issuecomment-1598378217
More information about the jmh-dev
mailing list