RFR: CODETOOLS-7903471: JMH: Add test for virtual threads executor [v2]

Aleksey Shipilev shade at openjdk.org
Tue May 23 16:50:34 UTC 2023


On Tue, 23 May 2023 16:45:51 GMT, Sergey Kuksenko <skuksenko at openjdk.org> wrote:

>> My point is that we might as well check that methods are executed by the _same virtual thread_, right? So, collect `Thread`-s, check there is only one thread, and optionally check it was virtual.
>
> Ok.
> Also, that means - we don't need this new test class. It's better just to add isVirtual check into existing ones.

Yes, extending all `it/threads` for all executors would give us a good coverage, I think.

-------------

PR Review Comment: https://git.openjdk.org/jmh/pull/103#discussion_r1202702655


More information about the jmh-dev mailing list