RFR: CODETOOLS-7903560: JMH: async profiler reports only the last fork result
Aleksey Shipilev
shade at openjdk.org
Wed Sep 27 11:50:01 UTC 2023
On Thu, 21 Sep 2023 14:43:29 GMT, Jonas Konrad <duke at openjdk.org> wrote:
> Without this change, async-profiler would write the same result in each fork, overwriting the previous result.
>
> This patch introduces a new "FileResult" class that collects the output paths of each benchmark. In `afterTrial`, the output files are moved to a new path that includes the pid (fork number would be an alternative but it's not as easily available).
>
> At the moment, results of different runs are not coalesced. But with these changes, it would be easy to coalesce at least the results of the "collapsed" output mode. I plan to do this in another PR.
Also, go to https://github.com/yawkat/jmh/actions and enable testing.
I'll take a look later, but I think new files miss license headers. If you run Maven build, the license plugin is supposed to drop some headers there, which would need some copyright year adjustments. When you push, that would also trigger GHA run, which might reveal some problems.
Merge from master to get JDK 21 as test config.
-------------
PR Comment: https://git.openjdk.org/jmh/pull/121#issuecomment-1729795762
PR Comment: https://git.openjdk.org/jmh/pull/121#issuecomment-1730055205
More information about the jmh-dev
mailing list