RFR: 7903696: JMH: Add xctrace-based perfasm profiler for macOS [v3]
Filipp Zhinkin
fzhinkin at openjdk.org
Tue Apr 23 09:21:42 UTC 2024
On Tue, 23 Apr 2024 09:01:16 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> The intention was to remove the directory no matter what.
>>
>> `TempFile`s (like `hsLog`) should be removed by an on-exit hook, thanks to `deleteOnExit` called from `TempFileManager::create`. For directories, there's no such mechanism, so I decided to rely on `try-finally` instead.
>
> I was just asking if you want to avoid `finally` control flow here and just call it after `super.afterTrial` call. But that's optional, we can clean it up later.
In that case, if `super.afterTrial` will throw something, the directory won't be deleted.
-------------
PR Review Comment: https://git.openjdk.org/jmh/pull/130#discussion_r1575931734
More information about the jmh-dev
mailing list