RFR: 7903740: JMH: Perf event validation not working with skid options [v2]

Galder Zamarreño galder at openjdk.org
Fri Aug 16 05:14:01 UTC 2024


On Wed, 14 Aug 2024 08:51:13 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Fixes https://bugs.openjdk.org/browse/CODETOOLS-7903740
>
> Galder Zamarreño has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - --log-fd not valid for perf record
>  - Switch to testing with perf record

Hmmm, I think the error is caused because profiler supported check now passes when running in CI, whereas in the past this tests didn't attempt to run.

Although you cannot see the `Profiler is not supported or cannot be enabled, skipping test` message in successful JMH CI runs (e.g. [here](https://github.com/galderz/jmh/actions/runs/9320525801/job/25657504861)), you can see that the test runs in `0.218 sec` and so it must be passing because it sees the profiler is not supported.

With my change, it seems now the test thinks the profiler is supported, but then no secondary results are obtained.

I'm unsure how to deal with this yet.

-------------

PR Comment: https://git.openjdk.org/jmh/pull/132#issuecomment-2292819563


More information about the jmh-dev mailing list