RFR: 7903740: JMH: Perf event validation not working with skid options [v2]
Galder Zamarreño
galder at openjdk.org
Fri Aug 16 08:03:03 UTC 2024
On Thu, 15 Aug 2024 10:55:37 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Galder Zamarreño has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - --log-fd not valid for perf record
>> - Switch to testing with perf record
>
> There are GHA test failures, not sure if they are due to this fix, please check?
@shipilev Are you sure these issues are also present in the main branch? I don't see any main branch CI runs and I don't see any recent CI jobs other than the one here.
I wonder if something has changed in the way CI environments run with regards to perf. In the [May run](https://github.com/galderz/jmh/actions/runs/9320525801/job/25657504861) I pointed above linux perf asm tests where not really executing. That means that `perf stat --event cycles --log-fd 2 echo 1` was outright failing or it was returning `<not supported>`, but that seems to work fine now, see [this test](https://github.com/galderz/github-actions/actions/runs/10416583777/job/28849112742) I've just run today.
It would be useful to have a way to see if `main` branch is really affected by the CI failures here. I can't see how it's not.
-------------
PR Comment: https://git.openjdk.org/jmh/pull/132#issuecomment-2293023344
More information about the jmh-dev
mailing list