RFR: 7903740: JMH: Perf event validation not working with skid options [v4]

[Aleksey Shipilev]

On Fri, 16 Aug 2024 10:43:34 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Fixes https://bugs.openjdk.org/browse/CODETOOLS-7903740
>
> Galder Zamarreño has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - Remove previous approach
>  - Use trim to remove any empty spaces or carriage returns
>  - Do not make it quiet otherwise there's no output
>  - Try perf report from specific file

After two fixes merged in last hour, current master passes GHA. So this PR should also pass :)

jmh-core/src/main/java/org/openjdk/jmh/profile/LinuxPerfAsmProfiler.java line 57:

> 55: 
> 56:         for (String ev : requestedEventNames) {
> 57:             String reportCmd = String.format("perf report -i perf-record-validate.data --stdio | grep %s | wc -l", ev);

Why can't we just use `perf record --event $requestedEventNames --output $tempdir echo 1`? I think that would be enough to sense if events are supported? There is no need to call into `perf report` then.

-------------

PR Review: https://git.openjdk.org/jmh/pull/132#pullrequestreview-2250967886
PR Review Comment: https://git.openjdk.org/jmh/pull/132#discussion_r1725151206