RFR: 7903910: JMH: Strengthen manual hierarchical padding
Claes Redestad
redestad at openjdk.org
Fri Dec 13 17:24:50 UTC 2024
On Fri, 13 Dec 2024 16:27:47 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Generated code uses 256 byte fields to provide hierarchical padding. JMH infrastructure classes, however, only do 128 boolean fields. We need to make sure we use the same padding code in manual infra as in the generated code.
LGTM (still no code tools reviewer/committer bit, though, if that's needed.)
More generally do you think there could be any benefit from changing to `long` padding fields to reduce size of generated code, or would that have too many issues with layout on different VM impls?
-------------
Marked as reviewed by redestad (no project role).
PR Review: https://git.openjdk.org/jmh/pull/146#pullrequestreview-2502789569
More information about the jmh-dev
mailing list