RFR: CODETOOLS-7903560: JMH: async profiler reports only the last fork result [v6]

Aleksey Shipilev shade at openjdk.org
Tue Feb 27 16:43:56 UTC 2024


On Tue, 27 Feb 2024 15:58:13 GMT, Jonas Konrad <duke at openjdk.org> wrote:

>> Without this change, async-profiler would write the same result in each fork, overwriting the previous result.
>> 
>> This patch introduces a new "FileResult" class that collects the output paths of each benchmark. In `afterTrial`, the output files are moved to a new path that includes the pid (fork number would be an alternative but it's not as easily available).
>> 
>> At the moment, results of different runs are not coalesced. But with these changes, it would be easy to coalesce at least the results of the "collapsed" output mode. I plan to do this in another PR.
>
> Jonas Konrad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix AsyncProfilerTest

Seems like the basic tests have passed. I am pretty sure the rest would pass. Once GHA is fully green, feel free to integrate.

-------------

Marked as reviewed by shade (Committer).

PR Review: https://git.openjdk.org/jmh/pull/121#pullrequestreview-1904118466


More information about the jmh-dev mailing list