Integrated: CODETOOLS-7903560: JMH: async profiler reports only the last fork result

Jonas Konrad duke at openjdk.org
Wed Feb 28 12:24:55 UTC 2024


On Thu, 21 Sep 2023 14:43:29 GMT, Jonas Konrad <duke at openjdk.org> wrote:

> Without this change, async-profiler would write the same result in each fork, overwriting the previous result.
> 
> This patch introduces a new "FileResult" class that collects the output paths of each benchmark. In `afterTrial`, the output files are moved to a new path that includes the pid (fork number would be an alternative but it's not as easily available).
> 
> At the moment, results of different runs are not coalesced. But with these changes, it would be easy to coalesce at least the results of the "collapsed" output mode. I plan to do this in another PR.

This pull request has now been integrated.

Changeset: 641f0480
Author:    yawkat <jonas.konrad at oracle.com>
Committer: Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jmh/commit/641f0480632f47e0dbdbf454105bbda550dd5eb7
Stats:     346 lines in 4 files changed: 319 ins; 12 del; 15 mod

7903560: JMH: async profiler reports only the last fork result

Without this change, async-profiler would write the same result in each fork, overwriting the previous result.

This patch introduces a new "FileResult" class that collects the output paths of each benchmark. In afterTrial, the output files are copied to a new path that includes the pid (fork number would be an alternative but it's not as easily available).

Reviewed-by: shade

-------------

PR: https://git.openjdk.org/jmh/pull/121


More information about the jmh-dev mailing list