RFR: 7903740: JMH: Perf event validation not working with skid options
Galder Zamarreño
galder at openjdk.org
Thu Jul 25 04:41:43 UTC 2024
On Fri, 19 Jul 2024 13:44:11 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Fixes https://bugs.openjdk.org/browse/CODETOOLS-7903740
>
> Okay, so the point for initialization checks to fail early, before we actually get to executing benchmarks. What would happen when event with option is not supported by `perf record`? Suppose `events` is supported and `events:ppp` is not. We check `events` and it works, we proceed to using `events:ppp` at runtime and fail.
>
> Since there is an apparent discrepancy between what `perf record` and `perf stat` accept, I think we need to validate with `perf record` then. Something easy, like `perf record -e ... echo 1` would likely work well?
@shipilev Makes sense, I'll look into validating that.
-------------
PR Comment: https://git.openjdk.org/jmh/pull/132#issuecomment-2249371424
More information about the jmh-dev
mailing list