RFR: 7903740: JMH: Perf event validation not working with skid options [v6]

[Galder Zamarreño]

On Fri, 6 Sep 2024 11:33:36 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Fixes https://bugs.openjdk.org/browse/CODETOOLS-7903740
>
> Galder Zamarreño has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
> 
>  - Add -q to avoid additional perf record messages
>  - Pipe through perf report --stats instead
>  - Merge branch 'master' into topic.validate-perf-event-without-modifier
>  - Check all events with perf report in a single command
>  - Remove previous approach
>  - Use trim to remove any empty spaces or carriage returns
>  - Do not make it quiet otherwise there's no output
>  - Try perf report from specific file
>  - Remove old approaches
>  - Explicitly define an output file for perf record validation
>  - ... and 5 more: https://git.openjdk.org/jmh/compare/f37167a1...069447e1

> Remember: the capabilities check in constructor is an opportunistic check, it can pass by accident, and users would discover their profiler does not really work later when looking at the results. The check should NOT fail by accident, when the profiler would actually work, if not for a misbehaving capability check.

Makes sense and I agree with you, but my previous efforts on this PR show that the CI is getting in the way of what you said above. E.g. see what happened in https://github.com/galderz/jmh/actions/runs/10384414105/job/28751371192, where the check passes by accident but then the profiler contains no data, so the test fails.

Closed the PR by mistake.

-------------

PR Comment: https://git.openjdk.org/jmh/pull/132#issuecomment-2404921965
PR Comment: https://git.openjdk.org/jmh/pull/132#issuecomment-2404924502