RFR: 7903740: JMH: Perf event validation not working with skid options [v7]

Aleksey Shipilev shade at openjdk.org
Fri Oct 11 09:36:24 UTC 2024


On Fri, 11 Oct 2024 04:57:58 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Fixes https://bugs.openjdk.org/browse/CODETOOLS-7903740
>
> Galder Zamarreño has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Avoid reading the perf record output

Maybe the GH runner does not have PMU enabled? Given that it works in manual runs, I think it is fine if we just fix the test. It is not worth the hassle to fight GH infra, IMO. See how Windows perfasm test does it: https://github.com/openjdk/jmh/blob/c2931c90fd4079271b69a8a393dfe277634f3e52/jmh-core-it/src/test/java/org/openjdk/jmh/it/profilers/WinPerfAsmProfilerTest.java#L60

I am going to test the patch locally too.

-------------

PR Comment: https://git.openjdk.org/jmh/pull/132#issuecomment-2407020005


More information about the jmh-dev mailing list