RFR: 7903740: JMH: Perf event validation not working with skid options [v6]
Galder Zamarreño
galder at openjdk.org
Fri Sep 6 11:40:03 UTC 2024
On Fri, 6 Sep 2024 11:33:36 GMT, Galder Zamarreño <galder at openjdk.org> wrote:
>> Fixes https://bugs.openjdk.org/browse/CODETOOLS-7903740
>
> Galder Zamarreño has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revision:
>
> - Add -q to avoid additional perf record messages
> - Pipe through perf report --stats instead
> - Merge branch 'master' into topic.validate-perf-event-without-modifier
> - Check all events with perf report in a single command
> - Remove previous approach
> - Use trim to remove any empty spaces or carriage returns
> - Do not make it quiet otherwise there's no output
> - Try perf report from specific file
> - Remove old approaches
> - Explicitly define an output file for perf record validation
> - ... and 5 more: https://git.openjdk.org/jmh/compare/e23f4e45...069447e1
Ian, I've pushed changes based on your feedback. I think that does the job very nicely.
-------------
PR Comment: https://git.openjdk.org/jmh/pull/132#issuecomment-2333864915
More information about the jmh-dev
mailing list