RFR: 7903722: JMH: Add xctrace-based perfnorm profiler for macOS [v2]
Filipp Zhinkin
fzhinkin at openjdk.org
Mon Sep 23 16:04:52 UTC 2024
On Mon, 23 Sep 2024 13:45:51 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Filipp Zhinkin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
>>
>> - Merge branch 'master' into xctracenorm-prof
>> - 7903722: Use default template instead of generating a package
>> - 7903722: Add extra tests
>> - 7903722: Scan all possible KPEP file locations
>> - 7903722: Serialize xctrace tests execution
>> - 7903722: simplified code, added missing docs, supported branch events
>> - 7903722: Improve events preprocessing
>> - 7903722: Refactor KPEP database loading
>> - 7903722: compute AS Arm64 instructions density metrics
>> - 7903722: check if all listed events could be sampled simultaneously
>> - ... and 6 more: https://git.openjdk.org/jmh/compare/0440ac46...5a112315
>
> jmh-core-it/src/test/java/org/openjdk/jmh/it/profilers/XCTraceNormProfilerTest.java line 171:
>
>> 169:
>> 170: RunResult result;
>> 171: File templateFile = FileUtils.extractFromResource("/XCTraceNormTestTemplate.xml");
>
> Is there any reasonable difference between this template file and the one we ship in `jmh-core/src/main/resources/default.instruments.template.xml`? Can we use that one instead?
It uses different event settings. Given the test checking that not-existing / wrong template won't work, it indeed should be fine to result the default template.
-------------
PR Review Comment: https://git.openjdk.org/jmh/pull/131#discussion_r1771726746
More information about the jmh-dev
mailing list