RFR: 7904047: JMH: support async-profiler 4.0 options [v2]
Andrei Pangin
apangin at openjdk.org
Fri Jun 27 14:03:02 UTC 2025
On Wed, 25 Jun 2025 10:22:49 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Andrei Pangin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>>
>> 7904047: JMH: support async-profiler 4.0 options
>
> On the other hand, we also have GHA check here: https://github.com/openjdk/jmh/blob/872b7203c294d90c17766d19fc9f71cea5885380/.github/workflows/pre-integration.yml#L65-L69 -- which apparently shows this code works with 3.0. I assume 4.0 is the recommended version? If so, bump GHA check to pick up 4.0.
@shipilev Thank you for the review, I updated GHA workflow to use async-profiler 4.0. Changes are compatible with all profiler versions. If user specifies an option specific to 4.0 while running and earlier profiler version, JMH will not check it by itself, but an exception will be thrown directly from libasyncProfiler, which I think is expected behavior.
-------------
PR Comment: https://git.openjdk.org/jmh/pull/159#issuecomment-3013188340
More information about the jmh-dev
mailing list