From Luis-Miguel.Alventosa at Sun.COM Thu Jun 5 08:00:01 2008 From: Luis-Miguel.Alventosa at Sun.COM (Luis-Miguel Alventosa) Date: Thu, 05 Jun 2008 17:00:01 +0200 Subject: jmx-dev Request for review: CR 6711106: REGRESSION: Bad usage of SnapshotMBeanServerConnection in MBeans tab and JConsole plugins. Message-ID: <4847FF71.3010609@Sun.COM> FYI Looking for a reviewer in order to commit the changes into OpenJDK 7. Thanks, Luis -------------- next part -------------- A non-text attachment was scrubbed... Name: jdk.patch Type: text/x-patch Size: 7173 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/jmx-dev/attachments/20080605/63153d86/attachment.bin From Jean-Francois.Denise at Sun.COM Thu Jun 5 08:35:56 2008 From: Jean-Francois.Denise at Sun.COM (Jean-Francois Denise) Date: Thu, 05 Jun 2008 17:35:56 +0200 Subject: jmx-dev Request for review: CR 6711106: REGRESSION: Bad usage of SnapshotMBeanServerConnection in MBeans tab and JConsole plugins. In-Reply-To: <4847FF71.3010609@Sun.COM> References: <4847FF71.3010609@Sun.COM> Message-ID: <484807DC.2040007@Sun.COM> Reviewed OK. Luis-Miguel Alventosa wrote: > FYI > > Looking for a reviewer in order to commit the changes into OpenJDK 7. > > Thanks, > Luis -- Jean-Francois Denise JMX team Interested in netbeans ==> http://blogs.sun.com/roller/page/jmxnetbeans From Eamonn.McManus at Sun.COM Mon Jun 9 08:48:43 2008 From: Eamonn.McManus at Sun.COM (Eamonn McManus) Date: Mon, 09 Jun 2008 17:48:43 +0200 Subject: jmx-dev Review request: 6323980: Annotations to simplify MBean development Message-ID: <484D50DB.3040407@sun.com> I'm looking for reviewers for this fairly substantial change to the JMX API and implementation in JDK7. I need at least one reviewer with commit rights to openjdk. Any other reviewers will be acknowledged in the changeset message. The context: http://weblogs.java.net/blog/emcmanus/archive/2007/08/defining_mbeans.html The specification changes: http://weblogs.java.net/blog/emcmanus/archive/6323980-specdiff.html The code changes: http://weblogs.java.net/blog/emcmanus/archive/6323980-webrev.zip Thanks, -- ?amonn McManus JMX Spec Lead http://weblogs.java.net/blog/emcmanus/ From Jean-Francois.Denise at Sun.COM Tue Jun 10 00:11:30 2008 From: Jean-Francois.Denise at Sun.COM (Jean-Francois Denise) Date: Tue, 10 Jun 2008 09:11:30 +0200 Subject: jmx-dev Review request: 6323980: Annotations to simplify MBean development In-Reply-To: <484D50DB.3040407@sun.com> References: <484D50DB.3040407@sun.com> Message-ID: <484E2922.7030700@Sun.COM> Hello Eamonn, I mainly focus on new Annotations and impact on public classes. I noticed that Description Annotation targets FIELD. I was not able to find a case where the FIELD target is needed. But perhaps that I missed something there. JF. Eamonn McManus wrote: > I'm looking for reviewers for this fairly substantial change to the > JMX API and implementation in JDK7. I need at least one reviewer with > commit rights to openjdk. Any other reviewers will be acknowledged in > the changeset message. > > The context: > http://weblogs.java.net/blog/emcmanus/archive/2007/08/defining_mbeans.html > > > The specification changes: > http://weblogs.java.net/blog/emcmanus/archive/6323980-specdiff.html > > The code changes: > http://weblogs.java.net/blog/emcmanus/archive/6323980-webrev.zip > > Thanks, > -- Jean-Francois Denise JMX team Interested in netbeans ==> http://blogs.sun.com/roller/page/jmxnetbeans From Eamonn.McManus at Sun.COM Tue Jun 10 01:46:48 2008 From: Eamonn.McManus at Sun.COM (Eamonn McManus) Date: Tue, 10 Jun 2008 10:46:48 +0200 Subject: jmx-dev Review request: 6323980: Annotations to simplify MBean development In-Reply-To: <484E2922.7030700@Sun.COM> References: <484D50DB.3040407@sun.com> <484E2922.7030700@Sun.COM> Message-ID: <484E3F78.4040607@sun.com> JF, Excellent point! Although we might imagine that someone would want to reuse the @Description annotation for another purpose where FIELD would be valid, I don't think they would gain much doing that versus creating their own @Description with the semantics they want. So we should remove FIELD from the @Target, at least until we do use it for something. Thanks, ?amonn McManus JMX Spec Lead http://weblogs.java.net/blog/emcmanus/ Jean-Francois Denise wrote: > Hello Eamonn, > I mainly focus on new Annotations and impact on public classes. I > noticed that Description Annotation targets FIELD. I was not able to > find a case where the FIELD target is needed. But perhaps that I > missed something there. > > JF. > > > Eamonn McManus wrote: >> I'm looking for reviewers for this fairly substantial change to the >> JMX API and implementation in JDK7. I need at least one reviewer with >> commit rights to openjdk. Any other reviewers will be acknowledged in >> the changeset message. >> >> The context: >> http://weblogs.java.net/blog/emcmanus/archive/2007/08/defining_mbeans.html >> >> >> The specification changes: >> http://weblogs.java.net/blog/emcmanus/archive/6323980-specdiff.html >> >> The code changes: >> http://weblogs.java.net/blog/emcmanus/archive/6323980-webrev.zip >> >> Thanks, >> > > From Daniel.Fuchs at Sun.COM Thu Jun 19 08:34:55 2008 From: Daniel.Fuchs at Sun.COM (Daniel Fuchs) Date: Thu, 19 Jun 2008 17:34:55 +0200 Subject: jmx-dev Review request: 6323980: Annotations to simplify MBean development In-Reply-To: <484D50DB.3040407@sun.com> References: <484D50DB.3040407@sun.com> Message-ID: <485A7C9F.5000901@sun.com> Hi Eamonn, Sorry for the late review. Here is my feedback: com/sun/jmx/mbeanserver/Introspector.java getStandardMBeanInterface() can now also return a class (not necessarily an interface). Maybe the method javadoc could say so. addDescriptorFieldsToMap(), addAnnotationFieldsToMap(): I think I understand the logic there, but if I ever have to fix something in this code I'll be very grateful to find a comment with an example of annotated class and an explanation of what each of these methods looks for in the annotated class. test/javax/management/Introspector/AnnotatedMBeanTest.java This test could also check that Impact=UNKNOWN by default, and add an @ManagedOperation method where Impact is set to something else. -- daniel http://blogs.sun.com/jmxetc Eamonn McManus wrote: > I'm looking for reviewers for this fairly substantial change to the JMX > API and implementation in JDK7. I need at least one reviewer with commit > rights to openjdk. Any other reviewers will be acknowledged in the > changeset message. > > The context: > http://weblogs.java.net/blog/emcmanus/archive/2007/08/defining_mbeans.html > > The specification changes: > http://weblogs.java.net/blog/emcmanus/archive/6323980-specdiff.html > > The code changes: > http://weblogs.java.net/blog/emcmanus/archive/6323980-webrev.zip > > Thanks, >