jmx-dev Review request: 6323980: Annotations to simplify MBean development

[Daniel Fuchs]

Hi Eamonn,

Sorry for the late review. Here is my feedback:

com/sun/jmx/mbeanserver/Introspector.java

getStandardMBeanInterface()
can now also return a class (not necessarily  an interface).
Maybe the method javadoc could say so.

addDescriptorFieldsToMap(), addAnnotationFieldsToMap():
I think I understand the logic there, but if I ever have to
fix something in this code I'll be very grateful to find a comment
with an example of annotated class and an explanation of what each
of these methods looks for in the annotated class.

test/javax/management/Introspector/AnnotatedMBeanTest.java

This test could also check that Impact=UNKNOWN by default, and
add an @ManagedOperation method where Impact is set to
something else.

-- daniel
http://blogs.sun.com/jmxetc

Eamonn McManus wrote:
> I'm looking for reviewers for this fairly substantial change to the JMX 
> API and implementation in JDK7. I need at least one reviewer with commit 
> rights to openjdk. Any other reviewers will be acknowledged in the 
> changeset message.
> 
> The context: 
> http://weblogs.java.net/blog/emcmanus/archive/2007/08/defining_mbeans.html
> 
> The specification changes: 
> http://weblogs.java.net/blog/emcmanus/archive/6323980-specdiff.html
> 
> The code changes: 
> http://weblogs.java.net/blog/emcmanus/archive/6323980-webrev.zip
> 
> Thanks,
>