From Eamonn.McManus at Sun.COM Wed Mar 19 06:16:26 2008 From: Eamonn.McManus at Sun.COM (Eamonn McManus) Date: Wed, 19 Mar 2008 14:16:26 +0100 Subject: jmx-dev Code review requested: 6675768: java.util.NoSuchElementException thrown in RequiredModelMBean when tracing enabled Message-ID: <47E1122A.4080602@sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jmx-dev/attachments/20080319/da491134/attachment.html -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: fix6675768.txt Url: http://mail.openjdk.java.net/pipermail/jmx-dev/attachments/20080319/da491134/attachment.txt From Daniel.Fuchs at Sun.COM Wed Mar 19 06:34:16 2008 From: Daniel.Fuchs at Sun.COM (Daniel Fuchs) Date: Wed, 19 Mar 2008 14:34:16 +0100 Subject: jmx-dev Code review requested: 6675768: java.util.NoSuchElementException thrown in RequiredModelMBean when tracing enabled In-Reply-To: <47E1122A.4080602@sun.com> References: <47E1122A.4080602@sun.com> Message-ID: <47E11658.9010200@sun.com> Review OK. -- daniel http://blogs.sun.com/jmxetc Eamonn McManus wrote: > This change is simple and self-contained so I'm just sending out a diff > here. The bug report is CR 6675768 > and the affected source > file is javax/management/modelmbean/RequiredModelMBean.java > . > As usual, there is a regression test. While investigating this fix, I > noticed that the regression test for the similar bug 6471865 > somehow failed to be > included in the migration to Mercurial, so the new test here is actually > the one for 6471865 with an extra case added for 6675768. > > Thanks, > > -- > ?amonn McManus JMX Spec Lead http://weblogs.java.net/blog/emcmanus/ > From Eamonn.McManus at Sun.COM Wed Mar 19 07:21:53 2008 From: Eamonn.McManus at Sun.COM (Eamonn McManus) Date: Wed, 19 Mar 2008 15:21:53 +0100 Subject: jmx-dev Code review requested: 6675768: java.util.NoSuchElementException thrown in RequiredModelMBean when tracing enabled In-Reply-To: <47E11658.9010200@sun.com> References: <47E1122A.4080602@sun.com> <47E11658.9010200@sun.com> Message-ID: <47E12181.10003@sun.com> Thanks! The change has now been pushed to http://hg.openjdk.java.net/jdk7/tl-gate/jdk. ?amonn McManus JMX Spec Lead http://weblogs.java.net/blog/emcmanus/ Daniel Fuchs wrote: > Review OK. > > -- daniel > http://blogs.sun.com/jmxetc > > Eamonn McManus wrote: >> This change is simple and self-contained so I'm just sending out a >> diff here. The bug report is CR 6675768 >> and the affected >> source file is javax/management/modelmbean/RequiredModelMBean.java >> . >> As usual, there is a regression test. While investigating this fix, I >> noticed that the regression test for the similar bug 6471865 >> somehow failed to be >> included in the migration to Mercurial, so the new test here is >> actually the one for 6471865 with an extra case added for 6675768. >> >> Thanks, >> >> -- >> ?amonn McManus JMX Spec Lead http://weblogs.java.net/blog/emcmanus/ >> > >